[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 Orion Poplawski changed: What|Removed |Added Depends On||829580 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3tG3xcBS7k&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 --- Comment #1 from Orion Poplawski --- Okay, just updated the package to split off docs and such. Should be good to go. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=k5GtD0kKz0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 Bug 958523 depends on bug 829580, which changed state. Bug 829580 Summary: Review Request: python-traitsui - User interface tools designed to complement Traits https://bugzilla.redhat.com/show_bug.cgi?id=829580 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vF2OzWUZK6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 Rahul Sundaram changed: What|Removed |Added CC||methe...@gmail.com Assignee|nob...@fedoraproject.org|methe...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xeCBCDm77N&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 --- Comment #2 from Orion Poplawski --- * Tue May 7 2013 Orion Poplawski - 4.3.0-2 - Fix line-endings, cleanup some files - Fix license tag http://www.cora.nwra.com/~orion/fedora/python-envisage-4.3.0-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QncRZ6oyPv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 --- Comment #3 from Orion Poplawski --- Rahul - will you be reviewing this soon or should I try to find someone else? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x6Q2Cwe5mM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 Rahul Sundaram changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #4 from Rahul Sundaram --- Will do this in the weekend -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5z81KPDznS&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 --- Comment #5 from Orion Poplawski --- Rahul - ping? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dNbJReUNGc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958523
--- Comment #6 from Rahul Sundaram ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Binary eggs must be removed in %prep
Note: Binary egg files not removed in %prep:
./envisage/tests/eggs/acme.bar-0.1a1-py2.7.egg
./envisage/tests/eggs/acme.baz-0.1a1-py2.7.egg
./envisage/tests/eggs/acme.foo-0.1a1-py2.7.egg
See:
http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools_concerns
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
envisage-doc
[x]: Package complies to the Packaging Guidelines
[?]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 356 files have unknown license. Detailed output
of licensecheck in /home/rahul/work/958523-python-
envisage/licensecheck.txt
This is not a blocker but ideally upstreams should include per file copyright
notices and you should request them to do it
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
You should add a comment on top of requires
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 30720 bytes in 4 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[?]: Package meets the Packaging Guidelines::Python
Does upstream have an Python3 build?
[x]: Package contains BR: python2-devel or python3-devel
= SHOULD items =
Generic:
[!]: Uses parallel make.
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 --- Comment #7 from Orion Poplawski --- * Tue May 14 2013 Orion Poplawski - 4.3.0-3 - Remove shipped egg-info and eggs http://www.cora.nwra.com/~orion/fedora/python-envisage-4.3.0-3.fc18.src.rpm I'll send a message about adding license headers. I've not had much success with python 3 on a lot of these packages. Need to start from the bottom. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kRTYWtUTvs&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 Rahul Sundaram changed: What|Removed |Added Flags||fedora-review+ --- Comment #8 from Rahul Sundaram --- Depending on whether you need a older EPEL branch, you don't need to define that macro on top but I assume you already know that. I don't see any outstanding blockers. == APPROVED == -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9BEHEjXHhb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 Orion Poplawski changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Orion Poplawski --- Thanks. New Package SCM Request === Package Name: python-envisage Short Description: Extensible application framework Owners: orion Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=99dxL9Ufkp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zuHMr3Eud8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JrLuJL9Baq&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958523] Review Request: python-envisage - Extensible application framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958523 Orion Poplawski changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-05-14 14:37:55 --- Comment #11 from Orion Poplawski --- Checked in and built. Thanks all. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L59SVn55wM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
