[Bug 959657] Review Request: drupal7-translation_overview - Provides an overview of the translation status of site's content
https://bugzilla.redhat.com/show_bug.cgi?id=959657 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-06-22 12:50:36 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=O9DxhByHgEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959657] Review Request: drupal7-translation_overview - Provides an overview of the translation status of site's content
https://bugzilla.redhat.com/show_bug.cgi?id=959657 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1U2kVRKaBoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959657] Review Request: drupal7-translation_overview - Provides an overview of the translation status of site's content
https://bugzilla.redhat.com/show_bug.cgi?id=959657 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SudKoaT24Ha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959657] Review Request: drupal7-translation_overview - Provides an overview of the translation status of site's content
https://bugzilla.redhat.com/show_bug.cgi?id=959657 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Flags|fedora-review+ | Flags||fedora-review? Flags||fedora-cvs? --- Comment #3 from Shawn Iwinski shawn.iwin...@gmail.com --- THANKS for the review! New Package SCM Request === Package Name: drupal7-translation_overview Short Description: Provides an overview of the translation status of site's content Owners: siwinski asrob Branches: f17 f18 f19 el5 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5yNk9Vzjsva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959657] Review Request: drupal7-translation_overview - Provides an overview of the translation status of site's content
https://bugzilla.redhat.com/show_bug.cgi?id=959657 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from Shawn Iwinski shawn.iwin...@gmail.com --- Oooops, I reset the fedora-review flag! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ogWkxtTkdKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959657] Review Request: drupal7-translation_overview - Provides an overview of the translation status of site's content
https://bugzilla.redhat.com/show_bug.cgi?id=959657 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Alias|d7-trans_overview |drupal7-translation_overvie ||w --- Comment #1 from Shawn Iwinski shawn.iwin...@gmail.com --- Updated for drupal7-rpmbuild 7.22-5 (NOTE: rpmlint E: incorrect-fsf-address which will get fixed with next upstream release) Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/drupal7-translation_overview.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/drupal7-translation_overview-2.0-0.2.beta1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hKf41nxb4Wa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959657] Review Request: drupal7-translation_overview - Provides an overview of the translation status of site's content
https://bugzilla.redhat.com/show_bug.cgi?id=959657
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mario.blaetterm...@gmail.co
||m
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review+
--- Comment #2 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5485213
$ rpmlint -i -v *drupal7-translation_overview.src: I: checking
drupal7-translation_overview.src: I: checking-url
http://drupal.org/project/translation_overview (timeout 10 seconds)
drupal7-translation_overview.src: I: checking-url
http://ftp.drupal.org/files/projects/translation_overview-7.x-2.0-beta1.tar.gz
(timeout 10 seconds)
drupal7-translation_overview.noarch: I: checking
drupal7-translation_overview.noarch: I: checking-url
http://drupal.org/project/translation_overview (timeout 10 seconds)
drupal7-translation_overview.noarch: E: incorrect-fsf-address
/usr/share/doc/drupal7-translation_overview-2.0/LICENSE.txt
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
drupal7-translation_overview.spec: I: checking-url
http://ftp.drupal.org/files/projects/translation_overview-7.x-2.0-beta1.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 1 errors, 0 warnings.
Besides the outdated FSF address, rpmlint is silent.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv2+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
29b3f0328875ba1e1fbf6c2e0c5a10badf9ad060c5598b44b9a713a9c14bfe4b
translation_overview-7.x-2.0-beta1.tar.gz
29b3f0328875ba1e1fbf6c2e0c5a10badf9ad060c5598b44b9a713a9c14bfe4b
translation_overview-7.x-2.0-beta1.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then
[Bug 959657] Review Request: drupal7-translation_overview - Provides an overview of the translation status of site's content
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=959657 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Alias||d7-trans_overview -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4hWwrtPYM0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
