[Bug 959658] Review Request: drupal7-translation_helpers - Provides methods for other modules to use with translated content
https://bugzilla.redhat.com/show_bug.cgi?id=959658 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-06-22 12:50:58 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Lph41xAOvOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959658] Review Request: drupal7-translation_helpers - Provides methods for other modules to use with translated content
https://bugzilla.redhat.com/show_bug.cgi?id=959658 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Alias|d7-trans_helpers|drupal7-translation_helpers -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WO69SZFZS2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959658] Review Request: drupal7-translation_helpers - Provides methods for other modules to use with translated content
https://bugzilla.redhat.com/show_bug.cgi?id=959658 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2QoADpRsT0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959658] Review Request: drupal7-translation_helpers - Provides methods for other modules to use with translated content
https://bugzilla.redhat.com/show_bug.cgi?id=959658 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T3LRglQqJaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959658] Review Request: drupal7-translation_helpers - Provides methods for other modules to use with translated content
https://bugzilla.redhat.com/show_bug.cgi?id=959658 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Shawn Iwinski shawn.iwin...@gmail.com --- THANKS for the review! New Package SCM Request === Package Name: drupal7-translation_helpers Short Description: Provides methods for other modules to use with translated content Owners: siwinski asrob Branches: f17 f18 f19 el5 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VTstmVc2Fza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959658] Review Request: drupal7-translation_helpers - Provides methods for other modules to use with translated content
https://bugzilla.redhat.com/show_bug.cgi?id=959658
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #4 from Mario Blättermann mario.blaetterm...@gmail.com ---
(In reply to Shawn Iwinski from comment #3)
Ahhh... you seem to be the first one using drupal7[-rpmbuild] 7.22-5 :)
Auto-provides were added with 7.22-4 and auto-requires (among other
features) were added with 7.22-5. This package was submitted for review
before either of those releases so that explains the duplicates. I am going
to update all of my drupal7-* package requests to use the new format when
drupal7 7.22-5 is released to stable. Until then, if you would like to
review any of the other drupal7-* package reviews I have open, please ask me
to update before you do your review.
For all my reviews I build Rawhide packages on Koji or Mock, so that I'm using
inescapably the newest technologies :) BTW, I don't use Drupal at all, but with
my translator's hat on, I'm interested in all stuff which refers to i18n.
Drupal modules don't seem to be the greatest challenges for a reviewer, so I
will probably do some more reviews.
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5484850
$ rpmlint -i -v *drupal7-translation_helpers.src: I: checking
drupal7-translation_helpers.src: W: spelling-error %description -l en_US tnid
- Enid, tn id, tn-id
The value of this tag appears to be misspelled. Please double-check.
drupal7-translation_helpers.src: I: checking-url
http://drupal.org/project/translation_helpers (timeout 10 seconds)
drupal7-translation_helpers.src: I: checking-url
http://ftp.drupal.org/files/projects/translation_helpers-7.x-1.0.tar.gz
(timeout 10 seconds)
drupal7-translation_helpers.noarch: I: checking
drupal7-translation_helpers.noarch: W: spelling-error %description -l en_US
tnid - Enid, tn id, tn-id
The value of this tag appears to be misspelled. Please double-check.
drupal7-translation_helpers.noarch: I: checking-url
http://drupal.org/project/translation_helpers (timeout 10 seconds)
drupal7-translation_helpers.spec: I: checking-url
http://ftp.drupal.org/files/projects/translation_helpers-7.x-1.0.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Nothing of interest.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv2+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
39f6d9c7203b3d89e3a3dc33efee89723a43400c8db45d5b34bcf968d774b5c0
translation_helpers-7.x-1.0.tar.gz
39f6d9c7203b3d89e3a3dc33efee89723a43400c8db45d5b34bcf968d774b5c0
translation_helpers-7.x-1.0.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[Bug 959658] Review Request: drupal7-translation_helpers - Provides methods for other modules to use with translated content
https://bugzilla.redhat.com/show_bug.cgi?id=959658 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mario.blaetterm...@gmail.co ||m Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? --- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5483260 $ rpmlint -i -v *drupal7-translation_helpers.src: I: checking drupal7-translation_helpers.src: W: spelling-error %description -l en_US tnid - Enid, tn id, tn-id The value of this tag appears to be misspelled. Please double-check. drupal7-translation_helpers.src: I: checking-url http://drupal.org/project/translation_helpers (timeout 10 seconds) drupal7-translation_helpers.src: I: checking-url http://ftp.drupal.org/files/projects/translation_helpers-7.x-1.0.tar.gz (timeout 10 seconds) drupal7-translation_helpers.noarch: I: checking drupal7-translation_helpers.noarch: W: spelling-error %description -l en_US tnid - Enid, tn id, tn-id The value of this tag appears to be misspelled. Please double-check. drupal7-translation_helpers.noarch: I: checking-url http://drupal.org/project/translation_helpers (timeout 10 seconds) drupal7-translation_helpers.noarch: E: useless-provides drupal7(translation_helpers) This package provides 2 times the same capacity. It should only provide it once. drupal7-translation_helpers.spec: I: checking-url http://ftp.drupal.org/files/projects/translation_helpers-7.x-1.0.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 1 errors, 2 warnings. The useless-provides error is valid, see the provides list for the package: $ rpm -qp --provides drupal7-translation_helpers-1.0-1.fc20.noarch.rpm drupal7(translation_helpers) = 1.0 drupal7(translation_helpers) = 1.0 drupal7-translation_helpers = 1.0-1.fc20 Drop the Provides tag, and your package is ready for a full review and approval. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qKtvzLGlUsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959658] Review Request: drupal7-translation_helpers - Provides methods for other modules to use with translated content
https://bugzilla.redhat.com/show_bug.cgi?id=959658 --- Comment #2 from Mario Blättermann mario.blaetterm...@gmail.com --- BTW, the explicite drupal requirement seems to be also unneeded: $ rpm -qpR drupal7-translation_helpers-1.0-1.fc20.noarch.rpm drupal7 drupal7(core) rpmlib(CompressedFileNames) = 3.0.4-1 rpmlib(FileDigests) = 4.6.0-1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 rpmlib(PayloadIsXz) = 5.2-1 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BnHpDrEaQUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959658] Review Request: drupal7-translation_helpers - Provides methods for other modules to use with translated content
https://bugzilla.redhat.com/show_bug.cgi?id=959658 --- Comment #3 from Shawn Iwinski shawn.iwin...@gmail.com --- Ahhh... you seem to be the first one using drupal7[-rpmbuild] 7.22-5 :) Auto-provides were added with 7.22-4 and auto-requires (among other features) were added with 7.22-5. This package was submitted for review before either of those releases so that explains the duplicates. I am going to update all of my drupal7-* package requests to use the new format when drupal7 7.22-5 is released to stable. Until then, if you would like to review any of the other drupal7-* package reviews I have open, please ask me to update before you do your review. Updates diff: https://github.com/siwinski/rpms/commit/02e3ccce834fb34c55f21cb7e2fedfb55454f92b Spec URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/drupal7-translation_helpers.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/drupal7-translation_helpers-1.0-3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KbM3r9DdFRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959658] Review Request: drupal7-translation_helpers - Provides methods for other modules to use with translated content
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=959658 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Alias||d7-trans_helpers -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IzdDc9KO6ua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
