[Bug 959667] Review Request: drupal7-ds - Extend the display options for every entity type
https://bugzilla.redhat.com/show_bug.cgi?id=959667 --- Comment #5 from Shawn Iwinski shawn.iwin...@gmail.com --- (In reply to Mario Blättermann from comment #4) (In reply to Shawn Iwinski from comment #3) The ds_devel module is an optional sub-module that end-users don't need to use and usually do not ever enable/use in production. However, I definitely would like a drupal7-devel package in the repo so I will work on that. This could be of interest for Drupal module developers. For the time being we can leave it as is, and for future releases I propose this solution: Once the drupal7-devel package is available, we also should have a drupal7-ds-devel package. A dummy package without any files (or with the ds_devel module files) and with drupal7-devel as a runtime requirement. This way we let users know that the development part only works with drupal7-devel. Not all users read package descriptions carefully enough to not stumble upon a not explicitely defined runtime dependency ;) Drupal users are used to having to install separate pkgs (or modules in Drupal-land) to be able to enable sub-modules so I think a sub-pkg would confuse the general population. I will discuss with the Fedora Drupal community to come up with a solution and guidelines for future packages with this same issue. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=umUupKyyJ3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959667] Review Request: drupal7-ds - Extend the display options for every entity type
https://bugzilla.redhat.com/show_bug.cgi?id=959667 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Shawn Iwinski shawn.iwin...@gmail.com --- THANKS for the review! New Package SCM Request === Package Name: drupal7-ds Short Description: Extend the display options for every entity type Owners: siwinski asrob Branches: f17 f18 f19 el5 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZMs3Tm5913a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959667] Review Request: drupal7-ds - Extend the display options for every entity type
https://bugzilla.redhat.com/show_bug.cgi?id=959667 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jxcSGYko30a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959667] Review Request: drupal7-ds - Extend the display options for every entity type
https://bugzilla.redhat.com/show_bug.cgi?id=959667 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5j6qPABskna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959667] Review Request: drupal7-ds - Extend the display options for every entity type
https://bugzilla.redhat.com/show_bug.cgi?id=959667 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-07-05 13:32:29 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=K1OvLaQ29fa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959667] Review Request: drupal7-ds - Extend the display options for every entity type
https://bugzilla.redhat.com/show_bug.cgi?id=959667
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mario.blaetterm...@gmail.co
||m
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review?
--- Comment #2 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5569858
$ rpmlint -i -v *
drupal7-ds.src: I: checking
drupal7-ds.src: W: spelling-error %description -l en_US ui - ii, u, i
The value of this tag appears to be misspelled. Please double-check.
drupal7-ds.src: W: spelling-error %description -l en_US devel - delve, devil,
revel
The value of this tag appears to be misspelled. Please double-check.
drupal7-ds.src: I: checking-url http://drupal.org/project/ds (timeout 10
seconds)
drupal7-ds.src: I: checking-url
http://ftp.drupal.org/files/projects/ds-7.x-2.4.tar.gz (timeout 10 seconds)
drupal7-ds.noarch: I: checking
drupal7-ds.noarch: W: spelling-error %description -l en_US ui - ii, u, i
The value of this tag appears to be misspelled. Please double-check.
drupal7-ds.noarch: W: spelling-error %description -l en_US devel - delve,
devil, revel
The value of this tag appears to be misspelled. Please double-check.
drupal7-ds.noarch: I: checking-url http://drupal.org/project/ds (timeout 10
seconds)
drupal7-ds.spec: I: checking-url
http://ftp.drupal.org/files/projects/ds-7.x-2.4.tar.gz (timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Rpmlint is quite silent, besides some spelling errors. But I'm not really happy
with the behavior of the development part. Your description says:
This package provides the following Drupal modules:
...
* %{module_name}_devel (NOTE: Requires install of the devel module)
This means, if somebody really wants to use the *_devel module, he/she has to
install a development module...? As far as I can see, there's no drupal7-devel
package at all.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=cPAb1w0kvna=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959667] Review Request: drupal7-ds - Extend the display options for every entity type
https://bugzilla.redhat.com/show_bug.cgi?id=959667
--- Comment #3 from Shawn Iwinski shawn.iwin...@gmail.com ---
(In reply to Mario Blättermann from comment #2)
Rpmlint is quite silent, besides some spelling errors. But I'm not really
happy with the behavior of the development part. Your description says:
This package provides the following Drupal modules:
...
* %{module_name}_devel (NOTE: Requires install of the devel module)
This means, if somebody really wants to use the *_devel module, he/she has
to install a development module...? As far as I can see, there's no
drupal7-devel package at all.
The ds_devel module is an optional sub-module that end-users don't need to use
and usually do not ever enable/use in production. However, I definitely would
like a drupal7-devel package in the repo so I will work on that.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=8kxpJehXOya=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959667] Review Request: drupal7-ds - Extend the display options for every entity type
https://bugzilla.redhat.com/show_bug.cgi?id=959667
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Mario Blättermann mario.blaetterm...@gmail.com ---
(In reply to Shawn Iwinski from comment #3)
The ds_devel module is an optional sub-module that end-users don't need to
use and usually do not ever enable/use in production. However, I definitely
would like a drupal7-devel package in the repo so I will work on that.
This could be of interest for Drupal module developers. For the time being we
can leave it as is, and for future releases I propose this solution:
Once the drupal7-devel package is available, we also should have a
drupal7-ds-devel package. A dummy package without any files (or with the
ds_devel module files) and with drupal7-devel as a runtime requirement. This
way we let users know that the development part only works with drupal7-devel.
Not all users read package descriptions carefully enough to not stumble upon a
not explicitely defined runtime dependency ;)
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv2+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
40d692fbb1fdf47a2938e9b03603ac9fa958e88fdbb9287e167cfd112b865e2c
ds-7.x-2.4.tar.gz
40d692fbb1fdf47a2938e9b03603ac9fa958e88fdbb9287e167cfd112b865e2c
ds-7.x-2.4.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[+] MUST: If a package includes
[Bug 959667] Review Request: drupal7-ds - Extend the display options for every entity type
https://bugzilla.redhat.com/show_bug.cgi?id=959667 --- Comment #1 from Shawn Iwinski shawn.iwin...@gmail.com --- * Updated to 2.4 * Updated for drupal7-rpmbuild 7.22-5 SPEC URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/drupal7-ds.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/drupal7-ds-2.4-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8Tz9IVu5qia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959667] Review Request: drupal7-ds - Extend the display options for every entity type
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=959667 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Alias||drupal7-ds -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mzujtPVsqCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
