[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674 gil cattaneo changed: What|Removed |Added Blocks|976330 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=976330 [Bug 976330] gradle: new version 1.6 available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UH7tO3miRa&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||jatl-0.2.2-1.fc19 Resolution|--- |ERRATA Last Closed||2013-07-06 21:35:22 --- Comment #14 from Fedora Update System --- jatl-0.2.2-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=21R9V1CPOt&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System --- jatl-0.2.2-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xy9EGLMjkQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674 --- Comment #12 from Fedora Update System --- jatl-0.2.2-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/jatl-0.2.2-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T1THW1xC76&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tKkESQfozj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674 --- Comment #11 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W80fnMXvkV&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ra4HwNBx7n&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from gil cattaneo --- Thanks! Spec URL: http://gil.fedorapeople.org/jatl.spec SRPM URL: http://gil.fedorapeople.org/jatl-0.2.2-1.fc18.src.rpm - removed redundant BuildRequires - used XMvn New Package SCM Request === Package Name: jatl Short Description: Java Anti-Template Language Owners: gil Branches: f19 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6DaDogJVu3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674
--- Comment #9 from Michal Srb ---
(In reply to gil cattaneo from comment #8)
> I apologize if I'll still lose time...
> fix with %mvn_file :%{name} %{name} , is ok?
> thanks
Yep, this will do the trick for you. No symlinks, no %{_javadir}/%{name}/
directory, JAR will be in %{_javadir}/%{name}.jar
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=TAN1y8vztS&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674
--- Comment #8 from gil cattaneo ---
I apologize if I'll still lose time...
fix with %mvn_file :%{name} %{name} , is ok?
thanks
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ZCDhe0HiDB&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674 --- Comment #7 from Michal Srb --- (In reply to gil cattaneo from comment #4) > and again a thing, sorry, i dont understand what need > /usr/share/maven-effective-poms/JPP.jatl-jatl.pom ... just documentation ? > thanks This file is later used by XMvn. It's important file and even if you decide not to use %mvn_install from some reason, you should install it manually. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FhR3LHxu6R&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674
--- Comment #6 from gil cattaneo ---
can i do this?
mv %{buildroot}%{_javadir}/%{name}/%{name}.jar
%{buildroot}%{_javadir}/%{name}.jar
rm -r %{buildroot}%{_javadir}/%{name}
mkdir -p %{buildroot}%{_mavenpomdir}
mv %{buildroot}%{_mavenpomdir}/JPP.%{name}-%{name}.pom
%{buildroot}%{_mavenpomdir}/JPP-%{name}.pom
%add_maven_depmap JPP-%{name}.pom %{name}.jar
thanks
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=sB9xvNJB4W&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674
--- Comment #5 from Michal Srb ---
(In reply to gil cattaneo from comment #2)
> hi
> thanks for the review
> i dont want use %%mvn_install macro, install the library in
> /usr/share/java/jatl instead of /usr/share/java
> isnt very friendly with gradle ...
> regards
You can always create symlinks in /usr/share/java. All you need to do is add
following line to your %prep section:
%mvn_file :jatl jatl/jatl jatl
%mvn_install will then install JAR file for artifact "any_groupId:jatl" to the
location %{_javadir}/jatl/jatl.jar and it will also create symlink
%{_javadir}/jatl.jar
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=CxHViYLK7Q&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674 --- Comment #4 from gil cattaneo --- and again a thing, sorry, i dont understand what need /usr/share/maven-effective-poms/JPP.jatl-jatl.pom ... just documentation ? thanks -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ir8ILB9k48&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674 --- Comment #3 from gil cattaneo --- %pom_xpath_inject "pom:project/pom:build/pom:plugins/pom:plugin[pom:artifactId ='maven-compiler-plugin']" "any" remove this warning [WARNING] Some problems were encountered while building the effective model for com.googlecode.jatl:jatl:jar:0.2.2 [WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-compiler-plugin is missing. @ line 177, column 21 [WARNING] [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build. [WARNING] [WARNING] For this reason, future Maven versions might no longer support building such malformed projects. [WARNING] thanks -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=h3YnGe2A5Q&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674 --- Comment #2 from gil cattaneo --- hi thanks for the review i dont want use %%mvn_install macro, install the library in /usr/share/java/jatl instead of /usr/share/java isnt very friendly with gradle ... regards -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OI6M6dg478&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674
Michal Srb changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Michal Srb ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Large documentation must go in a -doc subpackage.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[-]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
[x]: Fully versioned dependency in subpackages, if present.
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build
Maven:
[x]: Pom files have correct Maven mapping
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve
[Bug 959674] Review Request: jatl - Java Anti-Template Language
https://bugzilla.redhat.com/show_bug.cgi?id=959674 gil cattaneo changed: What|Removed |Added Blocks||976330 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Rib6pqLKX4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=959674 Michal Srb changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@redhat.com Assignee|nob...@fedoraproject.org|m...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hoMayU8eO7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 959674] Review Request: jatl - Java Anti-Template Language
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=959674 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BN9tM8NlOn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
