[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 --- Comment #17 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 Christopher Meng changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #16 from Christopher Meng --- Package Change Request == Package Name: lfcxml New Branches: epel7 Owners: cicku -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 Fedora Update System changed: What|Removed |Added Fixed In Version|lfcxml-1.1.4-1.fc18 |lfcxml-1.1.4-1.el6 --- Comment #15 from Fedora Update System --- lfcxml-1.1.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SjFM4ApEr7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 Fedora Update System changed: What|Removed |Added Fixed In Version|lfcxml-1.1.4-1.fc19 |lfcxml-1.1.4-1.fc18 --- Comment #14 from Fedora Update System --- lfcxml-1.1.4-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t6HQYyVTcH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 Fedora Update System changed: What|Removed |Added Fixed In Version||lfcxml-1.1.4-1.fc19 Resolution|RAWHIDE |ERRATA --- Comment #13 from Fedora Update System --- lfcxml-1.1.4-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pxBmigEUqL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 --- Comment #12 from Fedora Update System --- lfcxml-1.1.4-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/lfcxml-1.1.4-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pd8x1K73P1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 --- Comment #11 from Fedora Update System --- lfcxml-1.1.4-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/lfcxml-1.1.4-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yKh9MIbQA0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 --- Comment #10 from Fedora Update System --- lfcxml-1.1.4-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/lfcxml-1.1.4-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yos0t9T9ht&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 Björn Esser changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-05-31 08:19:58 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4SxT7NmaI8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bxlP9jQDzt&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qgNrulh8mS&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 Christopher Meng changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AAR7EPrqC0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 --- Comment #8 from Christopher Meng --- New Package SCM Request === Package Name: lfcxml Short Description: Lemke Foundation Classes XML extension Owners: cicku Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2q0DKVcXJ8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 Christopher Meng changed: What|Removed |Added Depends On||959974 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AZ01ZOeRpW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 Christopher Meng changed: What|Removed |Added Depends On|959974 | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kQ35uIyDOE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041
Björn Esser changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #7 from Björn Esser ---
You're right. I missed that during review...
You should check and fix this in lfcbase.spec as well! I just looked in spec
again and saw it's the same problem with %{_includedir}/%{name}/* -->
%{_includedir}/%{name}/ there, too.
Never the less, this one is
APPROVED!
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=R1wlFumhFp&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 Bug 960041 depends on bug 959974, which changed state. Bug 959974 Summary: Review Request: lfcbase - Lemke Foundation Classes https://bugzilla.redhat.com/show_bug.cgi?id=959974 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qaiPinQHkn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041
--- Comment #6 from Christopher Meng ---
Exclude the licensing problem, all should be fixed at:
Spec URL: http://cicku.me/lfcxml.spec
SRPM URL: http://cicku.me/lfcxml-1.1.3-2.fc20.src.rpm
But one thing we should consider is the ownership of includedir, I just made
the mistake in another package(monitorix), and of course lfcbase I think.
Which is:
%{_includedir}/%{name}/*
should be replaced as:
%{_includedir}/%{name}/
Because if I don't remove the glob, the directory itself will not be owned by
RPM.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Dh6iQmMCl4&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 --- Comment #4 from Christopher Meng --- Revised version: Spec URL: http://cicku.me/lfcxml.spec SRPM URL: http://cicku.me/lfcxml-1.1.3-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uecoRJ6bGg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041
Björn Esser changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #5 from Björn Esser ---
Package Review
==
All fine so far, but:
BLOCKER:
* -devel must have Requires: lfcbase-devel%{?_isa}
headers do include headers from lfcbase
NON-BLOCKER, SUGGESTION:
* %files devel
+%doc samples/*.{cc,xml}
%{_includedir}/%{name}/*
%{_libdir}/*.so
WISHES, PROPOSALS:
* contact upstream and ask to update the copyright-headers in sources
to GPLv3+ and fix FSF-address; applies to lfcbase (and possibly
other LEMKE-IT stuff) as well.
Fix the BLOCKERS and you'll get fedora-review(+).
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[!]: Requires correct, justified where necessary.
---> -devel needs Requires: lfcbase-devel%{?_isa}
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 51200 bytes in 4 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
---> -devel Requires
[!]: Package functions as described.
---> -devel Requires
[x]: Latest version is packaged.
[x]: Package does not include license text files s
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
https://bugzilla.redhat.com/show_bug.cgi?id=960041 Björn Esser changed: What|Removed |Added CC||bjoern.es...@gmail.com Assignee|nob...@fedoraproject.org|bjoern.es...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fkN6ziDt9M&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960041] Review Request: lfcxml - Lemke Foundation Classes XML extension
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960041 Christopher Meng changed: What|Removed |Added Summary|Review Request: liblfc-xml |Review Request: lfcxml - |- Lemke Foundation Classes |Lemke Foundation Classes |XML extension |XML extension --- Comment #3 from Christopher Meng --- Renamed: Spec URL: http://cicku.me/lfcxml.spec SRPM URL: http://cicku.me/lfcxml-1.1.3-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=emyHtnDQVE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
