[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960199 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added CC|nott...@redhat.com, | |package-review@lists.fedora | |project.org | Flags|fedora-cvs+ |fedora-cvs? --- Comment #15 from Björn besser82 Esser bjoern.es...@gmail.com --- Package Change Request == Package Name: libyui-ncurses New Branches: el6 Owners: besser82 Want to build on el6, too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960199 --- Comment #16 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960199 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960199 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||libyui-ncurses-2.43.9-3.fc1 ||8 Resolution|RAWHIDE |ERRATA --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- libyui-ncurses-2.43.9-3.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Yd8xC5IIX2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960199 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|libyui-ncurses-2.43.9-3.fc1 |libyui-ncurses-2.43.9-3.fc1 |8 |9 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- libyui-ncurses-2.43.9-3.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Wih17qubIMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #9 from Björn Esser bjoern.es...@gmail.com --- Package Change Request == Package Name: libyui-ncurses New Branches: f18 Owners: besser82 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pQr4ARJnk6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kTJ6bWac7ka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9WWzmdAEFAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-05-16 08:50:25 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Hdg8QIrqRFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 Bug 960199 depends on bug 959926, which changed state. Bug 959926 Summary: Review Request: libyui - GUI-abstraction library https://bugzilla.redhat.com/show_bug.cgi?id=959926 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vhDtlQ6MmVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- libyui-ncurses-2.43.9-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libyui-ncurses-2.43.9-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=z1bEWLQSY8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- libyui-ncurses-2.43.9-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/libyui-ncurses-2.43.9-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8dNGZAC2LEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960199
--- Comment #3 from Michael Schwendt mschwe...@gmail.com ---
Only some minor things:
* Macro fun. ;-)
Not a blocker according to the guidelines, but I need to point out that I find
the growing number of %globals less readable. They will cause you some
headaches eventually. Of course, you're free to use so many macros, it's just
not really beneficial. Example:
%global uitype ncurses
%global uiname %{uitype}
BuildRequires: %{uitype}-devel
ncurses is unlikely to be renamed, so spelling out its name would be more
clear. In case you want the spec file be suitable for target distributions
other than Fedora, ncurses-devel might even be named ncurses-dev instead, and
then you would need to change the macros here already.
$ grep uiname *.spec
%global uiname %{uitype}
An unused macro, it seems, and it's just a redefinition of %uitype anyway.
Using many custom macros in Provides and Requires can lead to trouble easily.
Touching the macro definition in a single place may make the built package
provide or require wrong things. Such an error (or typing mistake) would not be
obvious when viewing the automatically sent git commit diff mail. It could be
something ugly such as an unexpanded macro name. And yes, it's a pitfall other
packagers have run into before.
%description devel
s/sufficent/sufficient/
rpmlint also finds that when you run it on the binary rpms.
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
Not needed.
This package doesn't store any shared libs in run-timer linker's search path.
The plugins are stored in private path %_libdir/yui/ and are dlopen()'ed at
run-time via their full path (and including the major library version,
currently .so.5).
%files
%dir %{_libdir}/%{libsuffix}
This directory is included in package %parname (libyui) already.
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_also_owned_by_a_package_implementing_required_functionality_of_your_package
%files devel
%dir %{_libdir}/%{libsuffix}
%{_includedir}/%{libsuffix}
%{_datadir}/%{parname}
These dirs are also provided by libyui already. Modern RPM can handle that also
upon removing the packages.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=NigxAmwSZba=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960199
Björn Esser bjoern.es...@gmail.com changed:
What|Removed |Added
Status|ASSIGNED|NEW
--- Comment #4 from Björn Esser bjoern.es...@gmail.com ---
Spec URL:
http://besser82.fedorapeople.org/pkg/libyui-ncurses/libyui-ncurses.spec
SRPM URL:
http://besser82.fedorapeople.org/pkg/libyui-ncurses/libyui-ncurses-2.43.8-2.fc18.src.rpm
Updated the pkg according your advice. Thanks for reviewing.
%changelog
* Wed May 15 2013 Björn Esser bjoern.es...@gmail.com - 2.43.8-2
- fixup as suggested in https://bugzilla.redhat.com/show_bug.cgi?id=960199#c3
- exchanged {parname} with {libname}
* Mon May 13 2013 Björn Esser bjoern.es...@gmail.com - 2.43.8-1
- Initial RPM release.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=JUePd894lSa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960199
--- Comment #5 from Björn Esser bjoern.es...@gmail.com ---
Spec URL:
http://besser82.fedorapeople.org/pkg/libyui-ncurses/libyui-ncurses.spec
SRPM URL:
http://besser82.fedorapeople.org/pkg/libyui-ncurses/libyui-ncurses-2.43.9-1.fc18.src.rpm
New upstream version. Thanks for your review.
%changelog
* Wed May 15 2013 Björn Esser bjoern.es...@gmail.com - 2.43.9-1
- new upstream version
- adjusted %{libname}-devel min-version
- added needed bootstrap to prep
* Wed May 15 2013 Björn Esser bjoern.es...@gmail.com - 2.43.8-2
- fixup as suggested in https://bugzilla.redhat.com/show_bug.cgi?id=960199#c3
- exchanged {parname} with {libname}
* Mon May 13 2013 Björn Esser bjoern.es...@gmail.com - 2.43.8-1
- Initial RPM release.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=EbQkZqC1g5a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c6LjoMXFN9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=960199
Michael Schwendt mschwe...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #6 from Michael Schwendt mschwe...@gmail.com ---
%package devel
Requires: ncurses
ncurses-devel%{?_isa} of course. Guess I managed to confuse you with the
suggestion to get rid of some macros. Ha! :)
Beyond that, save yourself another update in this bugzilla review request,
since it'll be more convenient to fix it in Fedora pkg git:
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=wbGyPlsmfIa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HvrrpRe25ja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Flags|fedora-review+ | Flags||fedora-review? Flags||fedora-cvs? --- Comment #7 from Björn Esser bjoern.es...@gmail.com --- New Package SCM Request === Package Name: libyui-ncurses Short Description: Character Based User Interface for libyui Owners: besser82 Branches: f19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WVTcnssSida=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3k8pPkB5Aaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3hs5MgVVcua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=insCF0F2waa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mschwe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BDHpBdAujVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|MODIFIED|NEW CC||mschwe...@gmail.com --- Comment #2 from Björn Esser bjoern.es...@gmail.com --- Spec URL: http://besser82.fedorapeople.org/pkg/libyui-ncurses/libyui-ncurses.spec SRPM URL: http://besser82.fedorapeople.org/pkg/libyui-ncurses/libyui-ncurses-2.43.8-1.fc18.src.rpm Adapted Spec/SRPM urls for tracking inside fedora-review tool. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=etSYXRrtE8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|NEW |MODIFIED --- Comment #1 from Björn Esser bjoern.es...@gmail.com --- Updated to V2.43.8 You can find SPEC/SRPM here: http://besser82.fedorapeople.org/pkg/libyui-ncurses/ Or clone my git-repo from besse...@fedorapeople.org:public_git/libyui.git and checkout the libyui-ncurses branch. BR, Björn Esser -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BOlBpSfGQda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Depends On||959926 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fyWH5LXcHpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960199] Review Request: libyui-ncurses - Character Based User Interface for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960199 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sDatiMNYkGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
