[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #14 from Björn "besser82" Esser --- Finally there has been a new upstream release, which fixes that cgraph-issues. :D Koji Builds: Frh: https://koji.fedoraproject.org/koji/taskinfo?taskID=6883692 Urls: Spec URL: http://besser82.fedorapeople.org/review/libyui-qt-graph.spec SRPM URL: http://besser82.fedorapeople.org/review/libyui-qt-graph-2.44.1-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 Björn "besser82" Esser changed: What|Removed |Added Attachment #749630|0 |1 is obsolete|| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #15 from Björn "besser82" Esser --- After updating (and tagging needed buildroot-overrides) the libYUI-stack on el7, fc19 and fc20 scratch-builds are successful there, too. Do you still want to do the review, Michael? Or may I reassign this to someone else? Koji Builds: el7: http://koji.fedoraproject.org/koji/taskinfo?taskID=6885730 F19: http://koji.fedoraproject.org/koji/taskinfo?taskID=6885736 F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6885739 Frh: http://koji.fedoraproject.org/koji/taskinfo?taskID=6885743 Urls: Spec URL: http://besser82.fedorapeople.org/review/libyui-qt-graph.spec SRPM URL: http://besser82.fedorapeople.org/review/libyui-qt-graph-2.44.1-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #16 from Michael Schwendt --- > Or may I reassign this to someone else? ;) I don't claim ownership of this review. But note that there are issues with the package: > License: LGPLv2 or LGPLv3 First of all, the source files include a "GPLv2" preamble, modified with links to Novell and novell.com instead of gnu.org. That's a case of: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Clarification Secondly, with regard to the LGPLv3, the GPLv3 license text should be included as well: https://www.gnu.org/licenses/gpl-faq.html#v3HowToUpgrade * rpmlint complains about the -doc package with an 'E': libyui-qt-graph-doc.noarch: E: version-control-internal-file /usr/share/doc/libyui-qt-graph-doc/examples/.gitignore * The -devel package pkgconfig file specifies "Libs: -lyui-qt-graph", but that lib is located outside default search path in the plugin dir %_libdir/yui/. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #17 from Björn "besser82" Esser --- (In reply to Michael Schwendt from comment #16) > > Or may I reassign this to someone else? > > ;) I don't claim ownership of this review. Allrighty! ;) > But note that there are issues with the package: > > > License:LGPLv2 or LGPLv3 > > First of all, the source files include a "GPLv2" preamble, modified with > links to Novell and novell.com instead of gnu.org. That's a case of: > > https://fedoraproject.org/wiki/Packaging: > LicensingGuidelines#License_Clarification Already in progress: https://github.com/libyui/libyui-qt-graph/pull/15 I *could* merge myself, but I'll let that open for discussion with the SUSE-folks… 8) > Secondly, with regard to the LGPLv3, the GPLv3 license text should be > included as well: > > https://www.gnu.org/licenses/gpl-faq.html#v3HowToUpgrade As above. ^^ > * rpmlint complains about the -doc package with an 'E': > > libyui-qt-graph-doc.noarch: E: version-control-internal-file > /usr/share/doc/libyui-qt-graph-doc/examples/.gitignore Fixed, see below. > * The -devel package pkgconfig file specifies "Libs: -lyui-qt-graph", but > that lib is located outside default search path in the plugin dir > %_libdir/yui/. Which really ain't an issue here, but will need fixing in libyui-pkg itself, because the other UI-plugins are affected by this as well. Hm… Who did the review on them? :-P By e.g. adding /etc/ldconf.so.conf.d/libyui-%{%_arch}.conf to the libyui-pkg (already done: https://koji.fedoraproject.org/koji/buildinfo?buildID=519016). SO-dependencies will make sure this one is pulled in any case. # %changelog * Sat May 24 2014 Björn Esser - 2.44.1-2 - fix rpmlint 'E: version-control-internal-file' Koji Builds: el7: http://koji.fedoraproject.org/koji/taskinfo?taskID=6887224 F19: http://koji.fedoraproject.org/koji/taskinfo?taskID=6887227 F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6887230 Frh: http://koji.fedoraproject.org/koji/taskinfo?taskID=6887234 Urls: Spec URL: http://besser82.fedorapeople.org/review/libyui-qt-graph.spec SRPM URL: http://besser82.fedorapeople.org/review/libyui-qt-graph-2.44.1-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #18 from Michael Schwendt --- > By e.g. adding /etc/ldconf.so.conf.d/libyui-%{%_arch}.conf to the libyui-pkg That's making available private _plugin_ libs (as dlopen'ed by libyui) in runtime linker's search path. I don't understand what that's supposed to fix. Why store the plugins in a private subdir first of all? > because the other UI-plugins are affected by this as well. Hm… Who did > the review on them? :-P Haha, -devel packages for an API that may be used to extend _plugin_ libs scare me and cause quite a headache, too (guess why I've lobbied for the longer -devel packaging guidelines related to placement of .so files) . How much to examine beyond a plausibility-check (based on what %description claims)? Reviewing such packages would be easier, if there were an API-user that would extend a plugin and could be tested with. It wouldn't be the first time such headers won't be used. And there have been enough cases where the headers were private and were installed accidentally (e.g. suspicious header-only -devel packages for plugin libs). If you are concerned about the automatic SONAME deps of the individual plugin libs, while one common option would be to filter them out, this would get really funny with the introduction of an extension plugin lib depending on a plugin lib. This is non-trivial stuff. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #19 from Michael Schwendt --- > %config %{_sysconfdir}/ldconf.so.conf.d/%{name}-%{_arch}.conf Returned from voting with a question in my head: # repoquery --whatprovides /etc/ldconf.so.conf.d # Did you want /etc/ld.so.conf.d/ instead? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 Michael Schwendt changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mschwe...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HJ8hq62Zb9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 Björn Esser changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #3 from Björn Esser --- Spec URL: http://besser82.fedorapeople.org/pkg/libyui-qt-graph/libyui-qt-graph.spec SRPM URL: http://besser82.fedorapeople.org/pkg/libyui-qt-graph/libyui-qt-graph-2.42.5-1.fc18.src.rpm New upstream version. Thanks for your review. %changelog * Wed May 15 2013 Björn Esser - 2.42.5-1 - new upstream version - adjusted %{libname}-devel min-version - added needed bootstrap to prep * Mon May 13 2013 Björn Esser - 2.42.4-1 - Initial RPM release. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gw97OXESnL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 Björn Esser changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dG0TQzZfHF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 Michael Schwendt changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Riqb9u4k5Y&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 Bug 960201 depends on bug 959926, which changed state. Bug 959926 Summary: Review Request: libyui - GUI-abstraction library https://bugzilla.redhat.com/show_bug.cgi?id=959926 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ou49Iq1ocJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #4 from Michael Schwendt --- It won't build for F19 and newer, because libgraph is no more: http://koji.fedoraproject.org/koji/packageinfo?packageID=1971 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZLWiyWf7T8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #5 from Björn Esser --- Spec URL: http://besser82.fedorapeople.org/pkg/libyui-qt-graph/libyui-qt-graph.spec SRPM URL: http://besser82.fedorapeople.org/pkg/libyui-qt-graph/libyui-qt-graph-2.42.5-2.fc18.src.rpm Try again, please. If it will fail again, can you please provide a build.log? %changelog * Sat May 18 2013 Björn Esser - 2.42.5-2 - add Patch0 to (hopefully) re-enable build on Fedora >= 19 - removed {min_devel_ver} since versions in Fedora are mature enough * Wed May 15 2013 Björn Esser - 2.42.5-1 - new upstream version - adjusted libyui-devel min-version - added needed bootstrap to prep * Mon May 13 2013 Björn Esser - 2.42.4-1 - Initial RPM release. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yQ2uSnWkNm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #6 from Michael Schwendt --- Created attachment 749630 --> https://bugzilla.redhat.com/attachment.cgi?id=749630&action=edit build failure output -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=92rKL4mcPM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #7 from Björn Esser --- Seems a bug in doxygen(-devel) to me: In file included from /usr/include/graphviz/gvc.h:17:0, --> includes ---+ from /.../libyui-qt-graph-.../src/QY2Graph.h:31,| from /.../libyui-qt-graph-.../src/QY2Graph.cc:34: | /usr/include/graphviz/types.h:49:20 <-- this file --+ | fatal error: cgraph.h: No such file or directory <-- includes --+ Which version of doxygen-devel does mock use during %build ? So I can file a bug against the corresponding doxygen-ver, if applicable. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GWqsPeriPc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #8 from Björn Esser --- Build fails on rawhide using graphviz{,-devel}-2.30.1-7.fc20, too. Same reason: complains about missing cgraph.h, although it's available in grahpviz-devel: http://koji.fedoraproject.org/koji/fileinfo?rpmID=4005344&filename=/usr/include/graphviz/cgraph.h Shall I file a bug against graphviz >= 2.30.0 <= 2.30.1-7, then? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6ipmJOX78P&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #9 from Michael Schwendt --- It's a bug in libyui-qt-graph not setting the libcgraph headers search path during compilation. | /usr/include/graphviz/types.h:49:20: fatal error: cgraph.h: | No such file or directory | #include $ pkg-config --cflags libcgraph -I/usr/include/graphviz -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=g9Scbxl0pZ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #10 from Björn Esser --- same as on F18... (-I/usr/include/graphviz isn't set here explicitly, either) #ifndef QY2Graph_h #define QY2Graph_h #include include is correct... #ifndef GVC_H #define GVC_H #include "types.h" // include "..." should eval to same dir as file including #ifndef GV_TYPES_H #define GV_TYPES_H #include #include #include ... #ifdef WITH_CGRAPH #include // here it's wrong ! --> "cgraph.h" ... #else ... #endif Or do you think differently? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iuNQAjGIhe&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #11 from Björn Esser --- if I explicitly include /usr/include/graphviz, this happens and build fails on rawhide (again): In file included from /usr/include/graphviz/types.h:49:0, from /usr/include/graphviz/gvc.h:17, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/QY2Graph.h:31, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraph.h:33, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraphPlugin.h:32, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraphPlugin.cc:28: /usr/include/graphviz/cgraph.h:43:25: error: conflicting declaration 'typedef struct Agraph_s Agraph_t' typedef struct Agraph_s Agraph_t; /* graph, subgraph (or hyperedge) */ ^ In file included from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraph.h:31:0, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraphPlugin.h:32, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraphPlugin.cc:28: /usr/include/yui/YGraph.h:32:12: error: 'struct Agraph_t' has a previous declaration as 'struct Agraph_t' struct Agraph_t; ^ In file included from /usr/include/graphviz/gvc.h:17:0, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/QY2Graph.h:31, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraph.h:33, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraphPlugin.h:32, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraphPlugin.cc:28: /usr/include/graphviz/types.h:50:29: error: conflicting declaration 'typedef struct Agraph_s graph_t' typedef struct Agraph_s graph_t; ^ In file included from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraph.h:31:0, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraphPlugin.h:32, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraphPlugin.cc:28: /usr/include/yui/YGraph.h:33:29: error: 'graph_t' has a previous declaration as 'typedef struct Agraph_t graph_t' typedef struct Agraph_t graph_t; ^ make[2]: *** [src/CMakeFiles/yui-qt-graph.dir/YQGraphPlugin.cc.o] Error 1 In file included from /usr/include/graphviz/types.h:49:0, from /usr/include/graphviz/gvc.h:17, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/QY2Graph.h:31, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraph.h:33, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraphPluginImpl.cc:29: /usr/include/graphviz/cgraph.h:43:25: error: conflicting declaration 'typedef struct Agraph_s Agraph_t' typedef struct Agraph_s Agraph_t; /* graph, subgraph (or hyperedge) */ ^ In file included from /usr/include/yui/qt/YQGraphPluginIf.h:28:0, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraphPluginImpl.h:31, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraphPluginImpl.cc:28: /usr/include/yui/YGraph.h:32:12: error: 'struct Agraph_t' has a previous declaration as 'struct Agraph_t' struct Agraph_t; ^ In file included from /usr/include/graphviz/gvc.h:17:0, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/QY2Graph.h:31, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraph.h:33, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraphPluginImpl.cc:29: /usr/include/graphviz/types.h:50:29: error: conflicting declaration 'typedef struct Agraph_s graph_t' typedef struct Agraph_s graph_t; ^ In file included from /usr/include/yui/qt/YQGraphPluginIf.h:28:0, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraphPluginImpl.h:31, from /builddir/build/BUILD/libyui-qt-graph-44b67c791be951daeec046240e6b74106f3573f1/src/YQGraphPluginImpl.cc:28: /usr/include/yui/YGraph.h:33:29: error: 'graph_t' has a pre
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #12 from Michael Schwendt --- > #include > > include is correct... Hard to say. The graphviz pkgconfig files disagree. They add the headers search path /usr/include/graphviz, which means API users are supposed to #include without the leading "graphviz/". The graphviz headers could also be installed in /usr/include/graphviz-2.30.1/graphviz (think multiple parallel-installed APIs of graphviz), and pkg-config --cflags would add that as a direct search path and not /usr/include/graphviz-2.30.1 instead. None of the graphviz header files append "graphviz/", $ grep /usr/include/graphviz/*|grep graphv $ but most of them include as "foo.h" not , so current dir works anyway. That including works is clear when "graphviz" is located in standard search path. There are a couple of builds that use libcgraph successfully (perhaps some of them use pkg-config though): # repoquery --whatrequires 'libcgraph.so.6()(64bit)'|grep -v graphviz fawkes-guis-0:0.5.0-7.fc19.x86_64 flowcanvas-0:0.7.1-10.fc19.x86_64 libgda-tools-1:5.1.2-2.fc19.x86_64 root-graf-gviz-0:5.34.07-1.fc19.x86_64 graphviz-doc cgraph.3.pdf (PDF version of "man 3 cgraph") and several of the other lib manuals contain an example that does include whereas "man 3 cdt" e.g. does include . Contradictory. Huh? $ grep cgraph /usr/include/graphviz/types.h #include #include "cgraph.h" $ grep cgraph /usr/include/graphviz/gvpr.h #include "cgraph.h" > /usr/include/graphviz/cgraph.h:43:25: > error: conflicting declaration 'typedef struct Agraph_s Agraph_t' Yes, these are clearly defined in graphviz/types.h already, so porting from libgraph to libcgraph API may need adjustments in libyui-qt-graph. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EUqBBzcxpt&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #13 from Björn Esser --- Review can be delayed here. Might get superseeded by upstream in near future. See PM. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uOeLp6Stu6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 Bug 960201 depends on bug 960200, which changed state. Bug 960200 Summary: Review Request: libyui-qt - Qt User Interface for libyui https://bugzilla.redhat.com/show_bug.cgi?id=960200 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xzIcQapThj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 Björn Esser changed: What|Removed |Added Depends On||959926 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vtgbfhyQOy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 Björn Esser changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=P5BhtFS85Q&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 Björn Esser changed: What|Removed |Added Depends On||960200 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6AO33woGC5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 Björn Esser changed: What|Removed |Added Status|NEW |MODIFIED --- Comment #1 from Björn Esser --- Updated to V2.42.4 You can find SPEC/SRPM here: http://besser82.fedorapeople.org/pkg/libyui-qt-graph/ Or clone my git-repo from besse...@fedorapeople.org:public_git/libyui.git and checkout the libyui-qt-graph branch. BR, Björn Esser -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SaIB2Z9FCG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=960201 Björn Esser changed: What|Removed |Added Status|MODIFIED|NEW CC||mschwe...@gmail.com --- Comment #2 from Björn Esser --- Spec URL: http://besser82.fedorapeople.org/pkg/libyui-qt-graph/libyui-qt-graph.spec SRPM URL: http://besser82.fedorapeople.org/pkg/libyui-qt-graph/libyui-qt-graph-2.42.4-1.fc18.src.rpm Adapted Spec/SRPM urls for tracking inside "fedora-review" tool. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YA4FddmjSK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #23 from Michael Schwendt --- Just a headsup while I'm taking a peek at some aging review requests. This currently fails to build on F26 x86_64. [...] -- Configuring done CMake Error at /usr/share/libyui/buildtools/LibyuiCommon.cmake:649 (ADD_LIBRARY): Target "yui-qt-graph" links to target "Qt5::Svg" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? Call Stack (most recent call first): src/CMakeLists.txt:8 (PROCESS_SOURCES) CMake Error at /usr/share/libyui/buildtools/LibyuiCommon.cmake:649 (ADD_LIBRARY): Target "yui-qt-graph" links to target "Qt5::X11Extras" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? Call Stack (most recent call first): src/CMakeLists.txt:8 (PROCESS_SOURCES) CMake Error at /usr/share/libyui/buildtools/LibyuiCommon.cmake:649 (ADD_LIBRARY): Target "yui-qt-graph" links to target "Qt5::Svg" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? Call Stack (most recent call first): src/CMakeLists.txt:8 (PROCESS_SOURCES) CMake Error at /usr/share/libyui/buildtools/LibyuiCommon.cmake:649 (ADD_LIBRARY): Target "yui-qt-graph" links to target "Qt5::X11Extras" but the target was not found. Perhaps a find_package() call is missing for an IMPORTED target, or an ALIAS target is missing? Call Stack (most recent call first): src/CMakeLists.txt:8 (PROCESS_SOURCES) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #24 from Björn "besser82" Esser --- (In reply to Michael Schwendt from comment #23) > Just a headsup while I'm taking a peek at some aging review requests. This > currently fails to build on F26 x86_64. Updated package: Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21206810 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/libyui-qt-graph.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/libyui-qt-graph-2.44.6-0.1.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 Wolfgang Ulbrich changed: What|Removed |Added CC||fed...@raveit.de Assignee|nob...@fedoraproject.org|fed...@raveit.de Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 Wolfgang Ulbrich changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #25 from Wolfgang Ulbrich --- APPROVED! Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libyui- qt-graph-doc , libyui-qt-graph-debuginfo [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summar
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #26 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libyui-qt-graph -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #27 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libyui-qt-graph -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #28 from Fedora Update System --- libyui-qt-graph-2.44.6-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-845fd591a3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #29 from Fedora Update System --- libyui-qt-graph-2.44.6-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1d1c2a6b67 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #30 from Fedora Update System --- libyui-qt-graph-2.44.6-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-845fd591a3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2017-08-24 11:51:20 --- Comment #31 from Fedora Update System --- libyui-qt-graph-2.44.6-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #32 from Fedora Update System --- libyui-qt-graph-2.44.6-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 Björn "besser82" Esser changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|bugs.mich...@gmx.net|nob...@fedoraproject.org Flags|fedora-review? | --- Comment #20 from Björn "besser82" Esser --- Updated package: Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19014100 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/libyui-qt-graph.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/libyui-qt-graph-2.44.5-0.1.fc27.src.rpm *** There hasn't been progress for about 3 years; resetting this review to 'NEW'. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #21 from Björn "besser82" Esser --- Updated package: Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19023094 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/libyui-qt-graph.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/libyui-qt-graph-2.44.5-0.2.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 960201] Review Request: libyui-qt-graph - Qt Graph Widget for libyui
https://bugzilla.redhat.com/show_bug.cgi?id=960201 --- Comment #22 from Björn "besser82" Esser --- Updated package: Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19153529 Urls: Spec URL: https://pagure.io/besser82/package-review/raw/master/f/libyui-qt-graph.spec SRPM URL: https://pagure.io/besser82/package-review/raw/master/f/libyui-qt-graph-2.44.5-0.3.fc27.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org