[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 Alejandro Alvarez alejandro.alvarez.ayl...@cern.ch changed: What|Removed |Added Status|ASSIGNED|VERIFIED --- Comment #16 from Alejandro Alvarez alejandro.alvarez.ayl...@cern.ch --- Great, thanks! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hNRMi59CJTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 Alejandro Alvarez alejandro.alvarez.ayl...@cern.ch changed: What|Removed |Added Status|VERIFIED|CLOSED Resolution|--- |NOTABUG Last Closed||2013-06-18 03:22:06 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wtwpqoE4gsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Resolution|NOTABUG |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CPZNbhKwE0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 --- Comment #14 from Michael Schwendt mschwe...@gmail.com --- Alejandro, you can Take ownership in pkgdb now thanks to Kevin Fenzi. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EB9IICYghca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 --- Comment #15 from Jon Ciesla limburg...@gmail.com --- Alejandro, you now own the devel branch. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ip9OgOrFbNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #3 from Michael Schwendt mschwe...@gmail.com --- * The changes are fine, except that I just had a final look at the new -doc package and noticed it contains only 15 manual pages with a total package size of 12092. As such I think it's not justified to create a separate -doc package. I recommend that you include the manual pages in the -devel package where they belong (manuals section 3). No Obsoletes are needed, since the -doc package hasn't existed before. The old packages included the man pages in the base package (wrongly): http://koji.fedoraproject.org/koji/packageinfo?packageID=8400 https://fedoraproject.org/wiki/Packaging:ReviewGuidelines | | MUST: Large documentation files must go in a -doc subpackage. | (The definition of large is left up to the packager's best judgement, | but is not restricted to size. Large can refer to either size or quantity). The %changelog doesn't tell _why_ you've moved the man pages into a subpackage. In case a future version will include large documentation, it would still be possible to introduce a -doc package. * EPEL5: %defattr is not needed there either, because RPM is new enough. * You're free to handle the doc changes within pkg git. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AJwegiwXLea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 --- Comment #4 from Michael Schwendt mschwe...@gmail.com --- Btw, yum search cunit is successful meanwhile, and the configure script searches for it. Consider looking into it, too. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mMiaSSc4eWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 --- Comment #5 from Michael Schwendt mschwe...@gmail.com --- BuildRequires: CUnit-devel %check make check -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PJHmYLH1PXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 --- Comment #6 from Michael Schwendt mschwe...@gmail.com --- CUnit - A unit testing framework for C - Version 2.1-2 http://cunit.sourceforge.net/ Suite: libmetalink_TestSuite Test: test of metalink_list ...passed Test: test of metalink_pctrl_file_transaction ...passed Test: test of metalink_pctrl_resource_transaction ...passed Test: test of metalink_pctrl_checksum_transaction ...passed Test: test of metalink_pctrl_piece_hash_transaction ...passed Test: test of metalink_pctrl_chunk_checksum_transaction ...passed Test: test of metalink_parse_file ...passed Test: test of metalink_parse_fp ...passed Test: test of metalink_parse_fd ...passed Test: test of metalink_parse_memory ...passed Test: test of metalink_parse_update ...passed Test: test of metalink_parser_update_fail ...passed Test: test of metalink_check_safe_path ...passed Test: test of metalink_get_version ...passed Test: test of metalink_parse_file_v4 ...passed Run Summary:Type TotalRan Passed Failed Inactive suites 1 1n/a 00 tests 15 15 15 00 asserts489489489 0 n/a Elapsed time =0.000 seconds PASS: metalinktest = 1 test passed = -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RO33iLWgDZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 Alejandro Alvarez alejandro.alvarez.ayl...@cern.ch changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Alejandro Alvarez alejandro.alvarez.ayl...@cern.ch --- I will have a look at those, thanks! Package Change Request == Package Name: libmetalink New Branches: f17 f18 f19 el5 el6 Owners: aalvarez -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wBxvVKvw9Da=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UbGOzIeIGfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RjfAt8gq1wa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 Alejandro Alvarez alejandro.alvarez.ayl...@cern.ch changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #9 from Alejandro Alvarez alejandro.alvarez.ayl...@cern.ch --- Sorry. I assumed master would be adopted too, but it hasn't been. Package Change Request == Package Name: libmetalink New Branches: master Owners: aalvarez -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UNjLvIybY4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 --- Comment #10 from Michael Schwendt mschwe...@gmail.com --- I think you need to file an unblock request at Fedora Release Engineering and point at this re-review: https://fedorahosted.org/rel-eng/ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XqfpCxBoEGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 --- Comment #11 from Alejandro Alvarez alejandro.alvarez.ayl...@cern.ch --- I have done that too, but I was surprised I can push to all branches except master. Well, and in the database devel is the only one still marked as orphan and deprecated. https://admin.fedoraproject.org/pkgdb/acls/name/libmetalink For the record: https://fedorahosted.org/rel-eng/ticket/5635 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ExaAe5kE2ma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- You need to take ownership of it in pkgdb. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OtRtJIm1CRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lQaf0ptjaga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 --- Comment #13 from Michael Schwendt mschwe...@gmail.com --- In pkgdb mortals cannot take ownership of deprecated packages. An admin needs to assist. $ koji list-pkgs --package libmetalink --show-blocked Package Tag Extra Arches Owner --- --- --- libmetalink dist-f9 ant libmetalink dist-5E-epel aalvarez libmetalink f12-alphaant libmetalink f9-cutoffant libmetalink f9-build-cutoff ant libmetalink f12-beta ant libmetalink f12-finalant libmetalink dist-6E-epel aalvarez libmetalink dist-f15 orphan libmetalink f16 orphan libmetalink f17 aalvarez [BLOCKED] libmetalink f17-finalorphan [BLOCKED] libmetalink f18-Alphaorphan [BLOCKED] libmetalink dist-f15-eol orphan libmetalink f18-finalorphan [BLOCKED] -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HByP6JRaXEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834 --- Comment #2 from Alejandro Alvarez alejandro.alvarez.ayl...@cern.ch --- Here is the new version. By the way, I do want to release in EPEL5. I attach this time a build in el5-candidate. Spec URL: https://aalvarez.web.cern.ch/aalvarez/fedora/libmetalink.spec SRPM URL: https://aalvarez.web.cern.ch/aalvarez/fedora/libmetalink-0.1.2-2.fc18.src.rpm rpmlint output -- $rpmlint ./libmetalink-0.1.2-2.fc18.src.rpm libmetalink.src: W: spelling-error Summary(en_US) Metalink - Meta link, Meta-link, Metal ink 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ./libmetalink-0.1.2-2.fc18.x86_64.rpm libmetalink.x86_64: W: spelling-error Summary(en_US) Metalink - Meta link, Meta-link, Metal ink Build on F20 http://koji.fedoraproject.org/koji/taskinfo?taskID=5486463 Build on EPEL6 -- http://koji.fedoraproject.org/koji/taskinfo?taskID=5486469 Build on EPEL5 -- http://koji.fedoraproject.org/koji/taskinfo?taskID=5486487 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=A70Idy6TkGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 962834] Review Request: libmetalink - a Metalink C library
https://bugzilla.redhat.com/show_bug.cgi?id=962834
Michael Schwendt mschwe...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|mschwe...@gmail.com
Flags||fedora-review?
--- Comment #1 from Michael Schwendt mschwe...@gmail.com ---
rpmlint output
Fix the issues found by rpmlint, please. Also run rpmlint on the _built_ rpms,
not just the src.rpm.
Summary:A Metalink C library
In Anaconda and package tools, which display these summaries, it looks better
(and more concise) when omitting these leading articles:
Summary: Metalink library written in C
https://fedoraproject.org/wiki/Examples_of_good_package_summaries
BuildRoot: ...
%install
rm -rf $RPM_BUILD_ROOT
%clean
rm -rf $RPM_BUILD_ROOT
%defattr(-,root,root,-)
Nowdays these are not necessary anymore. Unless you want to build with the same
spec file for EL5. Therefore it's better to remove what's not needed anymore
and add a comment what shall be kept:
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
%package devel
Summary: A Metalink C library devel package
More clear (as in many -devel packages):
Summary: Files needed for developing with %{name}
Requires: %{name} = %{version}-%{release}
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
Requires: pkgconfig
Not needed. Automatically added for the executable _and_ the .pc file's
Provides.
%package docs
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
Probably not worthwhile, but you could see whether to replace this -docs
package with a -doc package (dead.package file says: retired on 2012-02-06).
Group: Development/Libraries
Rather Group: Documentation.
Requires: %{name} = %{version}-%{release}
Independent documentation -doc packages typically don't require the base
package. It should be possible to install documentation without having to
install a program and all its dependencies.
%files devel
%{_includedir}/metalink/
%{_includedir}/metalink/metalink*.h
Duplicate file entries. The first includes the directory *and* everything in
it. The second includes the header files once more. Choose either one:
%{_includedir}/metalink/
Or:
%dir %{_includedir}/metalink/
%{_includedir}/metalink/metalink*.h
As a packaging hint: It can be helpful to spell out the specific file names of
header files, so if one file gets renamed during a version upgrade, the build
would fail and serve as an early-warning-system.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=PBU5jeEZW5a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
