[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection
https://bugzilla.redhat.com/show_bug.cgi?id=964143 Pádraig Brady p...@draigbrady.com changed: What|Removed |Added CC||p...@draigbrady.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #11 from Pádraig Brady p...@draigbrady.com --- Package Change Request == Package Name: python-fixtures New Branches: epel7 Owners: mrunge pbrady apevec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection
https://bugzilla.redhat.com/show_bug.cgi?id=964143 --- Comment #12 from Pádraig Brady p...@draigbrady.com --- Package Change Request == Package Name: python-testscenarios New Branches: epel7 Owners: mrunge pbrady apevec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection
https://bugzilla.redhat.com/show_bug.cgi?id=964143 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection
https://bugzilla.redhat.com/show_bug.cgi?id=964143 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection
https://bugzilla.redhat.com/show_bug.cgi?id=964143 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-testscenarios-0.4-2. |python-testscenarios-0.4-2. |fc19|el6 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-testscenarios-0.4-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bJRarva0esa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection
https://bugzilla.redhat.com/show_bug.cgi?id=964143 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-testscenarios-0.4-2. ||fc19 Resolution|--- |ERRATA Last Closed||2013-06-13 02:37:22 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- python-testscenarios-0.4-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oW8bQxXa5Qa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection
https://bugzilla.redhat.com/show_bug.cgi?id=964143 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ptJMLFelRSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection
https://bugzilla.redhat.com/show_bug.cgi?id=964143 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- python-testscenarios-0.4-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-testscenarios-0.4-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5NUO8x7WNXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection
https://bugzilla.redhat.com/show_bug.cgi?id=964143 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- python-testscenarios-0.4-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-testscenarios-0.4-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Egko1GZnSda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection
https://bugzilla.redhat.com/show_bug.cgi?id=964143 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- python-testscenarios-0.4-2.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xJ1DgpnBI9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection
https://bugzilla.redhat.com/show_bug.cgi?id=964143 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8JlHTPyHcGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection
https://bugzilla.redhat.com/show_bug.cgi?id=964143 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0Wszm1MMmda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection
https://bugzilla.redhat.com/show_bug.cgi?id=964143 Matthias Runge mru...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Matthias Runge mru...@redhat.com --- Thank you, mArio for this review! New Package SCM Request === Package Name: python-testscenarios Short Description: Testscenarios, a pyunit extension for dependency injection Owners: mrunge Branches: f19 el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Kg3EbR0LPUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection
https://bugzilla.redhat.com/show_bug.cgi?id=964143
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com ---
New scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5419716
$ rpmlint -i -v *
python-testscenarios.src: I: checking
python-testscenarios.src: W: spelling-error Summary(en_US) pyunit - impunity
The value of this tag appears to be misspelled. Please double-check.
python-testscenarios.src: W: spelling-error %description -l en_US unittest -
unit test, unit-test, unities
The value of this tag appears to be misspelled. Please double-check.
python-testscenarios.src: I: checking-url https://launchpad.net/testscenarios
(timeout 10 seconds)
python-testscenarios.src: I: checking-url
http://pypi.python.org/packages/source/t/testscenarios/testscenarios-0.4.tar.gz
(timeout 10 seconds)
python-testscenarios.noarch: I: checking
python-testscenarios.noarch: W: spelling-error Summary(en_US) pyunit -
impunity
The value of this tag appears to be misspelled. Please double-check.
python-testscenarios.noarch: W: spelling-error %description -l en_US unittest
- unit test, unit-test, unities
The value of this tag appears to be misspelled. Please double-check.
python-testscenarios.noarch: I: checking-url
https://launchpad.net/testscenarios (timeout 10 seconds)
python-testscenarios.spec: I: checking-url
http://pypi.python.org/packages/source/t/testscenarios/testscenarios-0.4.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Besides some ignorable spelling errors, nothing of interest.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
ASL 2.0 and BSD
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[.] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
sha256sum *
4f84f7fd8a6258fc00671e1521f80cb68d2fec1e2908b3ab52bcf396e198
testscenarios-0.4.tar.gz
4f84f7fd8a6258fc00671e1521f80cb68d2fec1e2908b3ab52bcf396e198
testscenarios-0.4.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package
[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection
https://bugzilla.redhat.com/show_bug.cgi?id=964143 --- Comment #2 from Matthias Runge mru...@redhat.com --- Thanks for the review! Updated SPEC: http://www.matthias-runge.de/fedora/python-testscenarios.spec SRPM: http://www.matthias-runge.de/fedora/python-testscenarios-0.4-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DejRXE7xvla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection
https://bugzilla.redhat.com/show_bug.cgi?id=964143 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mario.blaetterm...@gmail.co ||m Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? --- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com --- $ rpmlint -i -v * python-testscenarios.src: I: checking python-testscenarios.src: W: spelling-error Summary(en_US) pyunit - impunity The value of this tag appears to be misspelled. Please double-check. python-testscenarios.src: W: spelling-error %description -l en_US unittest - unit test, unit-test, unities The value of this tag appears to be misspelled. Please double-check. python-testscenarios.src: I: checking-url https://launchpad.net/testscenarios (timeout 10 seconds) python-testscenarios.src: I: checking-url http://pypi.python.org/packages/source/t/testscenarios/testscenarios-0.4.tar.gz (timeout 10 seconds) python-testscenarios.noarch: I: checking python-testscenarios.noarch: W: spelling-error Summary(en_US) pyunit - impunity The value of this tag appears to be misspelled. Please double-check. python-testscenarios.noarch: W: spelling-error %description -l en_US unittest - unit test, unit-test, unities The value of this tag appears to be misspelled. Please double-check. python-testscenarios.noarch: I: checking-url https://launchpad.net/testscenarios (timeout 10 seconds) python-testscenarios.noarch: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. python-testscenarios.spec: I: checking-url http://pypi.python.org/packages/source/t/testscenarios/testscenarios-0.4.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 5 warnings. Please add the doc files from the tarball to the package: Apache-2.0 COPYING GOALS BSD HACKING NEWS README The package is dual-licensed (Apache and BSD) which should be refelected in the license tag. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nS4976FWBda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 964143] Review Request: python-testscenarios - Testscenarios, a pyunit extension for dependency injection
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=964143 Matthias Runge mru...@redhat.com changed: What|Removed |Added Blocks||962132 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eYa6zETk3ga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
