[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 --- Comment #15 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). f20 already existed. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 Patrick Uiterwijk puiterw...@redhat.com changed: What|Removed |Added CC||puiterw...@redhat.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #14 from Patrick Uiterwijk puiterw...@redhat.com --- Package Change Request == Package Name: mod_auth_openid New Branches: f19 f20 Owners: puiterwijk kevin InitialCC: It got fixed for Apache 2.4, so I can now build it for this -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #13 from Christopher Meng cicku...@gmail.com --- Upstream has released 0.8 version. Can you build it on rawhide now? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||mod_auth_openid-0.7-2.el6 Resolution|--- |ERRATA Last Closed||2013-06-14 18:26:21 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- mod_auth_openid-0.7-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bSsL5cUZAKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 Bug 965443 depends on bug 825333, which changed state. Bug 825333 Summary: Review Request: libopkele - A C++ implementation of the OpenID decentralized identity system https://bugzilla.redhat.com/show_bug.cgi?id=825333 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xlnvrqUi18a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- mod_auth_openid-0.7-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mod_auth_openid-0.7-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OHFwowCpCDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mKvNHrG3Kca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- mod_auth_openid-0.7-2.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DGVmYhKjpoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fF6VryuISna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JVzyXjbVVAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 --- Comment #2 from Patrick Uiterwijk puiterw...@gmail.com --- Also, please note that because of the newer version of httpd, this will not currently build on rawhide. I am currently working with upstream to fix this, but I need this package primarily for the EPEL6 branch. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dW3jocCHkUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added CC||b...@serpentine.com --- Comment #3 from Patrick Uiterwijk puiterw...@gmail.com --- *** Bug 691602 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cE2mzt0mjTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added Target Release||--- --- Comment #1 from Patrick Uiterwijk puiterw...@gmail.com --- I did not create a mock build because libopkele has not yet landed in rawhide. When that is installed manually, you can build this package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yKxR8COSHda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added Depends On||825333 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0fMZuHw8taa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443
--- Comment #5 from Kevin Fenzi ke...@scrye.com ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (MIT)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
58cb927121d39557a3593b10db8c960440295fb49cddf8120d6a5b521877ed4c
mod_auth_openid-0.7.tar.gz
58cb927121d39557a3593b10db8c960440295fb49cddf8120d6a5b521877ed4c
mod_auth_openid-0.7.tar.gz.orig
See below - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
See below - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output.
See below - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin
Issues:
1. You are missing a
BuildRequires: tidy-devel
that causes it to not build.
2. The module is installed with mode 644, but that causes rpm to not be able to
handle looking for deps on it. Installed with 755, it finds them and you can
drop:
Requires: libopkele
Requires: sqlite
Requires: pcre
Requires: libcurl
3. You have:
cat %{SOURCE2} %{SOURCE1} %{buildroot}%{_httpd_confdir}/mod_security.conf
Shouldn't that be:
cat %{SOURCE2} %{SOURCE1} %{buildroot}%{_httpd_confdir}/mod_auth_openid.conf
4. rpmlint says:
mod_auth_openid.src: W: spelling-error Summary(en_US) apache - Apache, apace
mod_auth_openid.src: W: spelling-error %description -l en_US auth - auto,
Ruth, author
mod_auth_openid.src: W: spelling-error %description -l en_US openid - opined,
opened, open id
mod_auth_openid.src: W: spelling-error %description -l en_US webserver - web
server, web-server, observer
mod_auth_openid.x86_64: W: spelling-error Summary(en_US) apache - Apache,
apace
mod_auth_openid.x86_64: W: spelling-error %description -l en_US auth - auto,
Ruth, author
mod_auth_openid.x86_64: W: spelling-error %description -l en_US openid -
opined, opened, open id
mod_auth_openid.x86_64: W: spelling-error %description -l en_US webserver -
web server, web-server, observer
mod_auth_openid-debuginfo.x86_64: W: spelling-error Summary(en_US) auth -
auto, Ruth, author
mod_auth_openid-debuginfo.x86_64: W: spelling-error Summary(en_US) openid -
opined, opened, open id
mod_auth_openid-debuginfo.x86_64: W: spelling-error %description -l en_US auth
- auto, Ruth, author
mod_auth_openid-debuginfo.x86_64: W: spelling-error %description -l en_US
openid - opined, opened, open id
Useless spelling errors, can be ignored.
mod_auth_openid.src: E: description-line-too-long C It handles the functions of
an OpenID consumer as specified in the OpenID 2.0 specification.
mod_auth_openid.x86_64: E: description-line-too-long C It handles the functions
of an OpenID consumer as specified in the OpenID 2.0 specification.
Might change this to: OpenID 2.0 consumer module for apache web server ?
mod_auth_openid.x86_64: E: explicit-lib-dependency libcurl
mod_auth_openid.x86_64: E: explicit-lib-dependency libopkele
These would be fixed by above requires being dropped.
mod_auth_openid.x86_64: E: non-standard-dir-perm /var/lib/mod_auth_openid 0770L
Do you need this perm?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=1SEHpOo7Zta=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #7 from Kevin Fenzi ke...@scrye.com --- All those changes look good. I see no further blockers, so this package is APPROVED. Happy to co-maintain. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l0NXYIwXkDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 --- Comment #6 from Patrick Uiterwijk puiterw...@gmail.com --- BuildRequires and Requires fixed. Description line changed according to suggestion. The permission is strict because that directory will be the default location for the OpenID state database, which contains the negotiated secret keys. New Spec URL: http://puiterwijk.fedorapeople.org/mod_auth_openid.spec New SRPM URL: http://puiterwijk.fedorapeople.org/mod_auth_openid-0.7-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dT2PqXveVVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||ke...@scrye.com Assignee|nob...@fedoraproject.org|ke...@scrye.com Flags||fedora-review? --- Comment #4 from Kevin Fenzi ke...@scrye.com --- I'll go ahead and review this, look for a review later today. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Xk0bAw4wfYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965443] Review Request: mod_auth_openid - OpenID authentication for apache
https://bugzilla.redhat.com/show_bug.cgi?id=965443 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Patrick Uiterwijk puiterw...@gmail.com --- New Package SCM Request === Package Name: mod_auth_openid Short Description: OpenID authentication for apache Owners: puiterwijk kevin Branches: el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Dcq5cldJFDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
