needinfo canceled: [Bug 966324] Review Request: codecrypt - The post-quantum cryptography tool
Product: Fedora Version: rawhide Component: Package Review Package Review has canceled Package Review 's request for Christopher Meng 's needinfo: Bug 966324: Review Request: codecrypt - The post-quantum cryptography tool https://bugzilla.redhat.com/show_bug.cgi?id=966324 --- Comment #13 from Package Review --- This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 966324] Review Request: codecrypt - The post-quantum cryptography tool
https://bugzilla.redhat.com/show_bug.cgi?id=966324 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed: What|Removed |Added CC||zbys...@in.waw.pl Whiteboard||NotReady -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966324] Review Request: codecrypt - The post-quantum cryptography tool
https://bugzilla.redhat.com/show_bug.cgi?id=966324 Mirek Kratochvil exa@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Flags|needinfo?(nobody@fedoraproj | |ect.org)| --- Comment #11 from Mirek Kratochvil exa@gmail.com --- Bump. codecrypt-1.3.1 removes bundled libraries and instead adds dependency on crypto++ library which is already available as cryptopp fedora package. Christopher, can you please create .srpm's for that version? -mk -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FKM0xDmOU3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966324] Review Request: codecrypt - The post-quantum cryptography tool
https://bugzilla.redhat.com/show_bug.cgi?id=966324 Bug 966324 depends on bug 969387, which changed state. Bug 969387 Summary: Review Request: freetiger - Free implementation of the tiger hash algorithm https://bugzilla.redhat.com/show_bug.cgi?id=969387 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dL4bS8pi0ha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966324] Review Request: codecrypt - The post-quantum cryptography tool
https://bugzilla.redhat.com/show_bug.cgi?id=966324 --- Comment #10 from Björn besser82 Esser bjoern.es...@gmail.com --- freetiger has been send out as an update for el5, el6, fc18, fc19. Builds for fc20 and rawhide are made, too. I just created the needed buildroot-overrides for all branches. :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZbD2It5JTma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966324] Review Request: codecrypt - The post-quantum cryptography tool
https://bugzilla.redhat.com/show_bug.cgi?id=966324
--- Comment #5 from Björn Esser bjoern.es...@gmail.com ---
There are some files with bsd license, can you review them? to check that we
are not incurring in
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
BSD (2 clause)
--
/var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/codecrypt-1.1/
src/sha2.c
/var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/codecrypt-1.1/
src/sha2.h
* BUNDLED LIB CONFIRMED *
This is perfectly the same as provided by sha2(-devel) !!!
Make upstream aware of this and ask to add a check for a usable sha2.h /
sha2-lib during configure, which only includes/links the sources-shipped
sha2-files if no working sha2-lib is found.
tiger.{c,h} is NOT A DUPLICATE (checked against libtiger, cryptopp, botan)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=oYvF6ZTP65a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966324] Review Request: codecrypt - The post-quantum cryptography tool
https://bugzilla.redhat.com/show_bug.cgi?id=966324
--- Comment #6 from Christopher Meng cicku...@gmail.com ---
(In reply to Björn Esser from comment #5)
* BUNDLED LIB CONFIRMED *
This is perfectly the same as provided by sha2(-devel) !!!
Make upstream aware of this and ask to add a check for a usable sha2.h /
sha2-lib during configure, which only includes/links the sources-shipped
sha2-files if no working sha2-lib is found.
tiger.{c,h} is NOT A DUPLICATE (checked against libtiger, cryptopp, botan)
Thanks, this should be done by myself...
Deeply appreciate your hard work!
I'll report this to upstream.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=K208xuTBfLa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966324] Review Request: codecrypt - The post-quantum cryptography tool
https://bugzilla.redhat.com/show_bug.cgi?id=966324 Mirek Kratochvil exa@gmail.com changed: What|Removed |Added CC||exa@gmail.com, ||nob...@fedoraproject.org Flags||needinfo?(nobody@fedoraproj ||ect.org) --- Comment #7 from Mirek Kratochvil exa@gmail.com --- Hi everyone, I was not aware that fedora has its own package for sha2, gonna add configure check asap. Q: Is there some problem with copying RIPEMD-128 implementation as seen in src/ripemd128.[ch] ? Thanks, -mk -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5BXKG7BzVMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966324] Review Request: codecrypt - The post-quantum cryptography tool
https://bugzilla.redhat.com/show_bug.cgi?id=966324 --- Comment #8 from Eduardo Echeverria echevemas...@gmail.com --- (In reply to Mirek Kratochvil from comment #7) Hi everyone, I was not aware that fedora has its own package for sha2, gonna add configure check asap. Q: Is there some problem with copying RIPEMD-128 implementation as seen in src/ripemd128.[ch] ? Thanks, -mk Hi Mirek, yes, apparently is part of beecrypt-devel, see the file marked with * repoquery --list beecrypt-devel /usr/include/beecrypt /usr/include/beecrypt/aes.h /usr/include/beecrypt/aesopt.h /usr/include/beecrypt/api.h /usr/include/beecrypt/base64.h /usr/include/beecrypt/beecrypt.h /usr/include/beecrypt/blockmode.h /usr/include/beecrypt/blockpad.h /usr/include/beecrypt/blowfish.h /usr/include/beecrypt/blowfishopt.h /usr/include/beecrypt/dhies.h /usr/include/beecrypt/dldp.h /usr/include/beecrypt/dlkp.h /usr/include/beecrypt/dlpk.h /usr/include/beecrypt/dlsvdp-dh.h /usr/include/beecrypt/dsa.h /usr/include/beecrypt/elgamal.h /usr/include/beecrypt/endianness.h /usr/include/beecrypt/entropy.h /usr/include/beecrypt/fips186.h /usr/include/beecrypt/gnu.h /usr/include/beecrypt/hmac.h /usr/include/beecrypt/hmacmd5.h /usr/include/beecrypt/hmacsha1.h /usr/include/beecrypt/hmacsha224.h /usr/include/beecrypt/hmacsha256.h /usr/include/beecrypt/hmacsha384.h /usr/include/beecrypt/hmacsha512.h /usr/include/beecrypt/md4.h /usr/include/beecrypt/md5.h /usr/include/beecrypt/memchunk.h /usr/include/beecrypt/mp.h /usr/include/beecrypt/mpbarrett.h /usr/include/beecrypt/mpnumber.h /usr/include/beecrypt/mpopt.h /usr/include/beecrypt/mpprime.h /usr/include/beecrypt/mtprng.h /usr/include/beecrypt/pkcs1.h /usr/include/beecrypt/pkcs12.h /usr/include/beecrypt/ripemd128.h /usr/include/beecrypt/ripemd160.h /usr/include/beecrypt/ripemd256.h /usr/include/beecrypt/ripemd320.h /usr/include/beecrypt/rsa.h /usr/include/beecrypt/rsakp.h /usr/include/beecrypt/rsapk.h /usr/include/beecrypt/sha1.h /usr/include/beecrypt/sha1opt.h /usr/include/beecrypt/sha224.h /usr/include/beecrypt/sha256.h /usr/include/beecrypt/sha2k32.h /usr/include/beecrypt/sha2k64.h /usr/include/beecrypt/sha384.h /usr/include/beecrypt/sha512.h /usr/include/beecrypt/timestamp.h /usr/include/beecrypt/win.h /usr/lib/libbeecrypt.so /usr/share/doc/beecrypt-devel-4.2.1 /usr/share/doc/beecrypt-devel-4.2.1/BUGS /usr/include/beecrypt /usr/include/beecrypt/aes.h /usr/include/beecrypt/aesopt.h /usr/include/beecrypt/api.h /usr/include/beecrypt/base64.h /usr/include/beecrypt/beecrypt.h /usr/include/beecrypt/blockmode.h /usr/include/beecrypt/blockpad.h /usr/include/beecrypt/blowfish.h /usr/include/beecrypt/blowfishopt.h /usr/include/beecrypt/dhies.h /usr/include/beecrypt/dldp.h /usr/include/beecrypt/dlkp.h /usr/include/beecrypt/dlpk.h /usr/include/beecrypt/dlsvdp-dh.h /usr/include/beecrypt/dsa.h /usr/include/beecrypt/elgamal.h /usr/include/beecrypt/endianness.h /usr/include/beecrypt/entropy.h /usr/include/beecrypt/fips186.h /usr/include/beecrypt/gnu.h /usr/include/beecrypt/hmac.h /usr/include/beecrypt/hmacmd5.h /usr/include/beecrypt/hmacsha1.h /usr/include/beecrypt/hmacsha224.h /usr/include/beecrypt/hmacsha256.h /usr/include/beecrypt/hmacsha384.h /usr/include/beecrypt/hmacsha512.h /usr/include/beecrypt/md4.h /usr/include/beecrypt/md5.h /usr/include/beecrypt/memchunk.h /usr/include/beecrypt/mp.h /usr/include/beecrypt/mpbarrett.h /usr/include/beecrypt/mpnumber.h /usr/include/beecrypt/mpopt.h /usr/include/beecrypt/mpprime.h /usr/include/beecrypt/mtprng.h /usr/include/beecrypt/pkcs1.h /usr/include/beecrypt/pkcs12.h * /usr/include/beecrypt/ripemd128.h /usr/include/beecrypt/ripemd160.h /usr/include/beecrypt/ripemd256.h /usr/include/beecrypt/ripemd320.h /usr/include/beecrypt/rsa.h /usr/include/beecrypt/rsakp.h /usr/include/beecrypt/rsapk.h /usr/include/beecrypt/sha1.h /usr/include/beecrypt/sha1opt.h /usr/include/beecrypt/sha224.h /usr/include/beecrypt/sha256.h /usr/include/beecrypt/sha2k32.h /usr/include/beecrypt/sha2k64.h /usr/include/beecrypt/sha384.h /usr/include/beecrypt/sha512.h /usr/include/beecrypt/timestamp.h /usr/include/beecrypt/win.h /usr/lib64/libbeecrypt.so /usr/share/doc/beecrypt-devel-4.2.1 /usr/share/doc/beecrypt-devel-4.2.1/BUGS -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fTPnOejiOHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966324] Review Request: codecrypt - The post-quantum cryptography tool
https://bugzilla.redhat.com/show_bug.cgi?id=966324 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Depends On||969387 --- Comment #9 from Björn Esser bjoern.es...@gmail.com --- BSD (3 clause) -- /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/codecrypt-1.1/ src/tiger.c /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/codecrypt-1.1/ src/tiger.h * BUNDLED LIB CONFIRMED * These are now available through freetiger, I just filed a review-bug for. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AIKUZMGUaGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966324] Review Request: codecrypt - The post-quantum cryptography tool
https://bugzilla.redhat.com/show_bug.cgi?id=966324 --- Comment #2 from Christopher Meng cicku...@gmail.com --- New SRPM: http://cicku.me/codecrypt-1.2-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Wf66Nhx5gPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966324] Review Request: codecrypt - The post-quantum cryptography tool
https://bugzilla.redhat.com/show_bug.cgi?id=966324 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added CC||bjoern.es...@gmail.com --- Comment #3 from Björn Esser bjoern.es...@gmail.com --- Would you update the Spec/SRPM URL-Tags, please? Thoose tags are traced by `fedora-review`, so it will automagicly fetch the updated stuff. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2oqN9hf5Sza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966324] Review Request: codecrypt - The post-quantum cryptography tool
https://bugzilla.redhat.com/show_bug.cgi?id=966324 --- Comment #4 from Christopher Meng cicku...@gmail.com --- New Spec: http://cicku.me/codecrypt.spec New SRPM: http://cicku.me/codecrypt-1.2-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vJ79dS1BLBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966324] Review Request: codecrypt - The post-quantum cryptography tool
https://bugzilla.redhat.com/show_bug.cgi?id=966324 Eduardo Echeverria echevemas...@gmail.com changed: What|Removed |Added CC||echevemas...@gmail.com --- Comment #1 from Eduardo Echeverria echevemas...@gmail.com --- Hi @cicku, codecrypt is LGPLv3+ please fix the license field and add the COPYING.LESSER boilerplate. Update the package to the 1.2 release, http://e-x-a.org/codecrypt/files/codecrypt-1.2.tar.gz and I'll do the review There are some files with bsd license, can you review them? to check that we are not incurring in https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries BSD (2 clause) -- /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/codecrypt-1.1/src/sha2.c /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/codecrypt-1.1/src/sha2.h BSD (3 clause) -- /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/codecrypt-1.1/src/tiger.c /var/lib/mock/fedora-rawhide-x86_64/root/builddir/build/BUILD/codecrypt-1.1/src/tiger.h -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6GtVTOUWWMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966324] Review Request: codecrypt - The post-quantum cryptography tool
https://bugzilla.redhat.com/show_bug.cgi?id=966324 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Summary|Review Request: codecrypt - |Review Request: codecrypt - |short summary here|The post-quantum ||cryptography tool -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pBbJWyrQL5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
