[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 --- Comment #15 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 Christopher Meng changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #14 from Christopher Meng --- Package Change Request == Package Name: nf3d New Branches: epel7 Owners: cicku -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 Fedora Update System changed: What|Removed |Added Fixed In Version|nf3d-0.8-1.fc19 |nf3d-0.8-1.el6 --- Comment #13 from Fedora Update System --- nf3d-0.8-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gYhZsUaDUm&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 Fedora Update System changed: What|Removed |Added Fixed In Version|nf3d-0.8-1.fc20 |nf3d-0.8-1.fc19 --- Comment #12 from Fedora Update System --- nf3d-0.8-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pwJY8u6E7P&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nf3d-0.8-1.fc20 Resolution|--- |ERRATA Last Closed||2013-09-22 20:27:46 --- Comment #11 from Fedora Update System --- nf3d-0.8-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aLBym67A12&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- nf3d-0.8-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=skXXIkOu2y&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 --- Comment #9 from Fedora Update System --- nf3d-0.8-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nf3d-0.8-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zEooiVzJq5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 --- Comment #8 from Fedora Update System --- nf3d-0.8-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nf3d-0.8-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fftZbNiMk0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 --- Comment #7 from Fedora Update System --- nf3d-0.8-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nf3d-0.8-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7aM97ZmGbS&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ico3ruZYfU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JHODvihUox&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gmhjvxtf3H&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 Christopher Meng changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=S9uY5WZyLg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 --- Comment #5 from Christopher Meng --- New Package SCM Request === Package Name: nf3d Short Description: GANTT-style visualization for Netfilter connections and logged packets Owners: cicku Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X2t67Fti9H&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 Douglas Schilling Landgraf changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ya8u3xuTsl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 Douglas Schilling Landgraf changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kIUIzPLGnd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485
Douglas Schilling Landgraf changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #4 from Douglas Schilling Landgraf ---
[OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review
Rpmlint
---
Checking: nf3d-0.8-1.fc18.noarch.rpm
nf3d.noarch: W: no-manual-page-for-binary nf3d
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
There is no man page, if possible work with upstream to provide man-page.
Rpmlint (installed packages)
# rpmlint nf3d
nf3d.noarch: W: no-documentation
nf3d.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/nf3d/infos.py
nf3d.noarch: W: non-conffile-in-etc /etc/nf3d.conf
nf3d.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/nf3d/__init__.py 0644L /usr/bin/env
nf3d.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/nf3d/__init__.py
nf3d.noarch: E: incorrect-fsf-address /usr/bin/nf3d
nf3d.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/nf3d/connobj.py 0644L /usr/bin/env
nf3d.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/nf3d/connobj.py
nf3d.noarch: W: no-manual-page-for-binary nf3d
1 packages and 0 specfiles checked; 6 errors, 3 warnings.
Please work with upstream to solve the above issues (FSF address and python
sources with shebang)
[OK] MUST: The package must be named according to the Package Naming Guidelines
[OK] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[OK] MUST: The package must meet the Packaging Guidelines .
[OK] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[OK] MUST: The License field in the package spec file must match the actual
license
[OK] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc
[OK] MUST: The spec file must be written in American English.
[OK] MUST: The spec file for the package MUST be legible.
[OK] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use sha256sum for this
task as it is used by the sources file once imported into git. If no upstream
URL can be specified for this package, please see the Source URL Guidelines for
how to deal with this.
CHECKSUM(SHA256) this package :
26c9d9128879b0b97df5c5bd3efebd99ad4acfba8a84ae25931821b6a3fab409
CHECKSUM(SHA256) upstream package :
26c9d9128879b0b97df5c5bd3efebd99ad4acfba8a84ae25931821b6a3fab409
[OK] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[OK] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[OK] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[OK] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[OK] MUST: Each package must consistently use macros
[OK] MUST: The package must contain code, or permissable content
[OK] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[OK] MUST: All filenames in rpm packages must be valid UTF-8
Python
=
[OK]: Package contains BR: python2-devel or python3-devel
[OK]: Binary eggs must be removed in %prep
Should
=
[OK]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[OK]: Sources can be downloaded from URI in Source: tag
[OK]: Reviewer should test that the package builds in mock.
[OK]: Buildroot is not present
[OK]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[OK]: Dist tag is present.
[OK]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[OK]: SourceX tarball generation or download is documented.
[OK]: SourceX is a working URL.
[OK]: Spec use %global instead of %define.
Status: APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=vwMtbAWRs5&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 --- Comment #3 from Christopher Meng --- NEW: Spec URL: http://cicku.me/nf3d.spec SRPM URL: http://cicku.me/nf3d-0.8-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JIrUIn5PPL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 --- Comment #2 from Christopher Meng --- Thanks for figuring out the issues, I'll fix them ASAP. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=k7O95kc1DB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967485] Review Request: nf3d - GANTT-style visualization for Netfilter connections and logged packets
https://bugzilla.redhat.com/show_bug.cgi?id=967485 Douglas Schilling Landgraf changed: What|Removed |Added Status|NEW |ASSIGNED CC||dougsl...@redhat.com Assignee|nob...@fedoraproject.org|dougsl...@redhat.com --- Comment #1 from Douglas Schilling Landgraf --- Christopher, For this package please look this page: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires Can you please also check the following rpmlint output: nf3d.noarch: W: non-conffile-in-etc /etc/nf3d.conf http://fedoraproject.org/wiki/Common_Rpmlint_issues#non-conffile-in-etc nf3d.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/nf3d/infos.py Can you please notify upstream developers? http://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address nf3d.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/nf3d/__init__.py 0644L /usr/bin/env nf3d.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/nf3d/connobj.py 0644L /usr/bin/env http://fedoraproject.org/wiki/Packaging_tricks nf3d.noarch: W: no-manual-page-for-binary nf3d http://fedoraproject.org/wiki/Packaging:Guidelines#Man_pages Can you please open a ticket/bugzilla to upstream just for the record? Thanks! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8RvaySf3XE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
