[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-escodegen-0.0.22-2.f |nodejs-escodegen-0.0.22-2.e |c19 |l6 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- nodejs-escodegen-0.0.22-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XMspxYYgYYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-escodegen-0.0.22-2.f |nodejs-escodegen-0.0.22-2.f |c18 |c19 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- nodejs-escodegen-0.0.22-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eeQt0dO4Jta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||nodejs-escodegen-0.0.22-2.f ||c18 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- nodejs-escodegen-0.0.22-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NkpLmL01xSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-06-18 01:46:28 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GxOXDJGanUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AqvGqLQEgxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- nodejs-escodegen-0.0.22-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-escodegen-0.0.22-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XimKW18dWja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- nodejs-escodegen-0.0.22-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-escodegen-0.0.22-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=19aqo8rEx7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- nodejs-escodegen-0.0.22-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-escodegen-0.0.22-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gOukwrlRMKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- nodejs-escodegen-0.0.22-2.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NzuRa6W93pa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Bug 968598 depends on bug 968600, which changed state. Bug 968600 Summary: Review Request: nodejs-estraverse - ECMAScript JS AST traversal functions https://bugzilla.redhat.com/show_bug.cgi?id=968600 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hE7FpOyHEoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v41DamcvEAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZO34c2cL6aa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iVGoS7kFEPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Flags||needinfo? --- Comment #1 from Miro Hrončok mhron...@redhat.com --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: === [!]: [MUST] License field in the package spec file matches the actual license. I believe, it's BSD, not MIT, according to package.json, LICENSE.BSD and LICENSE.source-map = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. Note: There is something in Source1/test/3rdparty, but it is not packaged [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local = SHOULD items = Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. Disabled by default [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added CC||jamieli...@fedoraproject.or ||g Flags|needinfo? | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lP0zQwhRLua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Flags||needinfo?(jamielinux@fedora ||project.org) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QKaOt4CZwOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Flags|needinfo?(jamielinux@fedora | |project.org)| --- Comment #2 from Jamie Nguyen jamieli...@fedoraproject.org --- Spec URL: http://jamielinux.fedorapeople.org/nodeunit/nodejs-escodegen.spec SRPM URL: http://jamielinux.fedorapeople.org/nodeunit/SRPMS/nodejs-escodegen-0.0.22-2.fc19.src.rpm * Fri Jun 07 2013 Jamie Nguyen jamieli...@fedoraproject.org - 0.0.22-2 - add comment about dependencies for %%check - fix incorrect License tag -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rFIY9QGntfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #3 from Miro Hrončok mhron...@redhat.com --- Package APPROVED. BTW if esprima-moz looks like a fork of esprima and both can coexist, I don't think you need FPC approval for that. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GDa1pzwI2Ja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 --- Comment #4 from Jamie Nguyen jamieli...@fedoraproject.org --- BTW if esprima-moz looks like a fork of esprima and both can coexist, I don't think you need FPC approval for that. Oh, cool! I'll remove that part of the comment and may look into packaging esprima-moz if it looks useful. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UadyuXuaOYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Jamie Nguyen jamieli...@fedoraproject.org --- New Package SCM Request === Package Name: nodejs-escodegen Short Description: ECMAScript code generator Owners: jamielinux patches Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=buLtPUpAyVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Bug 968598 depends on bug 968599, which changed state. Bug 968599 Summary: Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis https://bugzilla.redhat.com/show_bug.cgi?id=968599 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vIzyER5BTba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||968596 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xcTOcuZNJIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Depends On||968599, 968600 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8dlpRW5cRqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968598] Review Request: nodejs-escodegen - ECMAScript code generator
https://bugzilla.redhat.com/show_bug.cgi?id=968598 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||956806 (nodejs-reviews) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=clxDcKZRAta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review