[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599 Jamie Nguyen changed: What|Removed |Added Blocks||968596 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BYl4Pu1oF3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599 Jamie Nguyen changed: What|Removed |Added Blocks||968598 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tAQnBqf5nD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599 Jamie Nguyen changed: What|Removed |Added Blocks||956806 (nodejs-reviews) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oshDgLDNrR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599 Miro Hrončok changed: What|Removed |Added CC||mhron...@redhat.com Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pSF7aI77iC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599
Miro Hrončok changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||jamieli...@fedoraproject.or
||g
Flags||needinfo?(jamielinux@fedora
||project.org)
--- Comment #1 from Miro Hrončok ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= Issues =
Please explain the source of the manpages, consider downloading whole repo for
tests following the Github rule (or explain why not to)
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
Note: There is bundled code for testing in Source1/test/3rdparty
But it is not packaged to the binary package
All test-related stuff is under Fedora approved licenses, so it is able to
stay in SRPM
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 51200 bytes in 8 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[?]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
Not sure, if you shouldn't apply Github rule for downlaoding tests
http://fedoraproject.org/wiki/Packaging:SourceURL#Github
Where are the manpages from?
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present
[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599 Jamie Nguyen changed: What|Removed |Added Flags|needinfo?(jamielinux@fedora | |project.org)| --- Comment #2 from Jamie Nguyen --- Thanks for the review! Spec URL: http://jamielinux.fedorapeople.org/nodeunit/nodejs-esprima.spec SRPM URL: http://jamielinux.fedorapeople.org/nodeunit/SRPMS/nodejs-esprima-1.0.3-1.fc19.src.rpm * Fri May 31 2013 Jamie Nguyen - 1.0.3-2 - add comment about how man pages were generated - add comment about downloading of test directory It seems to me that the GitHub guidelines are there more to prevent use of the auto-generated tarballs, so I'm not sure it really applies in this case. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EN9JLvVzBR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599 Miro Hrončok changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #3 from Miro Hrončok --- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Qh3ALlHLSY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599 Jamie Nguyen changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Jamie Nguyen --- New Package SCM Request === Package Name: nodejs-esprima Short Description: ECMAScript parsing infrastructure for multipurpose analysis Owners: jamielinux patches Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M1M1UD7dqD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QMsEfEgoUF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tQ0rFzXSfI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599 --- Comment #6 from Fedora Update System --- nodejs-esprima-1.0.3-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-esprima-1.0.3-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=p4jZwA6izP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Sqe9QxNzTK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599 --- Comment #7 from Fedora Update System --- nodejs-esprima-1.0.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-esprima-1.0.3-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=E9BGWYJXn9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599 --- Comment #8 from Fedora Update System --- nodejs-esprima-1.0.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-esprima-1.0.3-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=g04BfSKx18&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599 Jamie Nguyen changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2013-06-03 06:57:03 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RGTjZrU3cA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-esprima-1.0.3-2.fc18 --- Comment #9 from Fedora Update System --- nodejs-esprima-1.0.3-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=E0FnpLo5me&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-esprima-1.0.3-2.fc18 |nodejs-esprima-1.0.3-2.fc19 --- Comment #10 from Fedora Update System --- nodejs-esprima-1.0.3-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lssG5Sv2H1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968599] Review Request: nodejs-esprima - ECMAScript parsing infrastructure for multipurpose analysis
https://bugzilla.redhat.com/show_bug.cgi?id=968599 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-esprima-1.0.3-2.fc19 |nodejs-esprima-1.0.3-2.el6 --- Comment #11 from Fedora Update System --- nodejs-esprima-1.0.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dOG45SDUiL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
