[Bug 969111] Review Request: libxdiff - Basic functionality to create difference/patches in binary and text
https://bugzilla.redhat.com/show_bug.cgi?id=969111 Fedora Update System changed: What|Removed |Added Fixed In Version|libxdiff-1.0-1.fc17 |libxdiff-1.0-1.fc18 --- Comment #12 from Fedora Update System --- libxdiff-1.0-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yeHK8c78V9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969111] Review Request: libxdiff - Basic functionality to create difference/patches in binary and text
https://bugzilla.redhat.com/show_bug.cgi?id=969111 Fedora Update System changed: What|Removed |Added Fixed In Version|libxdiff-1.0-1.fc19 |libxdiff-1.0-1.fc17 --- Comment #11 from Fedora Update System --- libxdiff-1.0-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RI5JOe3F4f&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969111] Review Request: libxdiff - Basic functionality to create difference/patches in binary and text
https://bugzilla.redhat.com/show_bug.cgi?id=969111 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||libxdiff-1.0-1.fc19 Resolution|--- |ERRATA Last Closed||2013-06-18 02:11:07 --- Comment #10 from Fedora Update System --- libxdiff-1.0-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qv4Ff2PWQU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969111] Review Request: libxdiff - Basic functionality to create difference/patches in binary and text
https://bugzilla.redhat.com/show_bug.cgi?id=969111 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- libxdiff-1.0-1.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n0j2uIllI1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969111] Review Request: libxdiff - Basic functionality to create difference/patches in binary and text
https://bugzilla.redhat.com/show_bug.cgi?id=969111 --- Comment #8 from Fedora Update System --- libxdiff-1.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/libxdiff-1.0-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L3GFluLIZ6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969111] Review Request: libxdiff - Basic functionality to create difference/patches in binary and text
https://bugzilla.redhat.com/show_bug.cgi?id=969111 --- Comment #7 from Fedora Update System --- libxdiff-1.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libxdiff-1.0-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZXsLVQ57iJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969111] Review Request: libxdiff - Basic functionality to create difference/patches in binary and text
https://bugzilla.redhat.com/show_bug.cgi?id=969111 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bvarNSx3eH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969111] Review Request: libxdiff - Basic functionality to create difference/patches in binary and text
https://bugzilla.redhat.com/show_bug.cgi?id=969111 --- Comment #6 from Fedora Update System --- libxdiff-1.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libxdiff-1.0-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1FuGOyxFZj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969111] Review Request: libxdiff - Basic functionality to create difference/patches in binary and text
https://bugzilla.redhat.com/show_bug.cgi?id=969111 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vZFEbaqF7L&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969111] Review Request: libxdiff - Basic functionality to create difference/patches in binary and text
https://bugzilla.redhat.com/show_bug.cgi?id=969111 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2BU4i1GItW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969111] Review Request: libxdiff - Basic functionality to create difference/patches in binary and text
https://bugzilla.redhat.com/show_bug.cgi?id=969111 Tom "spot" Callaway changed: What|Removed |Added Status|ASSIGNED|NEW Flags||fedora-cvs? --- Comment #4 from Tom "spot" Callaway --- New Package SCM Request === Package Name: libxdiff Short Description: Basic functionality to create difference/patches in binary and text Owners: spot Branches: f17 f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nyO7YVQA5z&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969111] Review Request: libxdiff - Basic functionality to create difference/patches in binary and text
https://bugzilla.redhat.com/show_bug.cgi?id=969111 Douglas Schilling Landgraf changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nOQqQWuBrR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969111] Review Request: libxdiff - Basic functionality to create difference/patches in binary and text
https://bugzilla.redhat.com/show_bug.cgi?id=969111
Douglas Schilling Landgraf changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #3 from Douglas Schilling Landgraf ---
Hi Tom,
It worked now. Reviewed manually + fedora-review tool.
[OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review
Rpmlint
---
Checking: libxdiff-1.0-1.fc18.x86_64.rpm
libxdiff-devel-1.0-1.fc18.x86_64.rpm
libxdiff.x86_64: W: spelling-error %description -l en_US functionalities ->
functionalists, functionality, functionalist
libxdiff-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint (installed packages)
# rpmlint libxdiff-devel libxdiff
libxdiff-devel.x86_64: W: no-documentation
libxdiff.x86_64: W: spelling-error %description -l en_US functionalities ->
functionalists, functionality, functionalist
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
Above warnings can be ignored.
[OK] MUST: The package must be named according to the Package Naming Guidelines
[OK] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[OK] MUST: The package must meet the Packaging Guidelines .
[OK] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines
[OK] MUST: The License field in the package spec file must match the actual
license.
[OK] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc
[OK] MUST: The spec file must be written in American English
[OK] MUST: The spec file for the package MUST be legible
[OK] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use sha256sum for this
task as it is used by the sources file once imported into git. If no upstream
URL can be specified for this package, please see the Source URL Guidelines for
how to deal with this.
CHECKSUM(SHA256) this package :
667751e2e11971765a421d8d20e038ee2d4122d784ccf8da479cf6f578252159
CHECKSUM(SHA256) upstream package :
667751e2e11971765a421d8d20e038ee2d4122d784ccf8da479cf6f578252159
[OK] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture
[OK] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[OK] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[OK] MUST: Packages must NOT bundle copies of system libraries
[OK] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings
[OK] MUST: Each package must consistently use macros.
[OK] MUST: Development files must be in a -devel package.
[OK] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[OK] MUST: All filenames in rpm packages must be valid UTF-8.
[OK] SHOULD: Packager, Vendor, PreReq, Copyright tags should not be in spec
file
[OK] SHOULD: Sources can be downloaded from URI in Source: tag
[OK] SHOULD: Reviewer should test that the package builds in mock.
[OK] SHOULD: Buildroot is not present
[OK] SHOULD: Package functions as described.
[OK] SHOULD: Latest version is packaged.
[OK] SHOULD: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[OK] SHOULD: Dist tag is present.
[OK] SHOULD: No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[OK] SHOULD: Uses parallel make.
[OK] SHOULD: The placement of pkgconfig(.pc) files are correct.
[OK] SHOULD: SourceX tarball generation or download is documented.
[OK] SHOULD: SourceX is a working URL.
[OK] SHOULD: Spec use %global instead of %define.
Status: APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=gVrNZnT0Sh&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969111] Review Request: libxdiff - Basic functionality to create difference/patches in binary and text
https://bugzilla.redhat.com/show_bug.cgi?id=969111 --- Comment #2 from Tom "spot" Callaway --- Try using wget, if you try that link in a browser, it may not work. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iYZNQ5Hcd0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969111] Review Request: libxdiff - Basic functionality to create difference/patches in binary and text
https://bugzilla.redhat.com/show_bug.cgi?id=969111 Douglas Schilling Landgraf changed: What|Removed |Added CC||dougsl...@redhat.com Assignee|nob...@fedoraproject.org|dougsl...@redhat.com --- Comment #1 from Douglas Schilling Landgraf --- Hi Tom, I cannot download Source0. Are you able? I will try later today, might be a problem with github server. Cheers Douglas -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TyNPwqlGMU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969111] Review Request: libxdiff - Basic functionality to create difference/patches in binary and text
https://bugzilla.redhat.com/show_bug.cgi?id=969111 Tom "spot" Callaway changed: What|Removed |Added Blocks||867959 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JmYF9aSKHM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
