[Bug 969703] Review Request: python-openid-cla - CLA extension for python-openid
https://bugzilla.redhat.com/show_bug.cgi?id=969703 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-openid-cla-1.0-1.fc1 |python-openid-cla-1.0-1.el6 |8 | --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-openid-cla-1.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0leUZjh8LMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969703] Review Request: python-openid-cla - CLA extension for python-openid
https://bugzilla.redhat.com/show_bug.cgi?id=969703 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-openid-cla-1.0-1.fc1 |python-openid-cla-1.0-1.fc1 |9 |8 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-openid-cla-1.0-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0BlurbOTjra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969703] Review Request: python-openid-cla - CLA extension for python-openid
https://bugzilla.redhat.com/show_bug.cgi?id=969703 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-openid-cla-1.0-1.fc1 ||9 Resolution|--- |ERRATA Last Closed||2013-06-14 23:12:40 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-openid-cla-1.0-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BvEwN7Wd1Ya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969703] Review Request: python-openid-cla - CLA extension for python-openid
https://bugzilla.redhat.com/show_bug.cgi?id=969703 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- python-openid-cla-1.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=buExbl67jCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969703] Review Request: python-openid-cla - CLA extension for python-openid
https://bugzilla.redhat.com/show_bug.cgi?id=969703 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=U3Xk14yCOka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969703] Review Request: python-openid-cla - CLA extension for python-openid
https://bugzilla.redhat.com/show_bug.cgi?id=969703 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZAFjbRyqSda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969703] Review Request: python-openid-cla - CLA extension for python-openid
https://bugzilla.redhat.com/show_bug.cgi?id=969703 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dAsaN7JCCca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969703] Review Request: python-openid-cla - CLA extension for python-openid
https://bugzilla.redhat.com/show_bug.cgi?id=969703 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- python-openid-cla-1.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-openid-cla-1.0-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1LMIogbaQ0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969703] Review Request: python-openid-cla - CLA extension for python-openid
https://bugzilla.redhat.com/show_bug.cgi?id=969703 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- python-openid-cla-1.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-openid-cla-1.0-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=55GlGRrKu7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969703] Review Request: python-openid-cla - CLA extension for python-openid
https://bugzilla.redhat.com/show_bug.cgi?id=969703 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- python-openid-cla-1.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-openid-cla-1.0-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZUZxQmVxZta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969703] Review Request: python-openid-cla - CLA extension for python-openid
https://bugzilla.redhat.com/show_bug.cgi?id=969703 --- Comment #1 from Patrick Uiterwijk puiterw...@gmail.com --- This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5450707 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dDJnfqcWnma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969703] Review Request: python-openid-cla - CLA extension for python-openid
https://bugzilla.redhat.com/show_bug.cgi?id=969703 --- Comment #2 from Patrick Uiterwijk puiterw...@gmail.com --- This review is very much alike #963959 because it's practically the same split as that one (but actually another module). The actual koji link is: http://koji.fedoraproject.org/koji/taskinfo?taskID=5450711 (the other one was one where I had an error in the spec file). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dnK3yhek3Ca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969703] Review Request: python-openid-cla - CLA extension for python-openid
https://bugzilla.redhat.com/show_bug.cgi?id=969703 Ricky Elrod rel...@redhat.com changed: What|Removed |Added CC||rel...@redhat.com Assignee|nob...@fedoraproject.org|rel...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Vx3CBI6iD7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969703] Review Request: python-openid-cla - CLA extension for python-openid
https://bugzilla.redhat.com/show_bug.cgi?id=969703
Ricky Elrod rel...@redhat.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #3 from Ricky Elrod rel...@redhat.com ---
Looks good to me. Consider being a bit more specific in your %files section,
but this is a non-blocker.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
BSD (3 clause), Unknown or generated. 1 files have unknown license.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 1 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that
[Bug 969703] Review Request: python-openid-cla - CLA extension for python-openid
https://bugzilla.redhat.com/show_bug.cgi?id=969703 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added Status|NEW |POST Flags||fedora-cvs? --- Comment #4 from Patrick Uiterwijk puiterw...@gmail.com --- New Package SCM Request === Package Name: python-openid-cla Short Description: CLA extension for python-openid Owners: puiterwijk Branches: F18 F19 EL6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TtO4Q8whgca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
