[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #12 from Christopher Meng cicku...@gmail.com --- Package Change Request == Package Name: hg-git New Branches: epel7 Owners: cicku -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|hg-git-0.4.0-1.fc19 |hg-git-0.4.0-1.el6 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- hg-git-0.4.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3Vthuxkt6sa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||hg-git-0.4.0-1.fc18 Resolution|--- |ERRATA Last Closed||2013-06-16 01:42:27 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- hg-git-0.4.0-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Q6kRJMJy36a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|hg-git-0.4.0-1.fc18 |hg-git-0.4.0-1.fc19 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- hg-git-0.4.0-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=A4FOo6KZyna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9WQfVS655Ja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- hg-git-0.4.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/hg-git-0.4.0-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EJ4uJzWBZXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- hg-git-0.4.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/hg-git-0.4.0-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zoH4Q03hmsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- hg-git-0.4.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/hg-git-0.4.0-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=E9x8wzIEK2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- hg-git-0.4.0-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ffW21m3usma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812
Douglas Schilling Landgraf dougsl...@redhat.com changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #1 from Douglas Schilling Landgraf dougsl...@redhat.com ---
[OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review
Rpmlint
---
Checking: hg-git-0.4.0-1.fc18.noarch.rpm
hg-git.noarch: W: spelling-error %description -l en_US changesets - change
sets, change-sets, changeless
hg-git.noarch: W: spelling-error %description -l en_US losslessly -
colorlessly, bloodlessly, sleeplessly
hg-git.noarch: W: spelling-error %description -l en_US changeset - change set,
change-set, changeless
hg-git.noarch: E: incorrect-fsf-address /usr/share/doc/hg-git-0.4.0/COPYING
1 packages and 0 specfiles checked; 1 errors, 3 warnings.
Rpmlint (installed packages)
# rpmlint hg-git
hg-git.noarch: W: spelling-error %description -l en_US changesets - change
sets, change-sets, changeless
hg-git.noarch: W: spelling-error %description -l en_US losslessly -
colorlessly, bloodlessly, sleeplessly
hg-git.noarch: W: spelling-error %description -l en_US changeset - change set,
change-set, changeless
hg-git.noarch: E: incorrect-fsf-address /usr/share/doc/hg-git-0.4.0/COPYING
1 packages and 0 specfiles checked; 1 errors, 3 warnings.
Please see my suggestion later.
[OK] MUST: The package must be named according to the Package Naming Guidelines
[OK] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[OK] MUST: The package must meet the Packaging Guidelines
[OK] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines
[OK] MUST: The License field in the package spec file must match the actual
license
[OK] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[OK] MUST: The spec file must be written in American English.
[OK] MUST: The spec file for the package MUST be legible.
[OK] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use sha256sum for this
task as it is used by the sources file once imported into git. If no upstream
URL can be specified for this package, please see the Source URL Guidelines for
how to deal with this.
CHECKSUM(SHA256) this package :
e82e28805d5e22eb8c7501282ddf9083499f7edf8977c86deaf7557d6f58b40a
CHECKSUM(SHA256) upstream package :
e82e28805d5e22eb8c7501282ddf9083499f7edf8977c86deaf7557d6f58b40a
[OK] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture
[OK] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[OK] MUST: Packages must NOT bundle copies of system libraries.
[OK] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[OK] MUST: Permissions on files must be set properly.
[OK] MUST: Each package must consistently use macros.
[OK] MUST: The package must contain code, or permissable content.
[OK] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present
[OK] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[OK] MUST: All filenames in rpm packages must be valid UTF-8.
[OK] MUST: Package contains BR: python2-devel or python3-devel
[OK] MUST: Binary eggs must be removed in %prep
[OK] SHOULD: Packager, Vendor, PreReq, Copyright tags should not be in spec
file
[OK] SHOULD: Sources can be downloaded from URI in Source: tag
[OK] SHOULD: Reviewer should test that the package builds in mock.
[OK] SHOULD: Buildroot is not present
[OK] SHOULD: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[OK] SHOULD: Dist tag is present.
[OK] SHOULD: No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[OK] SHOULD: SourceX tarball generation or download is documented.
[OK] SHOULD: SourceX is a working URL.
[OK] SHOULD: Spec use %global instead of %define.
[OK] SHOULD: Package functions as described.
[OK] SHOULD: Latest version is packaged.
Suggestion
=
Please work with upstream to update the COPYING file with the new FSF address.
hg-git.noarch: E: incorrect-fsf-address
[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Christopher Meng cicku...@gmail.com --- New Package SCM Request === Package Name: hg-git Short Description: Mercurial Plugin for Communicating with Git Servers Owners: cicku Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=F17cpHczvNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tN0LJ0dsDQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KAYNggXF7ra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||johnhf...@gmail.com --- Comment #4 from Christopher Meng cicku...@gmail.com --- *** Bug 690726 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Hgju0t9LOVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969812] Review Request: hg-git - Mercurial Plugin for Communicating with Git Servers
https://bugzilla.redhat.com/show_bug.cgi?id=969812 Douglas Schilling Landgraf dougsl...@redhat.com changed: What|Removed |Added CC||dougsl...@redhat.com Assignee|nob...@fedoraproject.org|dougsl...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=73jmzcaWGpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
