[Bug 969850] Review Request: python-rosdistro - File format for managing ROS Distributions
https://bugzilla.redhat.com/show_bug.cgi?id=969850 Rich Mattes changed: What|Removed |Added Depends On||969848 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zN96qAwmFf&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969850] Review Request: python-rosdistro - File format for managing ROS Distributions
https://bugzilla.redhat.com/show_bug.cgi?id=969850 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED CC||mario.blaetterm...@gmail.co ||m Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? --- Comment #1 from Mario Blättermann --- python-devel is deprecated, use python2-devel instead: https://fedoraproject.org/wiki/Packaging:Python#BuildRequires The initial cleaning of $RPM_BUILD_ROOT in %install is no longer needed, rpm does it automatically. Scratch build for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=5476691 $ rpmlint -i -v *python-rosdistro.src: I: checking python-rosdistro.src: W: spelling-error %description -l en_US vcs -> vs, cs, vacs The value of this tag appears to be misspelled. Please double-check. python-rosdistro.src: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish The value of this tag appears to be misspelled. Please double-check. python-rosdistro.src: I: checking-url http://www.ros.org/wiki/rosdistro (timeout 10 seconds) python-rosdistro.src: I: checking-url https://github.com/ros-infrastructure/rosdistro/archive/6e835511a8051c341397b6a1b5e4a4b2cc9eb0f6/rosdistro-0.2.8-6e83551.tar.gz (timeout 10 seconds) python-rosdistro.noarch: I: checking python-rosdistro.noarch: W: spelling-error %description -l en_US vcs -> vs, cs, vacs The value of this tag appears to be misspelled. Please double-check. python-rosdistro.noarch: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish The value of this tag appears to be misspelled. Please double-check. python-rosdistro.noarch: I: checking-url http://www.ros.org/wiki/rosdistro (timeout 10 seconds) python-rosdistro.noarch: W: no-manual-page-for-binary rosdistro_reformat Each executable in standard binary directories should have a man page. python-rosdistro.noarch: W: no-manual-page-for-binary rosdistro_build_cache Each executable in standard binary directories should have a man page. python-rosdistro.spec: I: checking-url https://github.com/ros-infrastructure/rosdistro/archive/6e835511a8051c341397b6a1b5e4a4b2cc9eb0f6/rosdistro-0.2.8-6e83551.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 6 warnings. rpmlint is quite silent, in terms of recognizable warnings or errors. Missing mapages, would be nice to have but it is not up to you to write them. Ignorable spelling errors. Fix the mentioned issues, and your package is ready for the final review and approval. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vEOjfGv6wf&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969850] Review Request: python-rosdistro - File format for managing ROS Distributions
https://bugzilla.redhat.com/show_bug.cgi?id=969850 --- Comment #2 from Rich Mattes --- Thanks Mario! Updated package and spec at: Spec URL: http://rmattes.fedorapeople.org/RPMS/rosdistro/python-rosdistro.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/rosdistro/python-rosdistro-0.2.8-2.20130602git6e83551.fc19.src.rpm I fixed the BuildRequires for python2-devel and removed the "rm RPM_BUILD_ROOT" at the beginning of %install. I also fixed the rpmlint typos by expanding "vcs" to version control system, and by capitalizing Github. rpmlint $ rpmlint python-rosdistro.spec ../RPMS/noarch/python-rosdistro* python-rosdistro.noarch: W: no-manual-page-for-binary rosdistro_reformat python-rosdistro.noarch: W: no-manual-page-for-binary rosdistro_build_cache 1 packages and 1 specfiles checked; 0 errors, 2 warnings. rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5477821 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OfgwhiM7RI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969850] Review Request: python-rosdistro - File format for managing ROS Distributions
https://bugzilla.redhat.com/show_bug.cgi?id=969850
Mario Blättermann changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #3 from Mario Blättermann ---
$ rpmlint -i -v *
python-rosdistro.src: I: checking
python-rosdistro.src: I: checking-url http://www.ros.org/wiki/rosdistro
(timeout 10 seconds)
python-rosdistro.src: I: checking-url
https://github.com/ros-infrastructure/rosdistro/archive/6e835511a8051c341397b6a1b5e4a4b2cc9eb0f6/rosdistro-0.2.8-6e83551.tar.gz
(timeout 10 seconds)
python-rosdistro.noarch: I: checking
python-rosdistro.noarch: I: checking-url http://www.ros.org/wiki/rosdistro
(timeout 10 seconds)
python-rosdistro.noarch: W: no-manual-page-for-binary rosdistro_reformat
Each executable in standard binary directories should have a man page.
python-rosdistro.noarch: W: no-manual-page-for-binary rosdistro_build_cache
Each executable in standard binary directories should have a man page.
python-rosdistro.spec: I: checking-url
https://github.com/ros-infrastructure/rosdistro/archive/6e835511a8051c341397b6a1b5e4a4b2cc9eb0f6/rosdistro-0.2.8-6e83551.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
BSD and MIT
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
aa2107826c75edc43bc2779a3a91e55e3b05456d78718973ad4b30799f6d66e9
rosdistro-0.2.8-6e83551.tar.gz
aa2107826c75edc43bc2779a3a91e55e3b05456d78718973ad4b30799f6d66e9
rosdistro-0.2.8-6e83551.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc su
[Bug 969850] Review Request: python-rosdistro - File format for managing ROS Distributions
https://bugzilla.redhat.com/show_bug.cgi?id=969850 Rich Mattes changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Rich Mattes --- New Package SCM Request === Package Name: python-rosdistro Short Description: File format for managing ROS Distributions Owners: rmattes Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hF7r3sHTk3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969850] Review Request: python-rosdistro - File format for managing ROS Distributions
https://bugzilla.redhat.com/show_bug.cgi?id=969850 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PxRn1up09a&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969850] Review Request: python-rosdistro - File format for managing ROS Distributions
https://bugzilla.redhat.com/show_bug.cgi?id=969850 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LrcT5e00BP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969850] Review Request: python-rosdistro - File format for managing ROS Distributions
https://bugzilla.redhat.com/show_bug.cgi?id=969850 Bug 969850 depends on bug 969848, which changed state. Bug 969848 Summary: Review Request: python-catkin-sphinx - Sphinx plugins for Catkin projects https://bugzilla.redhat.com/show_bug.cgi?id=969848 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6GHi329wqr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969850] Review Request: python-rosdistro - File format for managing ROS Distributions
https://bugzilla.redhat.com/show_bug.cgi?id=969850 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CvOMfATmOt&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969850] Review Request: python-rosdistro - File format for managing ROS Distributions
https://bugzilla.redhat.com/show_bug.cgi?id=969850 --- Comment #6 from Fedora Update System --- python-rosdistro-0.2.8-2.20130602git6e83551.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-rosdistro-0.2.8-2.20130602git6e83551.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pGxrH7z9IQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969850] Review Request: python-rosdistro - File format for managing ROS Distributions
https://bugzilla.redhat.com/show_bug.cgi?id=969850 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- python-rosdistro-0.2.8-2.20130602git6e83551.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v1xr0Buoe5&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969850] Review Request: python-rosdistro - File format for managing ROS Distributions
https://bugzilla.redhat.com/show_bug.cgi?id=969850 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-rosdistro-0.2.8-2.20 ||130602git6e83551.fc19 Resolution|--- |ERRATA Last Closed||2013-06-29 14:46:41 --- Comment #8 from Fedora Update System --- python-rosdistro-0.2.8-2.20130602git6e83551.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JK8B1kPYuX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
