[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 Bug 972477 depends on bug 973822, which changed state. Bug 973822 Summary: siege: Bundled Library https://bugzilla.redhat.com/show_bug.cgi?id=973822 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-07-19 09:14:32 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Hyj4Ks69Yha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 Bug 972477 depends on bug 977367, which changed state. Bug 977367 Summary: Review Request: libjoedog - Repack of the common code base of fido and siege as shared library https://bugzilla.redhat.com/show_bug.cgi?id=977367 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NjgIslZzKfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 --- Comment #25 from Fedora Update System upda...@fedoraproject.org --- libjoedog-0.1.1-4.el5, fido-1.0.7-6.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wxFqzsqGAYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 --- Comment #26 from Fedora Update System upda...@fedoraproject.org --- libjoedog-0.1.1-4.el6, fido-1.0.7-6.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eYnrDwe7YXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 --- Comment #24 from Fedora Update System upda...@fedoraproject.org --- libjoedog-0.1.1-4.fc18, fido-1.0.7-6.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kMCPRH9yNGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 --- Comment #23 from Fedora Update System upda...@fedoraproject.org --- libjoedog-0.1.1-4.fc19, fido-1.0.7-6.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rUDcfMOoHWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- libjoedog-0.1.1-4.fc19,fido-1.0.7-6.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/libjoedog-0.1.1-4.fc19,fido-1.0.7-6.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iB7DWC4By8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7XArpFdrHla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- libjoedog-0.1.1-4.fc18,fido-1.0.7-6.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libjoedog-0.1.1-4.fc18,fido-1.0.7-6.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Lb2sEQvepha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- libjoedog-0.1.1-4.el6,fido-1.0.7-6.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libjoedog-0.1.1-4.el6,fido-1.0.7-6.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Vi62dhcq96a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 --- Comment #22 from Fedora Update System upda...@fedoraproject.org --- libjoedog-0.1.1-4.el5,fido-1.0.7-6.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/libjoedog-0.1.1-4.el5,fido-1.0.7-6.el5 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eKGKfYn8IBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 --- Comment #18 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wMbdQRvCpca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KdVbavQJ4Ba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 Roman Mohr ro...@fenkhuber.at changed: What|Removed |Added Depends On||977367 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8lYS8gqqnpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 --- Comment #13 from Roman Mohr ro...@fenkhuber.at --- SRPM URL: http://rfenkhuber.fedorapeople.org/fido/fido-1.0.7-4.fc20.src.rpm Spec URL: http://rfenkhuber.fedorapeople.org/fido/fido.spec -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=98QvZ4bSo7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477
Björn Esser bjoern.es...@gmail.com changed:
What|Removed |Added
Attachment #759803|0 |1
is obsolete||
--- Comment #14 from Björn Esser bjoern.es...@gmail.com ---
Created attachment 764779
-- https://bugzilla.redhat.com/attachment.cgi?id=764779action=edit
improved spec-file
Package looks fine, except minor issues inside spec:
* BRs in spec-file should be rearranged/trimmed:
%if 0%{?fedora} || 0%{?rhel} = 7
BuildRequires:systemd
%systemd_requires
%else
Requires(post): /sbin/chkconfig
Requires(preun): /sbin/chkconfig
Requires(preun): initscripts
%endif
BuildRequires: libtool, libjoedog-devel
* no need for explicit requires
remove Requires: libjoedog
* Summary should not start with article
Summary:Multi-threaded file watch utility
* License-tag is incorrect:
License:GPLv2+ and LGPLv2+
#
hardening-check looks good:
fido-1.0.7-4.fc20.x86_64.rpm/usr/sbin/fido:
Position Independent Executable: yes
Stack protected: yes
Fortify Source functions: yes (some protected functions found)
unprotected: gethostname
unprotected: memset
unprotected: snprintf
unprotected: strcat
unprotected: fgets
unprotected: memmove
unprotected: read
unprotected: memcpy
protected: strncpy
protected: snprintf
protected: vsprintf
protected: memcpy
protected: printf
protected: fprintf
protected: sprintf
protected: syslog
Read-only relocations: yes
Immediate binding: yes
#
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v2.1 or later), GPL (v2 or later), LGPL (v2 or later) (with
incorrect FSF address), Unknown or generated. 23 files have unknown
license. Detailed output of licensecheck in
/home/bjoern.esser/fedora/review/972477-fido/licensecheck.txt
--- 's!License:GPLv2+! and LGPLv2+!'
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 40960 bytes in 6 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=G1psFMYeECa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 --- Comment #15 from Roman Mohr ro...@fenkhuber.at --- Björn thank you for the patch and the review. Here the new files: SRPM URL: http://rfenkhuber.fedorapeople.org/fido/fido-1.0.7-5.fc20.src.rpm Spec URL: http://rfenkhuber.fedorapeople.org/fido/fido.spec -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sv8jf031Xja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #16 from Björn Esser bjoern.es...@gmail.com --- Package is fine now! differing sha256-hash is because upstream's webserver doesn't provide a timestamp... APPROVED! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lNAsjoZlFWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 Roman Mohr ro...@fenkhuber.at changed: What|Removed |Added Flags||fedora-cvs? --- Comment #17 from Roman Mohr ro...@fenkhuber.at --- New Package SCM Request === Package Name: fido Short Description: Multi-threaded file watch utility Owners: rfenkhuber besser82 cdamian Branches: f18 f19 el5 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t8O4oql7Lka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Keywords||Upstream Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|bjoern.es...@gmail.com Whiteboard||NotReady Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pqv5IAvYoRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477
--- Comment #9 from Björn Esser bjoern.es...@gmail.com ---
(In reply to Björn Esser from comment #8)
[!]: %build honors applicable compiler flags or justifies otherwise.
--- {C,LD}FLAGS possibly ignored by Makefile; GOT is still writeable
caused by partial RELRO, complete RELRO needs
`-Wl,-z,relro,-z,now`
doesn't build PIE, although %global _hardened_build 1 is in spec
`hardening-check --verbose fido`
fido:
Position Independent Executable: no, normal executable!
...
Immediate binding: no, not found!
see attached build.log
Upstream's way to build the binary is the key to this: Makefile compiles a
STATIC-lib and links this into the sbin-exec, which makes real, useful
hardening impossible. Static libs can't be build as PIE and linked with
-z,now, afaik.
You should work out a way, with upstream, avoiding this static-lib during
build; either it should build a shlib and link this or just building the
sbin-exec from all single objects.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=yJpQsHUxGna=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 --- Comment #10 from Terje Røsten terje...@phys.ntnu.no --- Some of the functions on lib/ are simple/unneeded(?), building a static lib for these seems like overkill. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2zCS41Y7cQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477
--- Comment #11 from Roman Mohr ro...@fenkhuber.at ---
(In reply to Björn Esser from comment #9)
(In reply to Björn Esser from comment #8)
[!]: %build honors applicable compiler flags or justifies otherwise.
--- {C,LD}FLAGS possibly ignored by Makefile; GOT is still writeable
caused by partial RELRO, complete RELRO needs
`-Wl,-z,relro,-z,now`
doesn't build PIE, although %global _hardened_build 1 is in spec
`hardening-check --verbose fido`
fido:
Position Independent Executable: no, normal executable!
...
Immediate binding: no, not found!
see attached build.log
Upstream's way to build the binary is the key to this: Makefile compiles a
STATIC-lib and links this into the sbin-exec, which makes real, useful
hardening impossible. Static libs can't be build as PIE and linked with
-z,now, afaik.
You should work out a way, with upstream, avoiding this static-lib during
build; either it should build a shlib and link this or just building the
sbin-exec from all single objects.
I just discovered a few minutes ago, that siege (also from the same author)
which is already in fedora also includes lib/joedog.
(In reply to Terje Røsten from comment #10)
Some of the functions on lib/ are simple/unneeded(?), building a static lib
for these seems like overkill.
Yes most of these functions are just convenience wrappers of the author, but I
think I have no choice, as the library is also in another package and I already
found critical bugs in there.
(In reply to Björn Esser from comment #8)
[?]: Package complies to the Packaging Guidelines
--- needs check for bundled libs, esp. files with license differing
from upstream
The library is in all of the GPLv2 projects of the author. I have checked them,
they have all the same license in the header.
So I think the cleanest solution is, that I contact the author and the
maintainer of siege and we will create a separate package for the library, what
do you think?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=1d78RdIpZ7a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 --- Comment #12 from Björn Esser bjoern.es...@gmail.com --- (In reply to Roman Mohr from comment #11) I just discovered a few minutes ago, that siege (also from the same author) which is already in fedora also includes lib/joedog. ... The library is in all of the GPLv2 projects of the author. I have checked them, they have all the same license in the header. So I think the cleanest solution is, that I contact the author and the maintainer of siege and we will create a separate package for the library, what do you think? Hello Roman! Nice work! For siege you should follow the instructions from the wiki: https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#When_a_Bundled_Library_is_Discovered_Post-Review Yes, you should contact upstream and (if you want to) work with him on shipping a shared lib.so seperated from his other sources. Cheers, Björn -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0iThVYkWo4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 Roman Mohr ro...@fenkhuber.at changed: What|Removed |Added Depends On||973822 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Y2M9kWFA5ya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477
--- Comment #8 from Björn Esser bjoern.es...@gmail.com ---
Created attachment 759803
-- https://bugzilla.redhat.com/attachment.cgi?id=759803action=edit
build.log - no hardening
* INFORMAL REVIEW-REPORT *
* I am NOT a sponsor *
Package has some issues, some points are not checked, see report
#
Package Review
==
Legend:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: %build honors applicable compiler flags or justifies otherwise.
--- {C,LD}FLAGS possibly ignored by Makefile; GOT is still writeable
caused by partial RELRO, complete RELRO needs `-Wl,-z,relro,-z,now`
doesn't build PIE, although %global _hardened_build 1 is in spec
`hardening-check --verbose fido`
fido:
Position Independent Executable: no, normal executable!
Stack protected: yes
Fortify Source functions: yes (some protected functions found)
unprotected: gethostname
unprotected: memset
unprotected: snprintf
unprotected: strcat
unprotected: fgets
unprotected: memmove
unprotected: read
unprotected: memcpy
protected: strncpy
protected: memset
protected: snprintf
protected: vsprintf
protected: memcpy
protected: printf
protected: fprintf
protected: sprintf
protected: syslog
Read-only relocations: yes
Immediate binding: no, not found!
see attached build.log
[?]: Package contains no bundled libraries without FPC exception.
--- possibly bundled libs in files with license differing from upstream
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[?]: Package complies to the Packaging Guidelines
--- needs check for bundled libs, esp. files with license differing
from upstream
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v2.1 or later), LGPL (v2 or later), GPL (v2 or later), LGPL
(v2 or later) (with incorrect FSF address), Unknown or generated. 26
files have unknown license. Detailed output of licensecheck in
/home/bjoern.esser/fedora/review/review-fido/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 40960 bytes in 6 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #4 from Christopher Meng cicku...@gmail.com --- I think no need for rm -rf $RPM_BUILD_ROOT And just a note, your spec contains too much blanks... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4eMXW7PDpla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477
Volker Fröhlich volke...@gmx.at changed:
What|Removed |Added
CC||volke...@gmx.at
--- Comment #5 from Volker Fröhlich volke...@gmx.at ---
Don't label manpages as documentation. Just install the uncompressed versions
in the install section and rpmbuild will take care of the rest. Also make it
fido.1* in the files section.
Don't install COPYING and README manually. Use the doc macro instead:
%doc README COPYING. Remove %doc %{_defaultdocdir}/%{name}-%{version}/ then.
Drop the rm -rf, as Christopher said.
I suggest to not use the version macro for patches. If you package a newer
version, you'd have to rename all the patches, though they might still apply.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=HmD3wKRjcna=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 --- Comment #6 from Volker Fröhlich volke...@gmx.at --- Please also provide URLs that work with wget and fedora-review (which probably uses wget too). Always state URLs for spec file and SRPM! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1DkpxFFTTpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477
Terje Røsten terje...@phys.ntnu.no changed:
What|Removed |Added
CC||terje...@phys.ntnu.no
--- Comment #7 from Terje Røsten terje...@phys.ntnu.no ---
- Don't mix $RPM_BUILD_ROOT and %{buildroot}
- These
mkdir -p %{buildroot}%{_unitdir}
cp -p fido.service %{buildroot}%{_unitdir}
could be one line:
install -D -p -m 0644 fido.service %{buildroot}%{_unitdir}/fido.service
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=fl2ruccbrOa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 Roman Mohr ro...@fenkhuber.at changed: What|Removed |Added Version|rawhide |18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=p1pVHSB1IAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 --- Comment #1 from Antonio Trande anto.tra...@gmail.com --- Hi Roman. This is my first package and I am seeking a sponsor. Please, add FE-NEEDSPONSOR (Bugzilla id:177841) as Blocks and provide direct links to spec and srpm files. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6tZPnXSJMGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added CC||bjoern.es...@gmail.com Version|18 |rawhide Depends On||177841 (FE-NEEDSPONSOR) --- Comment #2 from Björn Esser bjoern.es...@gmail.com --- Hello Roman! Version must always be rawhide, since you want to bring in a completely new package to fedora, setting specific release-version is for bug-reporting against existing pkgs, only. If you want you can `backport` to earlier releases after approval, see: http://fedoraproject.org/wiki/Package_SCM_admin_requests Since I'm not a sponsor, unfortunatly, I can't do an official review, but I'll do an informal one helping you squashing out any possible issues with your pkg. I'll drop you a PM later. (In reply to Antonio Trande from comment #1) Please, add FE-NEEDSPONSOR (Bugzilla id:177841) as Blocks and provide direct links to spec and srpm files. Added `Blocks: FE-NEEDSPONSOR`. Links are fine and lead to direct download. Cheers, Björn -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t4IXS0Sme5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Depends On|177841 (FE-NEEDSPONSOR) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NPy0p5MagSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972477] Review Request: fido - A multi-threaded file watch utility
https://bugzilla.redhat.com/show_bug.cgi?id=972477 --- Comment #3 from Roman Mohr ro...@fenkhuber.at --- Hi Björn and Antonio, thank you for your comments and your help. Here are the links for rawhire: koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=5485459 SRPM URL: http://cloud.evelyn-mohr.at/public.php?service=filest=2f4435f5871bcfddc8de109e19ab7b32downloadpath=/fido-1.0.7-2.fc20.src.rpm Cheers, Roman -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Gtbw447Yy0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
