[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 T.C. Hollingsworth changed: What|Removed |Added Depends On|857992 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=857992 [Bug 857992] Review Request: JQuery - Fast, concise library that simplifies how you use JavaScript -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 T.C. Hollingsworth changed: What|Removed |Added Depends On||1078371 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1078371 [Bug 1078371] Review Request: js-jquery1 - JavaScript DOM manipulation, event handling, and AJAX library - for legacy browsers -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Bug 974725 depends on bug 857992, which changed state. Bug 857992 Summary: Review Request: JQuery - Fast, concise library that simplifies how you use JavaScript https://bugzilla.redhat.com/show_bug.cgi?id=857992 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #5 from Jens Petersen --- How about remove jquery from now from the package until it is packaged? This is need for updating hledger which currently blocks ghc-7.8. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen changed: What|Removed |Added CC||maths...@gmail.com Flags||needinfo?(maths...@gmail.co ||m) -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen changed: What|Removed |Added Whiteboard||NotReady -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived `Show` instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen changed: What|Removed |Added Whiteboard||Ready -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T82bhzhJNv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen changed: What|Removed |Added Summary|Review Request: |Review Request: |ghc-pretty-show - Tools for |ghc-pretty-show - Tools for |working with derived `Show` |working with derived Show |instances and generic |instances and generic |inspection of values|inspection of values -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BHbRNjqxQg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|peter...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ccGdKnldxu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen changed: What|Removed |Added Whiteboard|Ready | --- Comment #1 from Jens Petersen --- Build fails http://koji.fedoraproject.org/koji/taskinfo?taskID=5892410 due to unpackaged files: /usr/share/pretty-show-1.5/style/jquery.js /usr/share/pretty-show-1.5/style/pretty-show.css /usr/share/pretty-show-1.5/style/pretty-show.js -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4HJ77TPZIG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Ben Boeckel changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #2 from Ben Boeckel --- (In reply to Jens Petersen from comment #1) >/usr/share/pretty-show-1.5/style/jquery.js >/usr/share/pretty-show-1.5/style/pretty-show.css >/usr/share/pretty-show-1.5/style/pretty-show.js I guess we'll have to see about using a system jQuery? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6ogfmZVRho&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen changed: What|Removed |Added CC||package-review@lists.fedora ||project.org --- Comment #3 from Jens Petersen --- Right good point which I forgot to mention indeed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Jj4S7hTPBg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #4 from Jens Petersen --- But jquery is not packaged yet it seems: bug 857992. So perhaps it could be waived for now. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0bZKdp6bko&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Depends On||857992 (jquery) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=857992 [Bug 857992] Review Request: JQuery - Fast, concise library that simplifies how you use JavaScript -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived `Show` instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Ben Boeckel changed: What|Removed |Added CC||haskell-devel@lists.fedorap ||roject.org Blocks||827975 Depends On||974724 (ghc-haskell-lexer) Alias||ghc-pretty-show -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vCC6cNFMax&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #15 from Ben Boeckel --- Spec URL: http://benboeckel.net/packaging/ghc-pretty-show/ghc-pretty-show.spec SRPM URL: http://benboeckel.net/packaging/ghc-pretty-show/ghc-pretty-show-1.6.8.2-1.fc24.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725
--- Comment #16 from Jens Petersen ---
You forgot to upload the new spec file, which confuses fedora-review.
You have an extra copy of LICENSE in %doc: please drop that when importing.
For that you need to add "rm %{buildroot}%{ghc_pkgdocdir}/LICENSE"
unfortunately. (Ideally --licensedir support should be added to Cabal.)
Otherwise it looks good to me now.
APPROVED
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #17 from Ben Boeckel --- Hrm. The upload is done by a script. I'll have to look into why it is acting weird. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #18 from Ben Boeckel --- Hmm. It seems I have uploaded the new spec file? The srpm should be there as well? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #19 from Jens Petersen --- http://benboeckel.net/packaging/ghc-pretty-show/ghc-pretty-show.spec is version 1.5! Anyway please go ahead with the SCM request... :) -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Ben Boeckel changed: What|Removed |Added Flags||fedora-cvs? --- Comment #20 from Ben Boeckel --- Oops. I wonder if the glob messed from the upload script or something? New Package SCM Request === Package Name: ghc-pretty-show Short Description: Tools for working with derived Show instances and generic inspection of values Upstream URL: https://hackage.haskell.org/package/pretty-show Owners: mathstuf Branches: devel InitialCC: haskell-devel -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #21 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||ghc-pretty-show-1.6.8.2-2.f ||c24 Resolution|--- |RAWHIDE Last Closed||2015-10-08 05:10:36 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Bug 974725 depends on bug 1078371, which changed state. Bug 1078371 Summary: Review Request: js-jquery1 - JavaScript DOM manipulation, event handling, and AJAX library - for legacy browsers https://bugzilla.redhat.com/show_bug.cgi?id=1078371 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Ben Boeckel changed: What|Removed |Added Blocks||1142913 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1142913 [Bug 1142913] ghc-hledger-lib-0.24 is available -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #7 from Ben Boeckel --- Spec URL: http://mathstuf.fedorapeople.org//ghc-pretty-show.spec SRPM URL: http://mathstuf.fedorapeople.org//ghc-pretty-show-1.6.8-1.fc23.src.rpm Scratch: ghc-pretty-show-1.6.8-1.fc23.src.rpm Scratch build is *slightly* different; just missing the Requires on js-jquery1 (which shouldn't affect the build). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Ben Boeckel changed: What|Removed |Added Flags|needinfo?(maths...@gmail.co | |m) | -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #8 from Jens Petersen --- Thanks for the update. The jquery approach looks good to me. I think jquery-src.js is not needed at runtime so you could probably drop that symlink. I know it is kind of nitpicking, it might be better to BR: js-jquery1 this would avoid some rpmlint warnings about dangling symlinks. Unfortunately there is a License mismatch: - the cabal file and src files says it is BSD(3) - the License file is MIT. I think we need to contact upstream. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725
--- Comment #9 from Jens Petersen ---
Other than above comments here is the fedora-review output:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 10 files have unknown license. Detailed output of
licensecheck in /home/jens/pkgreview/974725-ghc-pretty-
show/licensecheck.txt
Source is BSD but the license file is MIT.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
Haskell:
[x]: This should never happen
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #10 from Ben Boeckel --- Spec URL: http://mathstuf.fedorapeople.org//ghc-pretty-show.spec SRPM URL: http://mathstuf.fedorapeople.org//ghc-pretty-show-1.6.8.1-1.fc23.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen changed: What|Removed |Added Flags||fedora-review+ --- Comment #11 from Jens Petersen --- Thanks for updating. http://koji.fedoraproject.org/koji/taskinfo?taskID=9149372 1.6.8.2 was since released which corrects the license in the source files. So I recommend upgrading directly to it after importing (you can try "cblrpm update":). License issue mentioned earlier has been clarified and fixed to MIT. Looks good to me now. One last suggestion: replace "rm -rf" with just "rm". APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen changed: What|Removed |Added Whiteboard|NotReady| -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #12 from Jens Petersen --- I tried installing the package into rawhide and f21 to check also on the symlinks warning - seems to be a rpmlint bug afaict. However while checking that I noticed that the datadir packaging is not quite correct: in fact there is still a copy of jquery under style/... Let me attach a patch with a suggested fix to make it clearer. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #13 from Jens Petersen --- Created attachment 998655 --> https://bugzilla.redhat.com/attachment.cgi?id=998655&action=edit pretty-show-datadir-style.patch Please apply this patch to fix the jquery location when importing. Note that datadir is assumed to be /usr/share/pretty-show-version/ by the library using the Cabal config. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #14 from Jens Petersen --- Oh two more points occurred to me: - BR for jquery is actually redundant I think - It might be more stable to change the symlinks to jquery/1 rather than jquery/1.11? (I dunno how often jquery1 gets updated, but this would avoid needing a rebuild for 1.12, etc say.) -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #6 from Jens Petersen --- ping? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
