[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #60 from Fedora Update System --- pgmodeler-0.8.2-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-10-11 11:43:14 --- Comment #59 from Fedora Update System --- pgmodeler-0.8.2-4.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #58 from Fedora Update System --- pgmodeler-0.8.2-4.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b9e7cc8ffd -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #57 from Fedora Update System --- pgmodeler-0.8.2-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-16511f4864 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #56 from Sandro Mani --- If you do MinGW reviews, could you have a look at https://bugzilla.redhat.com/show_bug.cgi?id=1378807? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #55 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/pgmodeler -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #54 from Pavel Alexeev --- Thank you very much Sandro. Could I review something for you? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 Sandro Mani changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #53 from Sandro Mani --- Package approved. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #52 from Pavel Alexeev --- Add Requires shared-mime-info. hicolor-icon-theme already required. > - For F25+, various scriptlets should not be run according to [1]. For F23, > F24 update-mime-database needs to be invoked in %post. That already there: https://github.com/Hubbitus/Fedora-packaging/blob/master/SPECS/pgmodeler.spec#L81 Changes: https://github.com/Hubbitus/Fedora-packaging/commit/ca4684e8f693b037c20988337abfea9ffd8faf67 Spec: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/ca4684e8f693b037c20988337abfea9ffd8faf67/SPECS/pgmodeler.spec Srpm: http://rpm.hubbitus.info/Fedora24/pgmodeler/pgmodeler-0.8.2-4.fc24.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15723164 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116
--- Comment #51 from Sandro Mani ---
Issues:
- Missing requires for unowned directories:
/usr/share/mime/{,packages} -> shared-mime-info
- In my opinion better to also require hicolor-icon-theme and only own
%{_datadir}/icons/hicolor/256x256/apps/pgmodeler_logo.png
- Files listed twice: remove %{_libdir}/%{name}/lib*.so
- For F25+, various scriptlets should not be run according to [1]. For F23, F24
update-mime-database needs to be invoked in %post.
- The package should not provide the private libraries in %{_libdir}/%{name},
see [2]
[1]
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#desktop-database
[2] https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not contain duplicates in %files.
Note: warning: File listed twice: /usr/lib64/pgmodeler/libobjrenderer.so
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Reason for placing in main package justified.
[-]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL", "Unknown or generated", "*No copyright* GPL". 620 files
have unknown license.
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/mime,
/usr/share/mime/packages
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/icons/hicolor/256x256/apps(hicolor-icon-theme, fedora-
logos), /usr/share/icons/hicolor/256x256(hicolor-icon-theme, fedora-
logos), /usr/share/icons/hicolor(hicolor-icon-theme, fedora-logos)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in pgmodeler
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in pgmodeler
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 153600 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using des
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #50 from Pavel Alexeev --- As upstream build does not provide headers install in normal build I just drop devel sub-package. Changes: https://github.com/Hubbitus/Fedora-packaging/commit/5a77d3d9fd1dd331a5f700475c216502ddfe3d6f Spec: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/5a77d3d9fd1dd331a5f700475c216502ddfe3d6f/SPECS/pgmodeler.spec Srpm: http://rpm.hubbitus.info/Fedora24/pgmodeler/pgmodeler-0.8.2-3.fc24.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15584140 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #49 from Pavel Alexeev --- Hm. Good question. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #48 from Sandro Mani --- What's the use of the -devel package with no headers? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 Sandro Mani changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|manisan...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #47 from Sandro Mani --- I can review this next week - currently away from home/office with a terrible internet connection. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 Igor Gnatenko changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|ignate...@redhat.com|nob...@fedoraproject.org --- Comment #46 from Igor Gnatenko --- I want to review this, but I'm out of time.. Sorry for my late response. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #45 from Pavel Alexeev --- Changes: https://github.com/Hubbitus/Fedora-packaging/commit/792ee607b4292c235fed781577079a5c013f4b05 Spec: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/792ee607b4292c235fed781577079a5c013f4b05/SPECS/pgmodeler.spec Srpm: http://rpm.hubbitus.info/Fedora24/pgmodeler/pgmodeler-0.8.2-2.fc24.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #44 from Pavel Alexeev --- Igor ping? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #43 from Sandro Mani --- @Igor: are you taking this? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #42 from Pavel Alexeev --- Sorry guys for late response. I'm very interesting in this review. Igor thank you very much for taking it on review. Changes: https://github.com/Hubbitus/Fedora-packaging/commit/d0716a3d152c8d085988944bce7140b8e56f2e64 Spec: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/d0716a3d152c8d085988944bce7140b8e56f2e64/SPECS/pgmodeler.spec Srpm: http://rpm.hubbitus.info/Fedora24/pgmodeler/pgmodeler-0.8.2-1.fc24.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 Igor Gnatenko changed: What|Removed |Added Status|NEW |ASSIGNED CC||ignate...@redhat.com Assignee|nob...@fedoraproject.org|ignate...@redhat.com --- Comment #41 from Igor Gnatenko --- Please update to new version and I will review almost immediately ;) -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 Sandro Mani changed: What|Removed |Added CC||manisan...@gmail.com --- Comment #40 from Sandro Mani --- @Pavel: still interested in this? I'm happy to review. Can you update to the latest version? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 Pavel Alexeev changed: What|Removed |Added Status|ASSIGNED|NEW Flags|fedora-review? | --- Comment #39 from Pavel Alexeev --- Reviewer did not answer in months. Clear assignment. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 Pavel Alexeev changed: What|Removed |Added Assignee|i...@cicku.me |nob...@fedoraproject.org -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #38 from Pavel Alexeev --- Christopher do you plan continue review??? Months without answer! -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #37 from Pavel Alexeev --- Christopher QT bug resolved, so we can continue review. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #36 from Pavel Alexeev --- Fix complain on start about plugin folder: Changes: https://github.com/Hubbitus/Fedora-packaging/commit/edc41213facca2d701178a7de586a546cc355dfa Spec: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/edc41213facca2d701178a7de586a546cc355dfa/SPECS/pgmodeler.spec Srpm: http://rpm.hubbitus.info/Fedora23/pgmodeler/pgmodeler-0.8.2-0.2.beta.git.8d1e180.fc23.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #35 from Upstream Release Monitoring --- hubbitus's scratch build of pgmodeler-0.8.2-0.2.beta.git.8d1e180.fc23.src.rpm for f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12434408 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #34 from Pavel Alexeev --- New version: Changes: https://github.com/Hubbitus/Fedora-packaging/commit/53aa7d1c49b31a03bd2b2e102f078bcdb54758db Spec: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/53aa7d1c49b31a03bd2b2e102f078bcdb54758db/SPECS/pgmodeler.spec Srpm: http://rpm.hubbitus.info/Fedora23/pgmodeler/pgmodeler-0.8.2-0.beta.1.git.8d1e180.fc23.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 Pavel Alexeev changed: What|Removed |Added Depends On||1291003 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1291003 [Bug 1291003] qt-5.5 segfault on QFileDialog without parent -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #33 from Upstream Release Monitoring --- hubbitus's scratch build of pgmodeler-0.8.2-0.alpha.1.fc23.src.rpm for f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12004933 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #32 from Pavel Alexeev (aka Pahan-Hubbitus) --- Christopher, ping? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #31 from Pavel Alexeev (aka Pahan-Hubbitus) --- 0.8.1-alpha, AppData included. Changes: https://github.com/Hubbitus/Fedora-packaging/commit/17a50141a6fcce70d04a9570e1934294188b90f9 Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9420096 Spec: https://github.com/Hubbitus/Fedora-packaging/blob/17a50141a6fcce70d04a9570e1934294188b90f9/SPECS/pgmodeler.spec Srpm: http://rpm.hubbitus.info/Fedora21/pgmodeler/pgmodeler-0.8.1-0.alpha.1.fc21.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #30 from Pavel Alexeev (aka Pahan-Hubbitus) --- AppData requested - https://github.com/pgmodeler/pgmodeler/issues/622 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #29 from Pavel Alexeev (aka Pahan-Hubbitus) --- pgpmodeler - update to 0.8.0 - Updaate to 0.8.0 by request Edson Ferreira (#1) - Changed files layout. Big job has been done in pgmodeler/pgmodeler#559 so use qmake project files parameters and makefile variables instead of manual installation and various hacks. - Spec cleanup. - Fix mixed tab/space rpmlint warn. - Move LICENSE into %%license from %%doc - Include RELEASENOTES.md. Changes: https://github.com/Hubbitus/Fedora-packaging/commit/65a878f0c47e5ff469e7c8ffbad8780f9910f629 Spec: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/65a878f0c47e5ff469e7c8ffbad8780f9910f629/SPECS/pgmodeler.spec Srpm: http://hubbitus.info/rpm/Fedora21/pgmodeler/pgmodeler-0.8.0-1.fc21.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9131663 Spec now much more legible and easy for review. Christopher could we do it eventually please? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #28 from Pavel Alexeev (aka Pahan-Hubbitus) --- Changes: https://github.com/Hubbitus/Fedora-packaging/commit/062dad63a6cc75339f4acc405886abd8e26993e4 Spec: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/062dad63a6cc75339f4acc405886abd8e26993e4/SPECS/pgmodeler.spec Srpm: http://hubbitus.info/rpm/Fedora20/pgmodeler/pgmodeler-0.7.1-2.fc20.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6764223 Changelog: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 Itamar Reis Peixoto changed: What|Removed |Added CC||ita...@ispbrasil.com.br --- Comment #27 from Itamar Reis Peixoto --- only load for me running. LD_LIBRARY_PATH=/usr/lib64/pgmodeler pgmodeler -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #26 from Pavel Alexeev (aka Pahan-Hubbitus) --- Changes: https://github.com/Hubbitus/Fedora-packaging/commit/af8e5796cd3886ce7391d857b319c7b92fa68c66 Spec: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/af8e5796cd3886ce7391d857b319c7b92fa68c66/SPECS/pgmodeler.spec Srpm: http://hubbitus.info/rpm/Fedora20/pgmodeler/pgmodeler-0.7.1-1.fc20.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 Christopher Meng changed: What|Removed |Added Flags||fedora-review? --- Comment #25 from Christopher Meng --- Please update to 0.7.1, I will review it soon. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 Christopher Meng changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com Assignee|nob...@fedoraproject.org|cicku...@gmail.com -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #24 from Pavel Alexeev (aka Pahan-Hubbitus) --- Changes: https://github.com/Hubbitus/Fedora-packaging/commit/55152b915ee1cb22b3e29f417a7167e925822c9b Spec: https://raw.github.com/Hubbitus/Fedora-packaging/55152b915ee1cb22b3e29f417a7167e925822c9b/SPECS/pgmodeler.spec Srpm: http://hubbitus.info/rpm/Fedora20/pgmodeler/pgmodeler-0.7.0_pre-0.1.fc21.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6370904 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #23 from Christopher Meng --- 0.6.2 is ready. Use %_qt5_qmake. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #22 from Pavel Alexeev (aka Pahan-Hubbitus) --- Changes: https://github.com/Hubbitus/Fedora-packaging/commit/3699bc2d48c785974d18c9d09d74e8c2bda9f80b Spec: https://raw.github.com/Hubbitus/Fedora-packaging/3699bc2d48c785974d18c9d09d74e8c2bda9f80b/SPECS/pgmodeler.spec Srpm: http://hubbitus.info/rpm/Fedora19/pgmodeler/pgmodeler-0.6.0_alpha-0.3.git.ec8d48f.fc19.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6213424 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116
Pavel Alexeev (aka Pahan-Hubbitus) changed:
What|Removed |Added
CC|package-review@lists.fedora |
|project.org |
--- Comment #18 from Pavel Alexeev (aka Pahan-Hubbitus)
---
(In reply to Volker Fröhlich from comment #16)
> It seems like there's something going on with plug-ins. While two of them
> are installed, the are not visible on the plug-ins tab of "Settings". It
> might be connected to the existence of
>
> PGMODELER_PLUGIN_DIR
> and
> PGMODELER_PLUGINS_DIR
According to globalattributes.h:
PLUGINS_DIR=(getenv("PGMODELER_PLUGINS_DIR") ?
QString(getenv("PGMODELER_PLUGINS_DIR")).replace("\\","/") :
QString("./plugins")),
I correctly set PGMODELER_PLUGINS_DIR variable, not PGMODELER_PLUGIN_DIR.
And as one internal plugin and one dummy may be thay should not be listed in
gui?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=IKSyBtrKIr&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116
--- Comment #17 from Volker Fröhlich ---
(In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #8)
> (In reply to Volker Fröhlich from comment #6)
> > I'm not sure if everything that is below /etc really belongs there. I also
> > found an icon there, by the way.
> Logo, not icon. What you think appropriate path for it? /usr/share/pgmodeler
> I suppose? Most other files is *.conf and *.dtd which may be treated as conf
> correctly.
You can install the icons in %{_datadir}/pixmaps. Please also update the
desktop file according to preferred form described in
http://fedoraproject.org/wiki/Packaging:Guidelines#Icon_tag_in_Desktop_Files
From the desktop file: "Program with nice Qt interface for visual modeling
PostgreSQL database in terms on entity relationship model" -- I'm not a native
speaker, but that "on" doesn't sound right.
> I think you are by mistake speak about
> %{_sysconfdir}/profile.d/%{name}.bash? It is just used to set environment
> variables appropriately as theys used by application for function properly.
Yes, I was wrong there. Do we really need this profile? It's not like these
settings vary on a system-wide scope, as you defined them through packaging.
Are there no hard-coded defaults?
> >
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libutils.so.1.0.0 /lib64/libpq.so.5
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libutils.so.1.0.0 /lib64/libQtGui.so.4
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libutils.so.1.0.0 /lib64/libxml2.so.2
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libutils.so.1.0.0 /lib64/libXext.so.6
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libutils.so.1.0.0 /lib64/libX11.so.6
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libutils.so.1.0.0 /lib64/libm.so.6
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libpq.so.5
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libxml2.so.2
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libXext.so.6
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libX11.so.6
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libm.so.6
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libdbconnect.so.1.0.0 /lib64/libQtGui.so.4
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libdbconnect.so.1.0.0 /lib64/libxml2.so.2
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libdbconnect.so.1.0.0 /lib64/libXext.so.6
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libdbconnect.so.1.0.0 /lib64/libX11.so.6
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libdbconnect.so.1.0.0 /lib64/libm.so.6
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libobjrenderer.so.1.0.0 /lib64/libpq.so.5
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libobjrenderer.so.1.0.0 /lib64/libxml2.so.2
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libobjrenderer.so.1.0.0 /lib64/libXext.so.6
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libobjrenderer.so.1.0.0 /lib64/libX11.so.6
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libpq.so.5
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libxml2.so.2
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libXext.so.6
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libX11.so.6
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libparsers.so.1.0.0 /lib64/libpq.so.5
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libparsers.so.1.0.0 /lib64/libQtGui.so.4
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libparsers.so.1.0.0 /lib64/libpthread.so.0
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libparsers.so.1.0.0 /lib64/libXext.so.6
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libparsers.so.1.0.0 /lib64/libX11.so.6
> > pgmodeler.x86_64: W: unused-direct-shlib-dependency
> > /usr/lib64/libparsers.so.1.0.0 /lib64/libm.so.6
> >
> > There's some unnecessary linking going on. If these libraries are meant to
> > be used by other applications than that GUI, that should probably be
> > resolved.
> I don't known other usages.
That said, I wonder if all the libraries should go to /usr/lib64/pgmodeler
instead. Some names are a bit generic and we could drop the devel sub-package
an
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #16 from Volker Fröhlich --- It seems like there's something going on with plug-ins. While two of them are installed, the are not visible on the plug-ins tab of "Settings". It might be connected to the existence of PGMODELER_PLUGIN_DIR and PGMODELER_PLUGINS_DIR -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NmBxiYYdTg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #15 from Pavel Alexeev (aka Pahan-Hubbitus) --- Thanks. Should work now. Spec changes: https://github.com/Hubbitus/Fedora-packaging/commit/f5957b02069c3bcb1b00ffd014124fe0c95f5de2 Spec: https://raw.github.com/Hubbitus/Fedora-packaging/f5957b02069c3bcb1b00ffd014124fe0c95f5de2/SPECS/pgmodeler.spec Srpm: http://hubbitus.info/rpm/Fedora19/pgmodeler/pgmodeler-0.6.0_alpha-0.2.git.ec8d48f.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=a06QQ0GPbj&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #14 from Volker Fröhlich --- This one works for me on F18. I noticed a relevant error message though: - Open Pgmodeler, "File New" - Add some table and close the consecutive dialogue - Exit without saving "Unable to write the model in the file /etc/pgmodeler/pgmodeler.conf due to one or more errors in the definition generation process!" -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QUOoC4TqGy&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #13 from Pavel Alexeev (aka Pahan-Hubbitus) --- Please look at new version. - Repository moved to bitbucket.org. - Crashhandler naming issue resolved: https://bitbucket.org/pgmodeler/pgmodeler/issue/282/please-move-crashhandler-to-libexec-dir and suggested build from reveng-support 0.6.0-alpha branch. - BR qt-devel up to qt5-qtbase-devel. - Delete qt4-compatibility patches. - Add binaries wrapper and real binaries rename with -bin suffix to include environment variables for correct start. Changes: https://github.com/Hubbitus/Fedora-packaging/commit/21b3f0b3015af539844da6416d8dcd8789b343a1 https://github.com/Hubbitus/Fedora-packaging/commit/068cf200cff7cdf96007537950cd38c3bc8ef305 Spec: https://raw.github.com/Hubbitus/Fedora-packaging/97aa4133c6eead4479e2dca88102e4a1756662fd/SPECS/pgmodeler.spec Srpm: http://hubbitus.info/rpm/Fedora19/pgmodeler/pgmodeler-0.6.0_alpha-0.1.git.ec8d48f.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zAam0oH4x6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #12 from Volker Fröhlich --- Didn't work on F18, doesn't work on F19 either. Strace from F19: http://www.geofrogger.net/review/pgmodeler.strace -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3DnAzlwmGu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #11 from Pavel Alexeev (aka Pahan-Hubbitus) --- I run Fedora 19. Sure. Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=5634601 f19: http://koji.fedoraproject.org/koji/taskinfo?taskID=5634615 f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=5634627 Meantime chrashhandler renamed. I ask path customization key. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rOadX57T4s&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 Christopher Meng changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #10 from Christopher Meng --- What's your os version? Btw can you scratch a build for f19, f20? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hJKQPlOYLw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #9 from Pavel Alexeev (aka Pahan-Hubbitus) --- It starts on my machine. What troubles or errors you are experience? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EIGqYx4aTf&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116
--- Comment #8 from Pavel Alexeev (aka Pahan-Hubbitus) ---
(In reply to Volker Fröhlich from comment #6)
>I have no idea what that crashhandler binary does. It has no help, no man page
> and it doesn't say a lot anyway. I'd really consider prefixing the name or
> even
> removing it. It doesn't seem to be meant for standalone execution. I wonder if
> it should really be in bindir then.
It does what name speak: handle application crash if happened. It does not
intended to be called by user. I fully agree with you what prefixed name would
be much more appropriate or even other location.
Unfortunately that name hardcoded in src:
https://github.com/pgmodeler/pgmodeler/blob/master/main/src/main.cpp and I do
not willing patch. I have ask upstream about it:
https://github.com/pgmodeler/pgmodeler/issues/282
> Where's that "_r1" in the version from? Are you sure you want that as part of
> the version and not release?
From authors changelog:
https://github.com/pgmodeler/pgmodeler/blob/master/CHANGELOG.md
> The Qt patches are irrelevant for upstream or already included? I usually
> try to have a comment about the status in the spec file or the patch.
I treat it as "Fedora-specific" and did not send upstream. Comment "for current
Fedora releases" is not clear state it? It is just my fast backport attempt.
Pgmodeler developed to work with Qt5 which is not Fedora stable releases yet.
> I'm not sure if everything that is below /etc really belongs there. I also
> found an icon there, by the way.
Logo, not icon. What you think appropriate path for it? /usr/share/pgmodeler I
suppose? Most other files is *.conf and *.dtd which may be treated as conf
correctly.
> The bash completion script should be
> handled differently too
There no bash completions scripts.
I think you are by mistake speak about %{_sysconfdir}/profile.d/%{name}.bash?
It is just used to set environment variables appropriately as theys used by
application for function properly.
>
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libutils.so.1.0.0 /lib64/libpq.so.5
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libutils.so.1.0.0 /lib64/libQtGui.so.4
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libutils.so.1.0.0 /lib64/libxml2.so.2
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libutils.so.1.0.0 /lib64/libXext.so.6
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libutils.so.1.0.0 /lib64/libX11.so.6
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libutils.so.1.0.0 /lib64/libm.so.6
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libpq.so.5
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libxml2.so.2
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libXext.so.6
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libX11.so.6
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpgmodeler.so.1.0.0 /lib64/libm.so.6
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libdbconnect.so.1.0.0 /lib64/libQtGui.so.4
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libdbconnect.so.1.0.0 /lib64/libxml2.so.2
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libdbconnect.so.1.0.0 /lib64/libXext.so.6
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libdbconnect.so.1.0.0 /lib64/libX11.so.6
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libdbconnect.so.1.0.0 /lib64/libm.so.6
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libobjrenderer.so.1.0.0 /lib64/libpq.so.5
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libobjrenderer.so.1.0.0 /lib64/libxml2.so.2
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libobjrenderer.so.1.0.0 /lib64/libXext.so.6
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libobjrenderer.so.1.0.0 /lib64/libX11.so.6
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libpq.so.5
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libxml2.so.2
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libXext.so.6
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libX11.so.6
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libparsers.so.1.0.0 /lib64/libpq.so.5
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libparsers.so.1.0.0 /lib64/libQtGui.so.4
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libparsers.so.1.0.0 /lib64/libpthread.so.0
> pgmodeler.x86_64: W: unused-direct-shlib-dependency
> /usr
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #7 from Volker Fröhlich --- The GUI doesn't seem to start for me on F18. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=U9WVQ1ZUXQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116
--- Comment #6 from Volker Fröhlich ---
ls was not written to be parsed. I think that many people would consider it bad
practice, but I leave that up to you.
I have no idea what that crashhandler binary does. It has no help, no man page
and it doesn't say a lot anyway. I'd really consider prefixing the name or even
removing it. It doesn't seem to be meant for standalone execution. I wonder if
it should really be in bindir then.
pgmodeler-devel.x86_64: E: incorrect-fsf-address
/usr/include/pgmodeler/modeloverviewwidget.h
pgmodeler.x86_64: W: unstripped-binary-or-object
/usr/lib64/pgmodeler/plugins/libdummy.so
pgmodeler.x86_64: W: unstripped-binary-or-object
/usr/lib64/pgmodeler/plugins/libxml2object.so
Where's that "_r1" in the version from? Are you sure you want that as part of
the version and not release?
The Qt patches are irrelevant for upstream or already included? I usually try
to have a comment about the status in the spec file or the patch.
I'm not sure if everything that is below /etc really belongs there. I also
found an icon there, by the way. The bash completion script should be handled
differently too: Completion scripts are loaded on demand from bash-completion
1.99 on --
http://mm3test.fedoraproject.org/hyperkitty/list/de...@mm3test.fedoraproject.org/thread/4PV7CQUQ2POT52EDMRUKZUKR4PEQYEG6/
mkdir -p %{buildroot}%{completion_path}
mv %{buildroot}%{_sysconfdir}/bash_completion.d/pgmodeler-cli-completion.bash
%{buildroot}%{completion_path}/pgmodeler-cli
These commands are written under the assumption the completion is for the cli
binary. If that's worth anything standalone, I'd suggest to have a subpackage.
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libpq.so.5
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libQtGui.so.4
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libxml2.so.2
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libutils.so.1.0.0 /lib64/libm.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler.so.1.0.0 /lib64/libpq.so.5
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler.so.1.0.0 /lib64/libxml2.so.2
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler.so.1.0.0 /lib64/libm.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libdbconnect.so.1.0.0 /lib64/libQtGui.so.4
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libdbconnect.so.1.0.0 /lib64/libxml2.so.2
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libdbconnect.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libdbconnect.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libdbconnect.so.1.0.0 /lib64/libm.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libobjrenderer.so.1.0.0 /lib64/libpq.so.5
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libobjrenderer.so.1.0.0 /lib64/libxml2.so.2
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libobjrenderer.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libobjrenderer.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libpq.so.5
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libxml2.so.2
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libpgmodeler_ui.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libpq.so.5
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libQtGui.so.4
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libpthread.so.0
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libXext.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libX11.so.6
pgmodeler.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libparsers.so.1.0.0 /lib64/libm.so.6
There's some unnecessary linking going on. If these libraries are meant to be
used by other applications than that GUI, that should probably be resolved.
The locale script doesn'
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #5 from Pavel Alexeev (aka Pahan-Hubbitus) --- Hello Volker. >Is there no icon? I have not found file intended to be icon. But in .desktop file for that use pgmodeler_logo.png > Also try to get the desktop file upstream, if you haven't done so yet. https://github.com/pgmodeler/pgmodeler/issues/278 > I think you should rather use find than ls as a source to your loop. Sure. What it changes? Is there advantages for that particular case? > /usr/bin/crashhandler is a potentially problematic name. Sure. But at first glance via "repoquery --whatprovides /usr/bin/crashhandler" it is not used yet. > The locales aren't handled properly, see I have tried do that initially, but its does not found. Rpmbuild fails with error: $ /usr/lib/rpm/find-lang.sh /home/pasha/SOFT/rpmbuild/BUILDROOT/pgmodeler-0.5.1_r1-3.GITbe5b74a.fc19.x86_64 pgmodeler No translations found for pgmodeler in /home/pasha/SOFT/rpmbuild/BUILDROOT/pgmodeler-0.5.1_r1-3.GITbe5b74a.fc19.x86_64 Do you have ideas why? Other issues addressed, thank you for the comments. Spec: https://github.com/Hubbitus/Fedora-packaging/blob/f58ef89a618732e93c2b8adbd4c7f9629ea8109c/SPECS/pgmodeler.spec Spec changes: https://github.com/Hubbitus/Fedora-packaging/commit/f58ef89a618732e93c2b8adbd4c7f9629ea8109c Srpm: http://hubbitus.info/rpm/Fedora19/pgmodeler/pgmodeler-0.5.1_r1-3.GITbe5b74a.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RYLwFGOfJu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116
Volker Fröhlich changed:
What|Removed |Added
CC||volke...@gmx.at
--- Comment #4 from Volker Fröhlich ---
Don't use the vendor tag:
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
Is there no icon? Also try to get the desktop file upstream, if you haven't
done so yet.
You can use the name macro for the patch names.
I think you should rather use find than ls as a source to your loop.
rm -rf %{buildroot} is no longer necessary.
The locales aren't handled properly, see:
http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files
Are those libraries really intended to be public? If so, there should be header
files and a devel-subpackage.
/usr/bin/crashhandler is a potentially problematic name.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=GgJBnNkj3Q&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #3 from Pavel Alexeev (aka Pahan-Hubbitus) --- Build without pkg-config requirement (patched): Spec: https://github.com/Hubbitus/Fedora-packaging/blob/adf5976c9b9d892e573aca06b47712e6ebb9b0ee/SPECS/pgmodeler.spec Srpm: http://hubbitus.info/rpm/Fedora19/pgmodeler/pgmodeler-0.5.1_r1-2.GITbe5b74a.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FH9T60B1Mf&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 Pavel Alexeev (aka Pahan-Hubbitus) changed: What|Removed |Added Depends On|977115 | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sB39AoY1TC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #2 from Pavel Alexeev (aka Pahan-Hubbitus) --- Pavel thank you for the help attempt. Sure I'll be able hack it to build without pckgconfig, but in most cases it is not good choose. But you point also have sence. Please consider put that file together with another update in stable fedora branch if happened. And strange, on Fedora 18 I be able build and run it. Does . /etc/profile.d/pgmodeler.bash ; pgmodeler run it? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Fbiw8MXxZF&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116
Pavel Raiskup changed:
What|Removed |Added
CC||prais...@redhat.com
--- Comment #1 from Pavel Raiskup ---
Created attachment 767509
--> https://bugzilla.redhat.com/attachment.cgi?id=767509&action=edit
Backtrace.
Apart from the review (more like a reaction to the blocking bug 977115) - isn't
it possible to use something like that .. in your .pro file?
diff --git a/pgmodeler.pro b/pgmodeler.pro
index c29d9a8..5e8f5ad 100644
--- a/pgmodeler.pro
+++ b/pgmodeler.pro
@@ -9,9 +9,10 @@
unix {
!macx:CONFIG += link_pkgconfig
- !macx:PKGCONFIG = libpq libxml-2.0
- !macx:PGSQL_LIB = -lpq
+ !macx:PKGCONFIG = libxml-2.0
!macx:XML_LIB = -lxml2
+ QMAKE_CXXFLAGS = -I/usr/include/pgsql
+ QMAKE_LFLAGS = -lpq
}
macx {
I'm unable to build the package successfully even if I provide the '*.pc' file
as you suggested (on fc19 x86_64) so I can't tell you 100% sure that this tweak
is OK ~~> in both ways, jfyi, the pgmodeler immediately ends with segfault
(backtrace is attached).
Pavel
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ayKlsObt8C&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 Pavel Alexeev (aka Pahan-Hubbitus) changed: What|Removed |Added Depends On||977115 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dCNpmThtEC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
