[Bug 977118] Review Request: nodejs-dateformat - Steven Levithan's excellent dateFormat() function for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=977118 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rVTI5297C3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977118] Review Request: nodejs-dateformat - Steven Levithan's excellent dateFormat() function for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=977118 Tom Hughes t...@compton.nu changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Tom Hughes t...@compton.nu --- Great. Package approved then. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aQ1MH2Hi05a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977118] Review Request: nodejs-dateformat - Steven Levithan's excellent dateFormat() function for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=977118 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Jamie Nguyen jamieli...@fedoraproject.org --- New Package SCM Request === Package Name: nodejs-dateformat Short Description: Steven Levithan's excellent dateFormat() function for Node.js Owners: jamielinux patches Branches: f18 f19 f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lSIXk7Sjuva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977118] Review Request: nodejs-dateformat - Steven Levithan's excellent dateFormat() function for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=977118 --- Comment #7 from Jamie Nguyen jamieli...@fedoraproject.org --- Bundling exception approved: https://fedorahosted.org/fpc/ticket/319#comment:5 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Mzql6lcZtFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977118] Review Request: nodejs-dateformat - Steven Levithan's excellent dateFormat() function for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=977118 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #6 from Christopher Meng cicku...@gmail.com --- I think you should request an additional +1. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=awPXQrUKPxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977118] Review Request: nodejs-dateformat - Steven Levithan's excellent dateFormat() function for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=977118 --- Comment #5 from Jamie Nguyen jamieli...@fedoraproject.org --- https://fedorahosted.org/fpc/ticket/319 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ngWx6XHjxSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977118] Review Request: nodejs-dateformat - Steven Levithan's excellent dateFormat() function for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=977118 Bug 977118 depends on bug 981863, which changed state. Bug 981863 Summary: Review Request: dateformat - A simple way to format dates and times according to a user-specified mask https://bugzilla.redhat.com/show_bug.cgi?id=981863 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Zq2hP3eOd7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977118] Review Request: nodejs-dateformat - Steven Levithan's excellent dateFormat() function for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=977118
Tom Hughes t...@compton.nu changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||t...@compton.nu
Assignee|nob...@fedoraproject.org|t...@compton.nu
Flags||fedora-review?
--- Comment #1 from Tom Hughes t...@compton.nu ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
[!]: Package contains no bundled libraries without FPC exception.
Bundling code from http://blog.stevenlevithan.com/archives/date-time-format
which is also what leads to the weird version numbers because 1.2.3 is
the upstream version of the bundled code.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[=]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 1 files have unknown license. Detailed output of
licensecheck in /home/tom/977118-nodejs-dateformat/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
Note: Found : Packager: Tom Hughes t...@compton.nu
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original
[Bug 977118] Review Request: nodejs-dateformat - Steven Levithan's excellent dateFormat() function for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=977118 --- Comment #2 from Jamie Nguyen jamieli...@fedoraproject.org --- Damn, I should really have realised this... I'll packaged the original dateformat separately. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XhwaojvoFla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977118] Review Request: nodejs-dateformat - Steven Levithan's excellent dateFormat() function for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=977118 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Depends On||981863 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LV8vsN14pYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977118] Review Request: nodejs-dateformat - Steven Levithan's excellent dateFormat() function for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=977118 Tom Hughes t...@compton.nu changed: What|Removed |Added Depends On|981863 | --- Comment #3 from Tom Hughes t...@compton.nu --- The only problem is that I think the npm one has local changes that aren't in the upstream... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=29ym18GrNba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977118] Review Request: nodejs-dateformat - Steven Levithan's excellent dateFormat() function for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=977118 Tom Hughes t...@compton.nu changed: What|Removed |Added Depends On||981863 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Phyq3KQ8zPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977118] Review Request: nodejs-dateformat - Steven Levithan's excellent dateFormat() function for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=977118 --- Comment #4 from Jamie Nguyen jamieli...@fedoraproject.org --- (In reply to Tom Hughes from comment #3) The only problem is that I think the npm one has local changes that aren't in the upstream... Oh, err, I didn't even think of that. Damn... Well I suppose no harm in packaging dateformat anyways. I'll have to get an FPC exception for this. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uqskoAFHRaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977118] Review Request: nodejs-dateformat - Steven Levithan's excellent dateFormat() function for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=977118 Jamie Nguyen jamieli...@fedoraproject.org changed: What|Removed |Added Blocks||956806 (nodejs-reviews), ||977128 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5Og95Xutj0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
