[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 Björn Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-07-19 09:15:42 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3Im3R5QDWga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- libjoedog-0.1.1-4.el5, fido-1.0.7-6.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=o8xtU9Qszla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- libjoedog-0.1.1-4.el6, fido-1.0.7-6.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GshrbjBCrza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- libjoedog-0.1.1-4.fc18, fido-1.0.7-6.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8GCfMf5kNna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- libjoedog-0.1.1-4.fc19, fido-1.0.7-6.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rsnS4xhOSEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=e2jMbYtDrha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- libjoedog-0.1.1-4.fc19,fido-1.0.7-6.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/libjoedog-0.1.1-4.fc19,fido-1.0.7-6.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=U6WPv3HARSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- libjoedog-0.1.1-4.fc18,fido-1.0.7-6.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libjoedog-0.1.1-4.fc18,fido-1.0.7-6.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nbo3lwXj5Ya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- libjoedog-0.1.1-4.el6,fido-1.0.7-6.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libjoedog-0.1.1-4.el6,fido-1.0.7-6.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OYCb6RYyAMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- libjoedog-0.1.1-4.el5,fido-1.0.7-6.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/libjoedog-0.1.1-4.el5,fido-1.0.7-6.el5 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=g2Btau0Xpna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 Roman Mohr ro...@fenkhuber.at changed: What|Removed |Added Blocks||972477, 973822 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rW6RHeEEULa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 --- Comment #1 from Roman Mohr ro...@fenkhuber.at --- koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=5535246 rpmlint: rpmlint SRPMS/libjoedog-0.1.0-1.fc20.src.rpm RPMS/x86_64/libjoedog-0.1.0-1.fc20.x86_64.rpm RPMS/x86_64/libjoedog-devel-0.1.0-1.fc20.x86_64.rpm libjoedog.src: W: spelling-error Summary(en_US) fido - Fido, dido, filo libjoedog.src: W: spelling-error %description -l en_US fido - Fido, dido, filo libjoedog.x86_64: W: spelling-error Summary(en_US) fido - Fido, dido, filo libjoedog.x86_64: W: spelling-error %description -l en_US fido - Fido, dido, filo libjoedog.x86_64: W: shared-lib-calls-exit /usr/lib64/libjoedog.so.0.1.0 exit@GLIBC_2.2.5 libjoedog-devel.x86_64: W: no-documentation -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wpOmKVZWtpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367
Björn Esser bjoern.es...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||bjoern.es...@gmail.com
Assignee|nob...@fedoraproject.org|bjoern.es...@gmail.com
Flags||fedora-review?
--- Comment #2 from Björn Esser bjoern.es...@gmail.com ---
Package Review
==
Legend:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[!]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libjoedog-
devel
--- Requires: libjoedog == %{version} shoud be
Requires: %{name}%{?_isa} = %{version}-%{release}
[x]: Package complies to the Packaging Guidelines
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v2 or later), GPL (v2 or later), Unknown or generated. 4
files have unknown license. Detailed output of licensecheck in
/home/bjoern.esser/fedora/review/977367-libjoedog/licensecheck.txt
--- 's!GPLv2+! and LGPLv2+!'
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Package must own all directories that it creates.
--- 's!%{_includedir}/joedog/*.h!%{_includedir}/joedog!'
and all is fine
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 30720 bytes in 3 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[!]: Spec use %global instead of %define.
Note: %define current
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367
--- Comment #3 from Björn Esser bjoern.es...@gmail.com ---
There are some more minor issues with the spec-file:
* el5-build needs proper Group-tag for main-pkg and devel-sub
* lib should be build hardened, because it's main target is being
used by daemons
* BRs can be trimmed down to just having libtool
* %{name}-macro should be used in %file (and other places as well),
instead of hardcoding name
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=HKxDY0ayiza=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 --- Comment #4 from Roman Mohr ro...@fenkhuber.at --- Spec URL: http://rfenkhuber.fedorapeople.org/libjoedog/libjoedog.spec SRPM URL: http://rfenkhuber.fedorapeople.org/libjoedog/libjoedog-0.1.0-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ppzqz25kI6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 --- Comment #5 from Björn Esser bjoern.es...@gmail.com --- Source checksums https://github.com/rmohr/libjoedog/archive/libjoedog-0.1.0.tar.gz : CHECKSUM(SHA256) this package : c9281cba52fac1c6671791e783322d3460cb6982b555b9af2d6537764f04efa3 CHECKSUM(SHA256) upstream package : 1b3e023bc5b630b12f7ac3518709d00e60cf7f9364a589ba6cb44f30b4c74b7f diff -r also reports differences please rebuild srpm with new tarball from Source0 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JhGire0ZCda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 Roman Mohr ro...@fenkhuber.at changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #6 from Roman Mohr ro...@fenkhuber.at --- Spec URL: http://rfenkhuber.fedorapeople.org/libjoedog/libjoedog.spec SRPM URL: http://rfenkhuber.fedorapeople.org/libjoedog/libjoedog-0.1.0-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Tl9MkJ9hXEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367
Björn Esser bjoern.es...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #7 from Björn Esser bjoern.es...@gmail.com ---
Package is fine, now. All issues are resolved.
#
hardening-check looks good:
libjoedog-0.1.0-2.fc20.x86_64.rpm/usr/lib64/libjoedog.so.0.1.0:
Position Independent Executable: no, regular shared library (ignored)
Stack protected: yes
Fortify Source functions: yes (some protected functions found)
unprotected: memset
unprotected: memmove
unprotected: strcpy
unprotected: memcpy
protected: snprintf
protected: vsprintf
protected: printf
protected: fprintf
protected: sprintf
protected: syslog
Read-only relocations: yes
Immediate binding: yes
#
Package Review
==
Legend:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v2 or later), GPL (v2 or later), Unknown or generated. 4
files have unknown license. Detailed output of licensecheck in
/home/bjoern.esser/fedora/review/977367-libjoedog/licensecheck.txt
--- License-tag is fine
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 30720 bytes in 3 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 --- Comment #8 from Roman Mohr ro...@fenkhuber.at --- New Package SCM Request === Package Name: libjoedog Short Description: Repack of the common code base of fido and siege as shared library Owners: rfenkhuber besser82 Branches: f18 f19 el5 el6 InitialCC: cdamian -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rRceH4XyUXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 Roman Mohr ro...@fenkhuber.at changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ERNIBDOFz0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 --- Comment #9 from Roman Mohr ro...@fenkhuber.at --- New Package SCM Request === Package Name: libjoedog Short Description: Repack of the common code base of fido and siege as shared library Owners: rfenkhuber besser82 cdamian Branches: f18 f19 el5 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BSE96qIYwfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yujetItMf5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977367] Review Request: libjoedog - Repack of the common code base of fido and siege as shared library
https://bugzilla.redhat.com/show_bug.cgi?id=977367 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xDBZK9D3Dua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
