[Bug 980960] Review Request: rpmgrill - utility for catching problems in koji builds
https://bugzilla.redhat.com/show_bug.cgi?id=980960 Ed Santiago santi...@redhat.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6rDZlOBRBKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 980960] Review Request: rpmgrill - utility for catching problems in koji builds
https://bugzilla.redhat.com/show_bug.cgi?id=980960 --- Comment #11 from Christopher Meng cicku...@gmail.com --- Hint: http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group This time the package is good. only rpmgrill.noarch: E: explicit-lib-dependency libxslt Is it really needed? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pb3dTBBSica=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 980960] Review Request: rpmgrill - utility for catching problems in koji builds
https://bugzilla.redhat.com/show_bug.cgi?id=980960
--- Comment #12 from Ed Santiago santi...@redhat.com ---
Hint:
http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
I'm taking that as hint: start helping out with reviews -- I'm still a bit
intimidated. But I'm reading. Thank you.
rpmgrill.noarch: E: explicit-lib-dependency libxslt
Is it really needed?
The actual requirement is /usr/bin/xsltproc . One of the plugins invokes it via
qx{...}. Is there a better way to specify the dependency?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=nxNnyWFGpba=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 980960] Review Request: rpmgrill - utility for catching problems in koji builds
https://bugzilla.redhat.com/show_bug.cgi?id=980960 --- Comment #13 from Christopher Meng cicku...@gmail.com --- Not sure, leave it to your sponsor ;) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UacIKOD6RTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 980960] Review Request: rpmgrill - utility for catching problems in koji builds
https://bugzilla.redhat.com/show_bug.cgi?id=980960 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review? --- Comment #8 from Christopher Meng cicku...@gmail.com --- I'll take this. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HRx41BttsYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 980960] Review Request: rpmgrill - utility for catching problems in koji builds
https://bugzilla.redhat.com/show_bug.cgi?id=980960
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
Status|ASSIGNED|NEW
Assignee|cicku...@gmail.com |nob...@fedoraproject.org
Flags|fedora-review? |
--- Comment #9 from Christopher Meng cicku...@gmail.com ---
This is an informal review, hope you can find a sponsor(I think it's easy for
RH people):
1. SPEC itself:
- You can remove this:
find %{buildroot} -depth -type d -exec rmdir {} 2/dev/null \;
- Requires: /usr/bin/xsltproc
can be
Requires: libxslt
- I cannot access 2 bugs mentioned in the spec, can you tell me something about
them?
Package itself:
Unable to install:
# ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-i386/root/',
'install',
'/home/rpmaker/Desktop/rpmgrill/results/rpmgrill-0.22-2.fc20.noarch.rpm']
Error: Package: rpmgrill-0.22-2.fc20.noarch (/rpmgrill-0.22-2.fc20.noarch)
Requires: perl(RPM::Grill::Util)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=0YcNcXs274a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 980960] Review Request: rpmgrill - utility for catching problems in koji builds
https://bugzilla.redhat.com/show_bug.cgi?id=980960 --- Comment #10 from Ed Santiago santi...@redhat.com --- Again, thanks for your feedback. I'm really not sure why I changed the libxslt requirement to a path, but it's back. And the internal BZ references are gone, replaced with what I hope are useful descriptions of why those packages are needed. The missing RPM::Grill::Util is pretty embarrassing. Sorry about that. New spec, srpm, noarch rpm : http://www.edsantiago.com/f/rpmgrill.spec http://www.edsantiago.com/f/rpmgrill-0.23-1.fc19.src.rpm http://www.edsantiago.com/f/rpmgrill-0.23-1.fc19.noarch.rpm (RPM::Grill::Util does not include a perl-findable $VERSION; I've just checked in a fix for that but have not rebuilt the rpm). You've been very thorough and helpful. Thank you. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TYTRehsFREa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 980960] Review Request: rpmgrill - utility for catching problems in koji builds
https://bugzilla.redhat.com/show_bug.cgi?id=980960 Ed Santiago santi...@redhat.com changed: What|Removed |Added Flags|needinfo?(santiago@redhat.c | |om) | --- Comment #7 from Ed Santiago santi...@redhat.com --- Fedora username: santiago Buildroot: removed. New spec: http://www.edsantiago.com/f/rpmgrill.spec New srpm: http://www.edsantiago.com/f/rpmgrill-0.22-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MURvlsu0mia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 980960] Review Request: rpmgrill - utility for catching problems in koji builds
https://bugzilla.redhat.com/show_bug.cgi?id=980960 Till Maas opensou...@till.name changed: What|Removed |Added CC||opensou...@till.name, ||santi...@redhat.com Flags||needinfo?(santiago@redhat.c ||om) --- Comment #6 from Till Maas opensou...@till.name --- see comment:4 and comment:5 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZM6cR1cPYDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 980960] Review Request: rpmgrill - utility for catching problems in koji builds
https://bugzilla.redhat.com/show_bug.cgi?id=980960 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org --- Comment #4 from Michael Scherer m...@zarb.org --- You didn't mention your FAS username. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9UrmXOIwCAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 980960] Review Request: rpmgrill - utility for catching problems in koji builds
https://bugzilla.redhat.com/show_bug.cgi?id=980960 --- Comment #5 from Michael Scherer m...@zarb.org --- And BuildRoot is not really needed on Fedora, afaik, nor on EPEL 6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iGFnmeBVwna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 980960] Review Request: rpmgrill - utility for catching problems in koji builds
https://bugzilla.redhat.com/show_bug.cgi?id=980960
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
CC||cicku...@gmail.com
--- Comment #1 from Christopher Meng cicku...@gmail.com ---
Aha...
1. Where is the URL tag, that means, where is the program's homepage?
2. Source0 should be a link which can directly be used to download the tarball
or other sources. Only this style is for softwares which cannot provide a
tarball.
3. Requires: perl is incorrect, please see:
https://fedoraproject.org/wiki/Packaging:Perl#Versioned_MODULE_COMPAT_Requires
4. Requires: /usr/bin/desktop-file-validate is right but I think you can
change it to desktop-file-utils
5. No need for %clean section/%defattr(-,root,root,-)/rm -rf
$RPM_BUILD_ROOT(old habits should be trashed)
6. Do not mix variable and macros, you can change $RPM_BUILD_ROOT to
%{buildroot}
7. If there are no docs, you don't need to write %doc with an empty line.
8. /usr/share in %files section can be replaced by %{_datadir}
I'm not a sponsor, but please consider a fix for above issues.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=paepfR8wzSa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 980960] Review Request: rpmgrill - utility for catching problems in koji builds
https://bugzilla.redhat.com/show_bug.cgi?id=980960
--- Comment #2 from Christopher Meng cicku...@gmail.com ---
An additional note, I made the same mistake when I built my first RPM, that is
you MUST NOT write the perl BuildRequires/Requires like perl-Module-Build,
don't use dash-style, but like this:
perl(Module::Build)
So perl-IO-Socket-SSL should be something like this:
perl(IO::Socket::SSL)
BTW, if RPM can automatically find these Requires(NOT BuildRequires, you still
have to define which to be used for building), just use Requires:
perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`; echo $version)) is
enough.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=wZeJm9lKBWa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 980960] Review Request: rpmgrill - utility for catching problems in koji builds
https://bugzilla.redhat.com/show_bug.cgi?id=980960 --- Comment #3 from Ed Santiago santi...@redhat.com --- Many, many thanks. I believe I've addressed each issue you brought up. Diffs: https://git.fedorahosted.org/cgit/rpmgrill.git/commit/?id=0d77b8b89517aa150ec8b995389661a711107d48 New spec: http://www.edsantiago.com/f/rpmgrill.spec New srpm: http://www.edsantiago.com/f/rpmgrill-0.22-1.fc17.src.rpm New koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5570468 Clarifying note: The requirement on perl(IO::Socket::SSL) was hand-specified because it's dynamically tested for by LWP::UserAgent inside an eval, so RPM couldn't autodetect it. I have removed the requirement from the specfile because that code isn't actually used in this version of rpmgrill. Again, thanks for your thorough and helpful review. You clarified some packaging points I hadn't understood, and (blush) pointed out some that I missed in my haste. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0x6tS2op4Xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
