[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||joyce-2.2.5-2.fc18 Resolution|--- |ERRATA Last Closed||2013-08-09 13:02:42 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- joyce-2.2.5-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NuhRZgTp6la=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|joyce-2.2.5-2.fc18 |joyce-2.2.5-2.fc19 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- joyce-2.2.5-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=a4peNQlSYRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- joyce-2.2.5-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0lYL5OCv0Ea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- joyce-2.2.5-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/joyce-2.2.5-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gJlgRsLbsna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- joyce-2.2.5-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/joyce-2.2.5-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IkRnB3ghcSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xbbek13Hw3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 Dennis Gilmore den...@ausil.us changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xtSihotoZTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 --- Comment #13 from Dennis Gilmore den...@ausil.us --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lUbJKRw207a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 --- Comment #8 from Simone Caronni negativ...@gmail.com --- If you want the review to proceed, you can just apply the aforementioned changes to the spec file; it is perfectly acceptable to add autotools in BuildRequires. You can later remove them when you get feedback from upstream. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=spENhYrLmHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 --- Comment #9 from Christopher Meng cicku...@gmail.com --- NEW SPEC URL: http://cicku.me/joyce.spec NEW SRPM URL: http://cicku.me/joyce-2.2.5-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rN4OMto9dGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 Simone Caronni negativ...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #10 from Simone Caronni negativ...@gmail.com --- Package approved. One question, what does Split out data subpackage in the changelog mean? There's no data subpackage. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BdtNvLpyuja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #11 from Christopher Meng cicku...@gmail.com --- Wrong changelog, will be fixed in SCM. Thanks for your review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CAMxJMZVo8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 --- Comment #12 from Christopher Meng cicku...@gmail.com --- New Package SCM Request === Package Name: joyce Short Description: Amstrad PCW and PCW16 Emulator Owners: cicku Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hYJTel90uga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 Simone Caronni negativ...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||negativ...@gmail.com Assignee|nob...@fedoraproject.org|negativ...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=q7frUqRGaGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360
--- Comment #2 from Simone Caronni negativ...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Note: No javadoc subpackage present
See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
- ldconfig called in %post and %postun if required.
Note: /sbin/ldconfig not called in joyce
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
- Fully versioned dependency in subpackages, if present.
Note: Missing: Requires: %{name} = %{version}-%{release} in joyce-devel
See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage
- Packages have proper BuildRequires/Requires on jpackage-utils
See: https://fedoraproject.org/wiki/Packaging:Java
- Javadoc documentation files are generated and included in -javadoc
subpackage
Note: No javadoc subpackage present
See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[!]: Rpath absent or only used for internal libs.
Note: See rpmlint output
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later) (with incorrect FSF address), *No copyright* GPL (v2
or later) (with incorrect FSF address), GPL (v2 or later), LGPL (v2
or later) (with incorrect FSF address), Unknown or generated. 64 files
have unknown license. Detailed output of licensecheck in
/home/slaanesh/Documents/fedora/984360-joyce/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 614400 bytes in 9 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360
--- Comment #3 from Simone Caronni negativ...@gmail.com ---
(In reply to Simone Caronni from comment #2)
- ldconfig called in %post and %postun if required.
Note: /sbin/ldconfig not called in joyce
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
joyce.x86_64: E: library-without-ldconfig-postin /usr/lib64/libdsk.so.3.2.4
joyce.x86_64: E: library-without-ldconfig-postun /usr/lib64/libdsk.so.3.2.4
[...]
Please add:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
[!]: Rpath absent or only used for internal libs.
Note: See rpmlint output
joyce.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/dskid ['/usr/lib64']
[...]
Please add the following to the spec file; regenerating the %configure script
with autotools solves the issues:
--- joyce.spec.old2013-07-22 10:22:32.409074418 +0200
+++ joyce.spec2013-07-22 10:22:39.841008109 +0200
@@ -6,9 +6,12 @@
URL:http://www.seasip.info/Unix/Joyce
Source0:http://www.seasip.info/Unix/Joyce/%{name}-%{version}b.tar.gz
+BuildRequires: autoconf
+BuildRequires: automake
BuildRequires: SDL-devel
BuildRequires: libxml2-devel
BuildRequires: libpng-devel
+BuildRequires: libtool
%description
JOYCE is an Amstrad PCW and PCW16 emulator.
@@ -25,6 +28,7 @@
%setup -qn %{name}-%{version}b
%build
+autoreconf -v -f --install
%configure --enable-shared --disable-static
make %{?_smp_mflags}
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later) (with incorrect FSF address), *No copyright* GPL
(v2
or later) (with incorrect FSF address), GPL (v2 or later), LGPL (v2
or later) (with incorrect FSF address), Unknown or generated. 64
files
have unknown license. Detailed output of licensecheck in
/home/slaanesh/Documents/fedora/984360-joyce/licensecheck.txt
These are the licenses found by licensecheck; please adjust (GPLv2+ and LGPLv2+
should be ok):
- *No copyright* GPL (v2 or later) (with incorrect FSF address)
- GPL (v2 or later)
- GPL (v2 or later) (with incorrect FSF address)
- LGPL (v2 or later) (with incorrect FSF address)
- Unknown or generated
[!]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
Note: Found : Packager: Simone Caronni negativ...@gmail.com
This is my local .rpmmacros, please ignore.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=0woBI0aBoDa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360
--- Comment #4 from Simone Caronni negativ...@gmail.com ---
If you are building only for Fedora and not EPEL 6, in the install section,
instead of:
%install
make install DESTDIR=%{buildroot}
find %{buildroot} -name '*.*a' -exec rm -f {} ';'
Please use:
%install
%make_install
find %{buildroot} -name '*.*a' -delete
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ze52TbgvQea=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 --- Comment #5 from Simone Caronni negativ...@gmail.com --- Just cosmetic, please sort BuildRequires: BuildRequires: autoconf BuildRequires: automake BuildRequires: libpng-devel BuildRequires: libtool BuildRequires: libxml2-devel BuildRequires: SDL-devel -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BlBhoEcMEra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 --- Comment #6 from Simone Caronni negativ...@gmail.com --- (In reply to Simone Caronni from comment #3) These are the licenses found by licensecheck; please adjust (GPLv2+ and LGPLv2+ should be ok): Well, probably only changing from GPLv2 to GPLv2+ will suffice. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xEnI3KU3L2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 --- Comment #7 from Christopher Meng cicku...@gmail.com --- License fixed. For the autoreconf problem, I just ping upstream. Hope news later. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4MnwgypKXwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984360] Review Request: joyce - Amstrad PCW and PCW16 Emulator
https://bugzilla.redhat.com/show_bug.cgi?id=984360 --- Comment #1 from Susi Lehtola susi.leht...@iki.fi --- *** Bug 984361 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cTOIaVrkHea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
