[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||dvb-apps-1.1.2-6.1488.f3a70 ||b206f0f.fc20 Resolution|--- |ERRATA Last Closed||2014-03-12 08:31:32 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- dvb-apps-1.1.2-6.1488.f3a70b206f0f.fc20, dtv-scan-tables-0-4.20130713gitd913405.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|dvb-apps-1.1.2-6.1488.f3a70 |dtv-scan-tables-0-4.2013071 |b206f0f.fc20|3gitd913405.fc19 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- dtv-scan-tables-0-4.20130713gitd913405.fc19, dvb-apps-1.1.2-6.1488.f3a70b206f0f.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- Package dtv-scan-tables-0-4.20130713gitd913405.fc19, dvb-apps-1.1.2-6.1488.f3a70b206f0f.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing dtv-scan-tables-0-4.20130713gitd913405.fc19 dvb-apps-1.1.2-6.1488.f3a70b206f0f.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-2711/dtv-scan-tables-0-4.20130713gitd913405.fc19,dvb-apps-1.1.2-6.1488.f3a70b206f0f.fc19 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- dvb-apps-1.1.2-6.1488.f3a70b206f0f.fc20,dtv-scan-tables-0-4.20130713gitd913405.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/dvb-apps-1.1.2-6.1488.f3a70b206f0f.fc20,dtv-scan-tables-0-4.20130713gitd913405.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- dtv-scan-tables-0-4.20130713gitd913405.fc19,dvb-apps-1.1.2-6.1488.f3a70b206f0f.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/dtv-scan-tables-0-4.20130713gitd913405.fc19,dvb-apps-1.1.2-6.1488.f3a70b206f0f.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 --- Comment #14 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 Till Maas opensou...@till.name changed: What|Removed |Added Flags||fedora-cvs? --- Comment #13 from Till Maas opensou...@till.name --- Thank you for the review. New Package SCM Request === Package Name: dtv-scan-tables Short Description: Digital TV scan tables Owners: till pbrobinson Branches: f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #12 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6366348
$ rpmlint -i -v *
dtv-scan-tables.src: I: checking
dtv-scan-tables.src: I: checking-url http://git.linuxtv.org/dtv-scan-tables.git
(timeout 10 seconds)
dtv-scan-tables.src: I: checking-url
http://linuxtv.org/downloads/dtv-scan-tables/dtv-scan-tables-2013-07-03-d913405.tar.bz2
(timeout 10 seconds)
dtv-scan-tables.noarch: I: checking
dtv-scan-tables.noarch: I: checking-url
http://git.linuxtv.org/dtv-scan-tables.git (timeout 10 seconds)
dtv-scan-tables.spec: I: checking-url
http://linuxtv.org/downloads/dtv-scan-tables/dtv-scan-tables-2013-07-03-d913405.tar.bz2
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is silent.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
Public Domain
[.] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
2a6d09876bd0c3c2476dbdc3f89301bc2237b49dbd30d1c92e99c16bdbbfd724
dtv-scan-tables-2013-07-03-d913405.tar.bz2
2a6d09876bd0c3c2476dbdc3f89301bc2237b49dbd30d1c92e99c16bdbbfd724
dtv-scan-tables-2013-07-03-d913405.tar.bz2.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[.] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[+] MUST: If a package includes something as %doc, it must not affect the
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 --- Comment #11 from Till Maas opensou...@till.name --- Spec URL: http://till.fedorapeople.org/review/dtv-scan-tables.spec SRPM URL: http://till.fedorapeople.org/review/dtv-scan-tables-0-3.20130713gitd913405.fc19.src.rpm Sorry, I thought I already updated the request. Changes: - update changelog - adjust Conflicts -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 --- Comment #10 from Mario Blättermann mario.blaetterm...@gmail.com --- Any news? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 --- Comment #9 from Mario Blättermann mario.blaetterm...@gmail.com --- Unfortunately, you are forced to do so. As a workaround, you could use rpmdev-bumpspec. Running this command just bumps the release number while keeping all the other things. so you have to fix the release number and no more than that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? --- Comment #7 from Mario Blättermann mario.blaetterm...@gmail.com --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6156289 $ rpmlint -i -v *dtv-scan-tables.src: I: checking dtv-scan-tables.src: I: checking-url http://git.linuxtv.org/dtv-scan-tables.git (timeout 10 seconds) dtv-scan-tables.src: I: checking-url http://linuxtv.org/downloads/dtv-scan-tables/dtv-scan-tables-2013-07-03-d913405.tar.bz2 (timeout 10 seconds) dtv-scan-tables.noarch: I: checking dtv-scan-tables.noarch: W: incoherent-version-in-changelog 0-2 ['0-2.20130703gitd913405.fc21', '0-2.20130703gitd913405'] The latest entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. dtv-scan-tables.noarch: I: checking-url http://git.linuxtv.org/dtv-scan-tables.git (timeout 10 seconds) dtv-scan-tables.spec: I: checking-url http://linuxtv.org/downloads/dtv-scan-tables/dtv-scan-tables-2013-07-03-d913405.tar.bz2 (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 1 warnings. Please add the full release number to %changelog: * Fri Nov 01 2013 Till Maas opensou...@till.name - 0-2.20130703gitd913405 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 --- Comment #8 from Till Maas opensou...@till.name --- (In reply to Mario Blättermann from comment #7) Please add the full release number to %changelog: * Fri Nov 01 2013 Till Maas opensou...@till.name - 0-2.20130703gitd913405 Is this really necessary and is there a way to do this with vim without having to write the date and git hash manually several times in the SPEC? The first digit is already unique for each version, therefore 0-2 will always identifiy the release. I do not see an easy way to change the macros to e.g. only write the date and git hash in the Release tag and then build the source tag from it, which would allow to write the full release to the changelog with \c. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #5 from Mario Blättermann mario.blaetterm...@gmail.com --- Till, please change the license to Public Domain as proposed by Spot and provide new files. Then I'll take this for a full review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 --- Comment #6 from Till Maas opensou...@till.name --- (In reply to Mario Blättermann from comment #5) Till, please change the license to Public Domain as proposed by Spot and provide new files. Then I'll take this for a full review. Thank you, here are the updated files: Spec URL: http://till.fedorapeople.org/review/dtv-scan-tables.spec SRPM URL: http://till.fedorapeople.org/review/dtv-scan-tables-0-2.20130703gitd913405.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Blocks|182235 (FE-Legal) | --- Comment #4 from Tom spot Callaway tcall...@redhat.com --- You know, given that, I'm fine with marking this as Public Domain and moving on. If the original copyright holders appear and ask for us to clarify, we shall. Lifting FE-Legal. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MsnqvH7NZTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 --- Comment #3 from Till Maas opensou...@till.name --- It does not seem to be clear, who would be the original upstream, but as far as I understand there were intentions to license it as LGPL: http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/59288/focus=59304 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=te2uI1Fs7Xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 Till Maas opensou...@till.name changed: What|Removed |Added CC||opensou...@till.name Blocks||952326, 182235 (FE-Legal) --- Comment #1 from Till Maas opensou...@till.name --- Please see bug 952326, comment 7 and following for license questions. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fHpZ8RtqDGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 Till Maas opensou...@till.name changed: What|Removed |Added Alias||dtv-scan-tables -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=A3Xiizai1ga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986051] Review Request: dtv-scan-tables - Digital TV scan tables
https://bugzilla.redhat.com/show_bug.cgi?id=986051 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com --- Comment #2 from Tom spot Callaway tcall...@redhat.com --- The content is not clearly licensed, but the files themselves are probably not copyrightable in the US. That said, I think I'd prefer asking upstream what they intend for the license on these files to be, and then mark the package accordingly. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L3GfEJ2QGDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
