[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567 leigh scott leigh123li...@googlemail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #12 from leigh scott leigh123li...@googlemail.com --- Package Change Request == Package Name: cinnamon-control-center New Branches: epel7 Owners: leigh123linux -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567 leigh scott leigh123li...@googlemail.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #10 from leigh scott leigh123li...@googlemail.com --- Package Change Request == Package Name: cinnamon-control-center New Branches: epel7 Owners: leigh123linux -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- No epel7 branches yet. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567 Bill Nottingham nott...@redhat.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | CC|nott...@redhat.com | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED CC||cicku...@gmail.com Resolution|--- |CURRENTRELEASE Last Closed||2013-11-21 10:41:32 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567
--- Comment #7 from Michael Schwendt bugs.mich...@gmx.net ---
A few unowned directories:
%{_datadir}/cinnamon-control-center/sounds/cinnamon-sounds-default.xml
The sounds directory.
%{_datadir}/sounds/cinnamon/default/*/*.ogg
The cinnamon directory and likely all its subdirs.
%{_libdir}/cinnamon-control-center-1/panels/libcolor.so
The panels dir.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=dTRGbJpEcqa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567
--- Comment #8 from leigh scott leigh123li...@googlemail.com ---
(In reply to Michael Schwendt from comment #7)
A few unowned directories:
%{_datadir}/cinnamon-control-center/sounds/cinnamon-sounds-default.xml
This is owned by
%files filesystem
%dir %{_datadir}/cinnamon-control-center/
%dir %{_datadir}/cinnamon-control-center/sounds/
The sounds directory.
%{_datadir}/sounds/cinnamon/default/*/*.ogg
The cinnamon directory and likely all its subdirs.
I missed that, but it's gone now
%{_libdir}/cinnamon-control-center-1/panels/libcolor.so
This is owned by
%dir %{_libdir}/cinnamon-control-center-1/
The panels dir.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Hbe5J0SHVha=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567 --- Comment #9 from Michael Schwendt bugs.mich...@gmx.net --- Can't confirm: # repoquery --whatprovides /usr/share/cinnamon-control-center/sounds # # repoquery --whatprovides /usr/lib64/cinnamon-control-center-1/panels # # yum list cinnamon-control-center-filesystem Loaded plugins: langpacks, refresh-packagekit Available Packages cinnamon-control-center-filesystem.i686 1.9.0-0.14.git31ce8a8.fc20 fedora cinnamon-control-center-filesystem.x86_64 1.9.0-0.14.git31ce8a8.fc20 fedora -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CsNKHI03ZNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567 --- Comment #3 from leigh scott leigh123li...@googlemail.com --- Changes made Spec URL: http://leigh123linux.fedorapeople.org/pub/review/cinnamon-control-center/3/cinnamon-control-center.spec SRPM URL: http://leigh123linux.fedorapeople.org/pub/review/cinnamon-control-center/3/cinnamon-control-center-1.9.0-0.3.git430927a.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Vs9lIZmyO3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567
Wolfgang Ulbrich chat-to...@raveit.de changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Wolfgang Ulbrich chat-to...@raveit.de ---
APPROVED !
Please remove needless update-mime-database and update-desktop-database
scriptlets, there are no mime types in desktop files and no file is installed
in /usr/share/mime.
And notice upstream about incorrect FSF addresses!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- update-desktop-database is invoked when required
Note: desktop file(s) in cinnamon-control-center
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
Fault positive, the desktop file doesn't contain any mime type.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: %config files are marked noreplace or the reason is justified.
Note: No (noreplace) in %config /etc/xdg/autostart/cinnamon-sound-
applet.desktop %config /etc/xdg/menus/cinnamoncc.menu
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[-]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cinnamon-
control-center-filesystem
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v2.1 or later) (with incorrect FSF address), LGPL (v2 or
later), GPL (v2 or later), Unknown or generated, MIT/X11 (BSD
like), LGPL (v2 or later) (with incorrect FSF address), ISC, GPL
(v2) (with incorrect FSF address), GPL (v2 or later) (with incorrect
FSF address), GPL (v2.1 or later). 22 files have unknown license.
Detailed output of licensecheck in /home/rave/986567-cinnamon-control-
center/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[-]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked when required
Note: icons in cinnamon-control-center
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 30720 bytes in 3 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567 leigh scott leigh123li...@googlemail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from leigh scott leigh123li...@googlemail.com --- New Package SCM Request === Package Name: cinnamon-control-center Short Description: Utilities to configure the Cinnamon desktop Owners: leigh123linux Branches: f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gFJvphG5sXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uhi4AMSgDla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R3qqa2149ea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567
--- Comment #1 from Wolfgang Ulbrich chat-to...@raveit.de ---
Those lines can savely removed, no need for this anymore.
Requires(post): desktop-file-utils = %{desktop_file_utils_version}
Requires(post): shared-mime-info
Requires(postun): desktop-file-utils = %{desktop_file_utils_version}
Requires(postun): shared-mime-info
Does creating this directory not cause a package conflict with c-c from gnome ?
# we do want this
mkdir -p $RPM_BUILD_ROOT%{_datadir}/gnome/wm-properties
And does c-c-c really create those directories ?
# we don't want these
rm -rf $RPM_BUILD_ROOT%{_datadir}/gnome/autostart
rm -rf $RPM_BUILD_ROOT%{_datadir}/gnome/cursor-fonts
Is that configure flag really needed?
CFLAGS=$RPM_OPT_FLAGS -Wno-error
Pls check desktop-file-install!
cinnamon-control-center.desktop.in.in has already OnlyShowIn=GNOME; entry.
Same for all other desktop files except cinnamon-sound-applet.desktop.in which
installs in /etc/xdg/autostart.
desktop-file-install --delete-original \
--dir $RPM_BUILD_ROOT%{_datadir}/applications \
--add-only-show-in GNOME \
$RPM_BUILD_ROOT%{_datadir}/applications/*.desktop
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=UiPLtauGhVa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567 --- Comment #2 from leigh scott leigh123li...@googlemail.com --- Changes made Spec URL: http://leigh123linux.fedorapeople.org/pub/review/cinnamon-control-center/2/cinnamon-control-center.spec SRPM URL: http://leigh123linux.fedorapeople.org/pub/review/cinnamon-control-center/2/cinnamon-control-center-1.9.0-0.2.git430927a.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NVnUPkl6YXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986567] Review Request:cinnamon-control-center - Utilities to configure the Cinnamon desktop
https://bugzilla.redhat.com/show_bug.cgi?id=986567 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Assignee|nob...@fedoraproject.org|chat-to...@raveit.de Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=z9pwn3Loyia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
