[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 Christopher Meng changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Iy9XSL5w8k&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 Eric Smith changed: What|Removed |Added Blocks||986608 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sXVZIkLJsO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 --- Comment #1 from Christopher Meng --- Issues: 1. Please use https://github.com/SimonSapin/tinycss OR https://pypi.python.org/pypi/tinycss as URL; 2. And please use pypi download link as Source0: https://pypi.python.org/packages/source/t/tinycss/tinycss-0.3.tar.gz 3. python-tinycss.i686: E: non-standard-executable-perm /usr/lib/python2.7/site-packages/tinycss/speedups.so 0775L -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Urq6jJl2zA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 --- Comment #2 from Eric Smith --- What is the rationale for issues 1 and 2? Is there some Fedora policy regarding github vs. pypi that I've overlooked? For issue 1, the URL I provide seems to be much closer to a "home page" for the project than the github page, provides a superset of the information on the github page, and provides a link to the github page. It seems like a more useful URL for users of the package. In fact, that's the page that pypi says is the home page. For issue 2, the release tarballs on github seem to be upstream from pypi, so they seem like a better candidate to be considered authoritative. Although pypi does appear to offer older versions, they aren't listed, while on github they are. This means that the using the github release URL for the Source makes it easier for someone maintaining the spec to look at the version history and find older or newer versions. Also, the github release page gives a portion of the hash useful to identify the correct sources in git. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LevrGn0k4S&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 --- Comment #3 from Eric Smith --- I think issue 3 is caused by some problem on the system you're building with. I've run rpmlint on the binary RPMs built by Koji for F19 and rawhide, and they don't give that warning. The speedups.so in the Koji builds are 0755. f19: http://koji.fedoraproject.org/koji/taskinfo?taskID=5637905 rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=5637921 $ ls *.rpm python-tinycss-0.3-1.fc19.i686.rpmpython-tinycss-0.3-1.fc20.i686.rpm python-tinycss-0.3-1.fc19.x86_64.rpm python-tinycss-0.3-1.fc20.x86_64.rpm $ rpmlint *.rpm python-tinycss.i686: W: spelling-error %description -l en_US cssselect -> selectness, select python-tinycss.x86_64: W: spelling-error %description -l en_US cssselect -> selectness, select python-tinycss.i686: W: spelling-error %description -l en_US cssselect -> selectness, select python-tinycss.x86_64: W: spelling-error %description -l en_US cssselect -> selectness, select 4 packages and 0 specfiles checked; 0 errors, 4 warnings. $ rpm -qlvp *.rpm | grep speedups.so -rwxr-xr-x1 rootroot65060 Jul 22 01:28 /usr/lib/python2.7/site-packages/tinycss/speedups.so -rwxr-xr-x1 rootroot76840 Jul 22 01:28 /usr/lib64/python2.7/site-packages/tinycss/speedups.so -rwxr-xr-x1 rootroot65056 Jul 22 01:33 /usr/lib/python2.7/site-packages/tinycss/speedups.so -rwxr-xr-x1 rootroot80936 Jul 22 01:33 /usr/lib64/python2.7/site-packages/tinycss/speedups.so -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4nWVZQDOyO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 Matthias Runge changed: What|Removed |Added CC||mru...@redhat.com --- Comment #4 from Matthias Runge --- (In reply to Eric Smith from comment #2) > What is the rationale for issues 1 and 2? Is there some Fedora policy > regarding github vs. pypi that I've overlooked? AFAIK, there is no such policy. Your URLs look fine. I'm tending to use urls looking more "official" or tending to be long stable, since your package might stay in fedora repos for a long time. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=h6VCqOCYxf&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 --- Comment #5 from Eric Smith --- The other reason I prefer github for the Source is that if we ever wanted to use a git snapshot, the Source URL would have to change, but it's at least on the same site. However, you are right that the pypi URLs are likely stable even if the developer changes from github to another site. If you still want me to change the URL and Source to the ones you previously recommended, let me know, and I'll do it, but my preference is to keep them as they are. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JQkvVvgkx7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 Christopher Meng changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Christopher Meng --- Pypi is a bit like CPAN, yes, it's an index of python packages. IMO, pypi not only provides a stable home URL for search and download, but also provides a better link of source0. You needed to check out the rev, and download, and waste 3 lines in your spec just because github doesn't provide a download way like sourceforge... I hate checking out a package from VCS, maybe the upstream forgets to tag releases? Maybe it is just a snapshot place? Or maybe bahbahbah... This module is lucky because the author can tag it as normal. I've seen many packages hosted on gitorious or bitbucket, they don't have a version number, even a downloadable link is unavailable, too. Anyway, it's up to you. I would keep all my things simple, but if you think it's ok, then I'll support, not only 2 hands, but also 2 feet. ;) My machine is rawhide, there shouldn't have difference between yours.. weird... APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dcbgAkcDC1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 --- Comment #7 from Matthias Runge --- (In reply to Eric Smith from comment #5) > The other reason I prefer github for the Source is that if we ever wanted to > use a git snapshot, the Source URL would have to change, but it's at least > on the same site. Source0 URL is just taken to create a file name for unpacking sources. I can't really recommend using git snapshots, because no human can remember the version. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LgmnXoec0f&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 Eric Smith changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Eric Smith --- New Package SCM Request === Package Name: python-tinycss Short Description: CSS parser for Python Owners: brouhaha Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R21uRdEBJk&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630
--- Comment #8 from Eric Smith ---
It's not necessary to remember the hash used for the snapshot. It needs to be
documented in the spec file, usually as a %global. It's also possible with
github to construct a URL for a snapshot tarball. For example, from
smartsim.spec:
%global git_hash 3b11cf8
[...]
Source0:
https://github.com/ashleynewson/SmartSim/tarball/%{git_hash}/sma
rtsim-%{git_hash}.tar.gz
That said, using release tarballs rather than snapshots is preferred unless
there is a really good reason to use a snapshot.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=xQRtMvYRWK&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QFcfqT80hQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fekiw8AE9q&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 --- Comment #11 from Fedora Update System --- python-tinycss-0.3-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-tinycss-0.3-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SdqlORef2h&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Fssv9ofaPI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 --- Comment #12 from Fedora Update System --- python-tinycss-0.3-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-tinycss-0.3-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hjegza5Y4H&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 --- Comment #13 from Fedora Update System --- python-tinycss-0.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-tinycss-0.3-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0LeEsjNmlY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- python-tinycss-0.3-1.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ENn9lFsjMk&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 --- Comment #15 from Fedora Update System --- python-tinycss-0.3-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-tinycss-0.3-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7Fi01gCmjo&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 --- Comment #16 from Fedora Update System --- python-tinycss-0.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-tinycss-0.3-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wSIZ1shHZb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-tinycss-0.3-2.fc18 Resolution|--- |ERRATA Last Closed||2013-08-02 17:57:45 --- Comment #17 from Fedora Update System --- python-tinycss-0.3-2.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1cIuxBJfwB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 Fedora Update System changed: What|Removed |Added Fixed In Version|python-tinycss-0.3-2.fc18 |python-tinycss-0.3-2.fc19 --- Comment #18 from Fedora Update System --- python-tinycss-0.3-2.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lGW6WWfuTJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 Fedora Update System changed: What|Removed |Added Fixed In Version|python-tinycss-0.3-2.fc19 |python-tinycss-0.3-1.el6 --- Comment #19 from Fedora Update System --- python-tinycss-0.3-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Zw56A9BNyf&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 Eric Smith changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #20 from Eric Smith --- Package Change Request == Package Name: python-tinycss New Branches: epel7 Owners: brouhaha -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986630] Review Request: python-tinycss - CSS parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=986630 --- Comment #21 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
