[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 --- Comment #20 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 Eric Smith space...@gmail.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #19 from Eric Smith space...@gmail.com --- Package Change Request == Package Name: python-pyphen New Branches: epel7 Owners: brouhaha -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-pyphen-0.7-3.fc18|python-pyphen-0.7-3.el6 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- python-pyphen-0.7-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DPYALU6eYDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-pyphen-0.7-3.fc19 Resolution|--- |ERRATA Last Closed||2013-08-03 20:12:31 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- python-pyphen-0.7-3.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eIXJxN5UuDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-pyphen-0.7-3.fc19|python-pyphen-0.7-3.fc18 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- python-pyphen-0.7-3.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rllGSsIfpGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- python-pyphen-0.7-3.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m9lW9Wd7wra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i9drFkOBrka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kjUwXtZmLca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=a2ayuQyblZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- python-pyphen-0.7-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-pyphen-0.7-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M3Nzpu1kaua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-pyphen-0.7-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-pyphen-0.7-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n47bCk3yVDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- python-pyphen-0.7-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-pyphen-0.7-3.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6n77KJDQDca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from Christopher Meng cicku...@gmail.com --- Looks good. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KHoUrKcLB3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 Eric Smith space...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Eric Smith space...@gmail.com --- New Package SCM Request === Package Name: python-pyphen Short Description: Pure Python module to hyphenate text Owners: brouhaha Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VuAffS5elia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 --- Comment #7 from Christopher Meng cicku...@gmail.com --- BTW does it support py3? If so please update again... ;) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=trgSE1wAG4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 --- Comment #8 from Eric Smith space...@gmail.com --- Spec URL: http://fedorapeople.org/~brouhaha/python-pyphen/python-pyphen.spec SRPM URL: http://fedorapeople.org/~brouhaha/python-pyphen/python-pyphen-0.7-3.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1yq4dfXGTia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 --- Comment #2 from Eric Smith space...@gmail.com --- Spec URL: http://fedorapeople.org/~brouhaha/python-pyphen/python-pyphen.spec SRPM URL: http://fedorapeople.org/~brouhaha/python-pyphen/python-pyphen-0.7-2.fc19.src.rpm Thanks for reviewing! 1. I prefer to keep github Source0 for reasons we've discussed in other package reviews. If you feel strongly that this needs to change, let me know, and I'll do it. 2. I don't understand what you mean by missed a unowned dir; the output of rpm -qlvp looks good to me. It contains (and owns) the directory, the directory contents, and the egg-info, and doesn't appear to contain anything it shouldn't. In fact, timestamps aside, I get exactly the same listing whether I use my original files section or the one you propose. However, I've made the change. (If we didn't use a BuildRoot, it certainly wouldn't work to glob all of python_sitelib, but with a BuildRoot there doesn't seem to be any issue with it, and it appears that a lot of RPMs of Python libraries do that.) 3. The purpose of requiring hyphen-en is that I want to add a %check section that does a subset of the upstream unit tests, and wanted to have one language available for that. However, I haven't added that yet, and it would be a BuildRequires rather than a Requires, so I've dropped the Requires. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TQ8f0qw1GYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634
--- Comment #3 from Michael Schwendt bugs.mich...@gmx.net ---
Eric, rest assured,
%{python_sitelib}/*
is an entirely valid way to include _anything_ in the %{python_sitelib} dir
without introducing unowned directories.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ki3dgjdP5Sa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||space...@gmail.com Flags||needinfo?(space...@gmail.co ||m) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LV0yepJjSca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 Eric Smith space...@gmail.com changed: What|Removed |Added Flags|needinfo?(space...@gmail.co | |m) | --- Comment #4 from Eric Smith space...@gmail.com --- Chris, what further info is needed? I changed the Files section per your request, even though it has been confirmed as unnecessary. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JpEoWZtB4ia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 --- Comment #5 from Christopher Meng cicku...@gmail.com --- I need URLs.. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zsYUq4MHGya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 --- Comment #6 from Eric Smith space...@gmail.com --- I posted the updated URLs at the top of comment 2 above, but here they are again: Spec URL: http://fedorapeople.org/~brouhaha/python-pyphen/python-pyphen.spec SRPM URL: http://fedorapeople.org/~brouhaha/python-pyphen/python-pyphen-0.7-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wne91abGtBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=a2rwN3msGHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634 Eric Smith space...@gmail.com changed: What|Removed |Added Blocks||986608 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=b5aWOs5ZEVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 986634] Review Request: python-pyphen - Pure Python module to hyphenate text
https://bugzilla.redhat.com/show_bug.cgi?id=986634
--- Comment #1 from Christopher Meng cicku...@gmail.com ---
Issues:
1. Please use
https://pypi.python.org/packages/source/P/Pyphen/Pyphen-0.7.tar.gz
as Source0.
2. In %files section, you shouldn't use glob too much, and so you've missed a
unowned dir, so
%{python_sitelib}/*
should be:
%{python_sitelib}/pyphen
%{python_sitelib}/Pyphen-%{version}-py%{python_version}.egg-info
3. I'm not sure about
Requires: hyphen-en
Can we let yum-langpack to choose the appropriate lang?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=HRGgHtlEJ2a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
