[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-modernize-0.2-2.fc18 Resolution|--- |ERRATA Last Closed||2013-08-20 20:09:47 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- python-modernize-0.2-2.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KAdj0QH6SIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-modernize-0.2-2.fc18 |python-modernize-0.2-2.fc19 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- python-modernize-0.2-2.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FKxSC7BB6ba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- Package python-modernize-0.2-2.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing python-modernize-0.2-2.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-13959/python-modernize-0.2-2.fc18 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=W2hhEmduara=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WMTvWreYdza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-modernize-0.2-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-modernize-0.2-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rDpM03vlx0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-modernize-0.2-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-modernize-0.2-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tWoQvZooNua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6X7fAOBzS7a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bKNFHVIWwra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153 --- Comment #9 from Christopher Meng cicku...@gmail.com --- Hmm...You forgot to change the flag... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=w4PtK6VaA1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153 Toshio Ernie Kuratomi a.bad...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pWR542ItRpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QIJP7r9BUYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153
--- Comment #7 from Michael Schwendt bugs.mich...@gmx.net ---
The '*' wildcard _never_ results in an unowned directory, except if the
_parent_ directory (and the parent's parent, and so on) belong into the
package. Hence
%{python_sitelib}/*
includes _anything_ in /usr/lib/python2.7/site-packages/ (and anything includes
directories). The guidelines don't comment on that, because that's the trivial
case. On the contrary, if it had been
%{python_sitelib}/libmodernize/*
the libmodernize directory would have been unowned:
https://fedoraproject.org/wiki/Packaging:UnownedDirectories#Wildcarding_Files_inside_a_Created_Directory
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=wXJfYqVBtsa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153 --- Comment #8 from Toshio Ernie Kuratomi a.bad...@gmail.com --- New Package SCM Request === Package Name: python-modernize Short Description: Modernizes Python code for eventual Python 3 migration Owners: toshio Branches: f17 f18 f19 devel InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RDbNbwIurEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153
--- Comment #2 from Toshio Ernie Kuratomi a.bad...@gmail.com ---
Thanks for reviewing!
Spec URL: http://toshio.fedorapeople.org/packages/python-modernize.spec
SRPM URL:
http://toshio.fedorapeople.org/packages/python-modernize-0.2-2.fc17.src.rpm
1. Good catch on the BR for python-setuptools. Added.
2. That's stylistic. I prefer the wildcard for everything in the directory. I
know that some people would rather be notified if the files in that directory
change but I'd rather have the package build succeed and look at the sources
when necessary (when updating a stable release). [One note: you're supposed to
add a trailing slash to directories that you own so that it's obvious to people
that you meant to include a directory recursively. So:
%{python_sitelib}/libmodernize/ and
%{python_sitelib}/%{srcname}-%{version}-py%{python_version}.egg-info/ are
correct)
3 4. Thanks! yeah, I'm only pushing this back as far as EPEL6 (if that) so
those are good changes. Fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=3tfl8LjF46a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153 --- Comment #3 from Christopher Meng cicku...@gmail.com --- Well, Issue 2 is a problem Unowned directory. If you use wildcard, you can include all py files but not directory itself, that's why I want you to change. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qlz33Z9clOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153 --- Comment #4 from Toshio Ernie Kuratomi a.bad...@gmail.com --- What directory is unowned? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=k0PiMaFxCUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153
--- Comment #5 from Christopher Meng cicku...@gmail.com ---
%{python_sitelib}/libmodernize itself
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=cxNGr1sq08a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153 --- Comment #6 from Toshio Ernie Kuratomi a.bad...@gmail.com --- The wildcard should include that. In testing, it looks owned to me: $ rpm -qpl python-modernize-0.2-2.fc17.noarch.rpm |egrep 'libmodernize$' /usr/lib/python2.7/site-packages/libmodernize -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9dHhnhA8JOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gVSpi93iYSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987153] Review Request: python-modernize - Modernizes Python code for eventual Python 3 migration
https://bugzilla.redhat.com/show_bug.cgi?id=987153
--- Comment #1 from Christopher Meng cicku...@gmail.com ---
1. Do you think adding BR for python-setuptools is OK?
2. %files
%{python_sitelib}/*
should be
%{python_sitelib}/libmodernize
%{python_sitelib}/%{srcname}-%{version}-py%{python_version}.egg-info
3. Remove these
# sitelib for noarch packages, sitearch for others (remove the unneeded one)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c from
distutils.sysconfig import get_python_lib; print(get_python_lib()))}
%{!?python_sitearch: %global python_sitearch %(%{__python} -c from
distutils.sysconfig import get_python_lib; print(get_python_lib(1)))}
4. No need to
rm -rf %{buildroot}
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=woM9gcyCB7a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
