[Bug 987619] Review Request: python-parse - Opposite of format()
https://bugzilla.redhat.com/show_bug.cgi?id=987619 Fabian Deutsch changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Flags|needinfo?(fdeutsch@redhat.c | |om) | --- Comment #8 from Fabian Deutsch --- (In reply to Matěj Cepl from comment #6) > (In reply to Fabian Deutsch from comment #5) > > A new build: > > http://koji.fedoraproject.org/koji/taskinfo?taskID=5853544 > > > > and a > > > > Package Review > > == > > Could you explain me please in a plain English what's wrong with my package? IMO nothing. I just wanted to speed up the review process. (In reply to Christopher Meng from comment #7) > Hmm...I think I should leave here. Sorry Christopher, I didn't want to step on your toes. I just wanted to do an informal review to support the review of the package. This is also suggeste di nthe packaging guidelines. It wasn't my intention that you drop the review - as said, I actually just wanted to support it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3EOHFcPoxE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987619] Review Request: python-parse - Opposite of format()
https://bugzilla.redhat.com/show_bug.cgi?id=987619 Christopher Meng changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|cicku...@gmail.com |nob...@fedoraproject.org Flags|needinfo?(cicku...@gmail.co |needinfo?(fdeutsch@redhat.c |m) |om) --- Comment #7 from Christopher Meng --- Hmm...I think I should leave here. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fLdTcBnMbY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987619] Review Request: python-parse - Opposite of format()
https://bugzilla.redhat.com/show_bug.cgi?id=987619 Matěj Cepl changed: What|Removed |Added Flags||needinfo?(cicku...@gmail.co ||m) --- Comment #6 from Matěj Cepl --- (In reply to Fabian Deutsch from comment #5) > A new build: > http://koji.fedoraproject.org/koji/taskinfo?taskID=5853544 > > and a > > Package Review > == Could you explain me please in a plain English what's wrong with my package? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LNDo9S9dxw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987619] Review Request: python-parse - Opposite of format()
https://bugzilla.redhat.com/show_bug.cgi?id=987619
--- Comment #5 from Fabian Deutsch ---
A new build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5853544
and a
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[y]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 3 files have unknown license. Detailed output of
licensecheck in /home/fdeutsch/tmp/python-parse/python-
parse-1.6.2-3.el7.src/review-python-parse/licensecheck.txt
[X]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
[x]: Packages must not store files under /srv, /opt or /usr/local
Note: Cannot unpack rpms (using --prebuilt?)
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
Note: Re-using old build in mock
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No fil
[Bug 987619] Review Request: python-parse - Opposite of format()
https://bugzilla.redhat.com/show_bug.cgi?id=987619 --- Comment #4 from Matěj Cepl --- Auch, make it http://mcepl.fedorapeople.org/tmp/python-parse-1.6.2-3.el7.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DuEDO5K3GE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987619] Review Request: python-parse - Opposite of format()
https://bugzilla.redhat.com/show_bug.cgi?id=987619 --- Comment #3 from Matěj Cepl --- Scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=5650117 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MsuRJHRHAe&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987619] Review Request: python-parse - Opposite of format()
https://bugzilla.redhat.com/show_bug.cgi?id=987619 --- Comment #2 from Matěj Cepl --- New versions at http://mcepl.fedorapeople.org/tmp/python-parse-1.6.2-2.el7.src.rpm http://mcepl.fedorapeople.org/tmp/python-parse.spec Thank you for the review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SLZFvkVlCw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987619] Review Request: python-parse - Opposite of format()
https://bugzilla.redhat.com/show_bug.cgi?id=987619 Christopher Meng changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review? --- Comment #1 from Christopher Meng --- changelog is not good :( And why not BR python-setuptools? Besides a suggestion: Don't leave too many empty lines. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QYfd0macDQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987619] Review Request: python-parse - Opposite of format()
https://bugzilla.redhat.com/show_bug.cgi?id=987619 Matěj Cepl changed: What|Removed |Added Blocks||987622 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3oYxGUlqD3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
