[Bug 989015] Review Request: makeself - Make self-extractable archives on Unix
https://bugzilla.redhat.com/show_bug.cgi?id=989015 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added CC||ke...@scrye.com Assignee|cicku...@gmail.com |ke...@scrye.com Flags|fedora-review+ |fedora-review? --- Comment #8 from Kevin Fenzi ke...@scrye.com --- Hey Christopher, I see that you are not a sponsor and Dridi needs a sponsor for this initial package. I'll go ahead and look things over and look at sponsoring Dridi here soon. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XCQ13vvgeta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989015] Review Request: makeself - Make self-extractable archives on Unix
https://bugzilla.redhat.com/show_bug.cgi?id=989015 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from Kevin Fenzi ke...@scrye.com --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 8075530b2ad0a2fbd4bffa80a96eb2ea release-2.2.0.tar.gz 8075530b2ad0a2fbd4bffa80a96eb2ea release-2.2.0.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. rpmlint says: makeself.noarch: W: spelling-error Summary(en_US) extractable - ex tractable, ex-tractable, extract able makeself.noarch: W: spelling-error %description -l en_US extractable - ex tractable, ex-tractable, extract able makeself.noarch: W: spelling-error %description -l en_US gz - g, z, gs makeself.noarch: W: spelling-error %description -l en_US uncompress - uncompressed, compression, compressor makeself.src: W: spelling-error Summary(en_US) extractable - ex tractable, ex-tractable, extract able makeself.src: W: spelling-error %description -l en_US extractable - ex tractable, ex-tractable, extract able makeself.src: W: spelling-error %description -l en_US gz - g, z, gs makeself.src: W: spelling-error %description -l en_US uncompress - uncompressed, compression, compressor 2 packages and 0 specfiles checked; 0 errors, 8 warnings. all can be ignored. This is a pretty simple package. ;) I don't see any further issues, so this package is APPROVED and I will sponsor you. You can continue the process from: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner Please let me know if you have any questions or get stuck anywhere. ;) Welcome! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CdacmwPqACa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989015] Review Request: makeself - Make self-extractable archives on Unix
https://bugzilla.redhat.com/show_bug.cgi?id=989015 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #10 from Christopher Meng cicku...@gmail.com --- Thanks, Kevin. I forgot to reset. Dridi is a nice guy. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Wh4LTZhS1Ha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989015] Review Request: makeself - Make self-extractable archives on Unix
https://bugzilla.redhat.com/show_bug.cgi?id=989015 Dridi Boukelmoune dridi.boukelmo...@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Alias||makeself -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9qBUmE8GqAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989015] Review Request: makeself - Make self-extractable archives on Unix
https://bugzilla.redhat.com/show_bug.cgi?id=989015 --- Comment #3 from Christopher Meng cicku...@gmail.com --- Oh... You forgot to bump the release number, each time you've fixed some problems you should bump it from n to n+1. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nTAzG7zRGsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989015] Review Request: makeself - Make self-extractable archives on Unix
https://bugzilla.redhat.com/show_bug.cgi?id=989015 --- Comment #4 from Dridi Boukelmoune dridi.boukelmo...@gmail.com --- I thought it wouldn't matter for a package that hasn't been published yet. Spec URL: https://bitbucket.org/dridi/fedora_packages/downloads/makeself.spec SRPM URL: https://bitbucket.org/dridi/fedora_packages/downloads/makeself-2.2.0-2.fc19.src.rpm Updated! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eMGIO7fhmMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989015] Review Request: makeself - Make self-extractable archives on Unix
https://bugzilla.redhat.com/show_bug.cgi?id=989015 --- Comment #5 from Christopher Meng cicku...@gmail.com --- Your SRPM name doesn't match the spec name, m-akeself? makeself? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xd4IiMz6pTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989015] Review Request: makeself - Make self-extractable archives on Unix
https://bugzilla.redhat.com/show_bug.cgi?id=989015 --- Comment #6 from Dridi Boukelmoune dridi.boukelmo...@gmail.com --- I don't understand, I have this: $ curl -L https://bitbucket.org/dridi/fedora_packages/downloads/makeself-2.2.0-2.fc19.src.rpm 2/dev/null | rpm -qpi - Name: makeself Version : 2.2.0 Release : 2.fc19 Architecture: noarch [...] -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6azdz6itg1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989015] Review Request: makeself - Make self-extractable archives on Unix
https://bugzilla.redhat.com/show_bug.cgi?id=989015 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Christopher Meng cicku...@gmail.com --- Well, the source downloaded from URL via browser will be renamed to m-akeselfxxx...Something wrong with bb itself. But if I use wget -N or curl, because bitbucket is blocked in China, I can't continue... Never mind I changed the SRPM name so it can match the name now. Package is good. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nhliaRnYwOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989015] Review Request: makeself - Make self-extractable archives on Unix
https://bugzilla.redhat.com/show_bug.cgi?id=989015
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||cicku...@gmail.com
Assignee|nob...@fedoraproject.org|cicku...@gmail.com
Flags||fedora-review?
--- Comment #1 from Christopher Meng cicku...@gmail.com ---
WhoooBitbucket is blocked in China...
1. When will you stop replacing the copying file? That means, when will
upstream fix the license issue?
2. Remove rm -fr %{buildroot}
3. You don't need to specify the perms of
%attr(644, -, -) %{_libexecdir}/*
%attr(755, -, -) %{_bindir}/*
You should install them with -m option and 755/644 as you want. But, you use cp
to install, so I hope you can change or modify to the correct way.
No matter install or cp, please don't forget adding -p to preserve the
timestamp.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=t9DYnQiBcoa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989015] Review Request: makeself - Make self-extractable archives on Unix
https://bugzilla.redhat.com/show_bug.cgi?id=989015 --- Comment #2 from Dridi Boukelmoune dridi.boukelmo...@gmail.com --- 1. When will you stop replacing the copying file? That means, when will upstream fix the license issue? Already done in the master branch: https://github.com/megastep/makeself/issues/22 Spec URL: https://bitbucket.org/dridi/fedora_packages/downloads/makeself.spec SRPM URL: https://bitbucket.org/dridi/fedora_packages/downloads/makeself-2.2.0-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=E6i1tjzNAwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989015] Review Request: makeself - Make self-extractable archives on Unix
https://bugzilla.redhat.com/show_bug.cgi?id=989015 Dridi Boukelmoune dridi.boukelmo...@gmail.com changed: What|Removed |Added CC||dridi.boukelmo...@gmail.com Blocks||954107 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QaJALYVdBJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
