[Bug 990279] Review Request: diskimage-builder - Image building tools for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=990279 Jeff Peeler jpee...@redhat.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Flags|fedora-cvs+ |fedora-cvs? --- Comment #10 from Jeff Peeler jpee...@redhat.com --- Package Change Request == Package Name: diskimage-builder New Branches: f19 el6 Owners: jpeeler, sdake, pbrady InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fOifK4lg0xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990279] Review Request: diskimage-builder - Image building tools for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=990279 Matthew Farrellee m...@redhat.com changed: What|Removed |Added Blocks||998702 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4HnNFUSFbKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990279] Review Request: diskimage-builder - Image building tools for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=990279 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SKnKEsSj8Ta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990279] Review Request: diskimage-builder - Image building tools for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=990279 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ns2VfuSX3Ka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990279] Review Request: diskimage-builder - Image building tools for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=990279 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UOHshIwHkea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990279] Review Request: diskimage-builder - Image building tools for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=990279 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Invalid branch f20 requested, fedora-review flag not set to '+' -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sK6tmGBU0Ta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990279] Review Request: diskimage-builder - Image building tools for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=990279 Steven Dake sd...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Steven Dake sd...@redhat.com --- APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Q1n3PZrFvna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990279] Review Request: diskimage-builder - Image building tools for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=990279 Jeff Peeler jpee...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Jeff Peeler jpee...@redhat.com --- Sorry, I assumed f20 had branched already. New Package SCM Request === Package Name: diskimage-builder Short Description: Image building tools for OpenStack Owners: jpeeler, sdake, pbrady Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qBr3qZOnnTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990279] Review Request: diskimage-builder - Image building tools for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=990279
Steven Dake sd...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #1 from Steven Dake sd...@redhat.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[X]: Package uses nothing in %doc for runtime.
[X]: Package is not known to require ExcludeArch.
[X]: Package complies to the Packaging Guidelines
[X]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), Unknown or generated, *No copyright* Apache (v2.0).
1 files have unknown license. Detailed output of licensecheck in
/opt/stack/heat/990279-diskimage-builder/licensecheck.txt
[X]: Package consistently uses macro is (instead of hard-coded directory
names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Package must own all directories that it creates.
[X]: Package does not own files or directories owned by other packages.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 20480 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Python:
[X]: Python eggs must not download any dependencies during the build process.
[X]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[-]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[X]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[X]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original
[Bug 990279] Review Request: diskimage-builder - Image building tools for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=990279 --- Comment #2 from Steven Dake sd...@redhat.com --- Not blocker: Please file upstream bugs for missing manual pages as separate bugs in launchpad. Would suggest working with upstream to fix the errors printed out by rpmlint - they look like errors in the code base. Could probably submit patches to fix these problems after filing bugs. Blockers: non-readble sudoers look like a problem. If you can convince this is not a problem I'll approve the package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i1GGz5ez7Ga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990279] Review Request: diskimage-builder - Image building tools for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=990279 --- Comment #3 from Steven Dake sd...@redhat.com --- Jeff, After fixing small sudoers problem, please submit scm request with cc list of jpeeler, sdake, pbrady -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KbobkMq5zXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990279] Review Request: diskimage-builder - Image building tools for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=990279 --- Comment #4 from Jeff Peeler jpee...@redhat.com --- I believe the sudoers.d file is supposed to have permissions of 0440 for security reasons (versions of sudo after 1.8.5 are reportedly less picky). So I'm going to leave it as is, rebase with upstream so patches can be dropped, and will submit the SCM request. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=okzSGIi4XYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990279] Review Request: diskimage-builder - Image building tools for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=990279 Jeff Peeler jpee...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Jeff Peeler jpee...@redhat.com --- (I am assuming Steve is OK with my previous comment.) New Package SCM Request === Package Name: diskimage-builder Short Description: Image building tools for OpenStack Owners: jpeeler, sdake, pbrady Branches: f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8AR3YvXwnua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990279] Review Request: diskimage-builder - Image building tools for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=990279 Steven Dake sd...@redhat.com changed: What|Removed |Added CC||sd...@redhat.com Assignee|nob...@fedoraproject.org|sd...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s10up7suPIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990279] Review Request: diskimage-builder - Image building tools for OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=990279 Steven Dake sd...@redhat.com changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IU4t7Uiw4Oa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
