[Bug 990544] Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers
https://bugzilla.redhat.com/show_bug.cgi?id=990544 Palle Ravn changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed||2021-06-04 19:27:23 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 990544] Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers
https://bugzilla.redhat.com/show_bug.cgi?id=990544 Palle Ravn changed: What|Removed |Added Flags|needinfo?(ravn...@gmail.com | |) | --- Comment #14 from Palle Ravn --- (In reply to Otto Urpelainen from comment #13) > This review request is very old. Do you still intend to complete it? If so, > I can review, unless Christoper is still interested. If not, please either > close the issue, or do nothing, in which case automation will close it > automatically in one month. I'm sorry, I don't intent to complete this. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 990544] Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers
https://bugzilla.redhat.com/show_bug.cgi?id=990544 Otto Urpelainen changed: What|Removed |Added CC||otu...@iki.fi Flags||needinfo?(ravn...@gmail.com ||) --- Comment #13 from Otto Urpelainen --- This review request is very old. Do you still intend to complete it? If so, I can review, unless Christoper is still interested. If not, please either close the issue, or do nothing, in which case automation will close it automatically in one month. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
needinfo canceled: [Bug 990544] Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers
Product: Fedora Version: rawhide Component: Package Review Package Review has canceled Package Review 's request for Christopher Meng 's needinfo: Bug 990544: Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers https://bugzilla.redhat.com/show_bug.cgi?id=990544 --- Comment #12 from Package Review --- This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 990544] Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers
https://bugzilla.redhat.com/show_bug.cgi?id=990544 --- Comment #10 from Christopher Meng i...@cicku.me --- Lift needinfo on me if you are ready. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990544] Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers
https://bugzilla.redhat.com/show_bug.cgi?id=990544 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||ravn...@gmail.com Flags||needinfo?(ravn...@gmail.com ||) -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990544] Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers
https://bugzilla.redhat.com/show_bug.cgi?id=990544 Palle Ravn ravn...@gmail.com changed: What|Removed |Added Flags|needinfo?(ravn...@gmail.com | |) | --- Comment #9 from Palle Ravn ravn...@gmail.com --- I have lost the SPEC file. I hope to be able to remake it during the weekend. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990544] Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers
https://bugzilla.redhat.com/show_bug.cgi?id=990544 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review? --- Comment #8 from Christopher Meng cicku...@gmail.com --- 404. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990544] Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers
https://bugzilla.redhat.com/show_bug.cgi?id=990544 Palle Ravn ravn...@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #7 from Palle Ravn ravn...@gmail.com --- Just updated them, all files can be found at http://zom.dk/mangler/ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Q330aKXtiGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990544] Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers
https://bugzilla.redhat.com/show_bug.cgi?id=990544 --- Comment #6 from Christopher Meng cicku...@gmail.com --- (In reply to Palle Ravn from comment #5) OK. Where is your new SPEC/SRPM? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zJhnHhosDZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990544] Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers
https://bugzilla.redhat.com/show_bug.cgi?id=990544
--- Comment #2 from Palle Ravn ravn...@gmail.com ---
(In reply to Christopher Meng from comment #1)
1. Can you tell me why removing
rm -f %{buildroot}%{_exec_prefix}/%{_lib}/libventrilo3.so
but not moving them to -devel?
I was unaware of the devel part of packaging, as I never had the need. I have
added a -devel package including .a .h and .so files.
2. Have you tried %configure --disable-static to avoid generating static
libs?
Yes, and it did not change the static rpath.
3. You should use %{_libdir} instead of %{_exec_prefix}/%{_lib}
Fixed.
4. %{_datarootdir} can be %{_datadir} ;)
Works better with vim highlighting, thanks :D
5. Package ships 2 license file, but you only include one.
Both included.
All files are at www.zom.dk/mangler, note that I have not changed the revision
number.
I will of course notify upstream about the wrong fsf address in one of the
source files.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=pO9IF8N44Fa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990544] Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers
https://bugzilla.redhat.com/show_bug.cgi?id=990544
--- Comment #3 from Christopher Meng cicku...@gmail.com ---
Note if you split out devel package, don't include static libs.
1. Please remove them via some commands like this:
find %{buildroot} -name '*.*a' -delete
2. Don't adda BR of gcc-c++, please remove.
3. You'd better add isa macro to devel package Requires:
Requires: %{name}%{?_isa} = %{version}-%{release}
4. This package has bundled many libraries.
GPL (v2 or later) (with incorrect FSF address)
--
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/mangler-1.2.5/libventrilo3/ventrilo3_handshake.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/mangler-1.2.5/libventrilo3/ventrilo_algo.h
This is from libventrilo, which hasn't been packaged yet in Fedora.
https://github.com/haxar/libventrilo3
5. This package has iphone and android files, I don't know if they are useful
or not? Because licensecheck has found many license issues, but most are those
files, so I have this question.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=OfZJnkv23Da=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990544] Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers
https://bugzilla.redhat.com/show_bug.cgi?id=990544
--- Comment #4 from Michael Schwendt bugs.mich...@gmx.net ---
This is from libventrilo, which hasn't been packaged yet in Fedora.
https://github.com/haxar/libventrilo3
It's part of the Mangler project, isn't it?
https://github.com/haxar?tab=repositories
Find out about the release cycle of this lib. Is it updated often and
separately from Mangler? Else you could make the mangler.src.rpm build
libventrilo3 and libventrilo3-devel packages, so if anything else wants to
build with the lib, it would be available. There could still be a separate
libventrilo3.src.rpm be added to the package collection at a later point (and
depending on how upstream maintains these components).
Requires: gtkmm24 speex gsm espeak xosd
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
%{_datadir}/applications/mangler.desktop
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
%{_libdir}/libventrilo3.la
Don't include libtool archives. It's explained in the static lib section:
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=AI6sE8k5GKa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990544] Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers
https://bugzilla.redhat.com/show_bug.cgi?id=990544
--- Comment #5 from Palle Ravn ravn...@gmail.com ---
(In reply to Christopher Meng from comment #3)
Note if you split out devel package, don't include static libs.
1. Please remove them via some commands like this:
find %{buildroot} -name '*.*a' -delete
All static libs should be removed now.
2. Don't adda BR of gcc-c++, please remove.
Done.
3. You'd better add isa macro to devel package Requires:
Requires:%{name}%{?_isa} = %{version}-%{release}
Done.
4. This package has bundled many libraries.
GPL (v2 or later) (with incorrect FSF address)
--
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/mangler-1.2.5/
libventrilo3/ventrilo3_handshake.c
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/mangler-1.2.5/
libventrilo3/ventrilo_algo.h
Using rpmlint I only get an FSF address error from the debug rpm, only listing
the file ventrilo3_handshake.c. However, the license should still be okay as it
is GPLv3. If I notify upstream about the incorrect addresses this should not be
a blocker.
5. This package has iphone and android files, I don't know if they are
useful or not? Because licensecheck has found many license issues, but most
are those files, so I have this question.
I can remove those, but it doesn't change anything in the final RPM. Likewise,
the source RPM also includes the android and iphone files, as it contains the
original tar file.
(In reply to Michael Schwendt from comment #4)
This is from libventrilo, which hasn't been packaged yet in Fedora.
https://github.com/haxar/libventrilo3
It's part of the Mangler project, isn't it?
https://github.com/haxar?tab=repositories
Find out about the release cycle of this lib. Is it updated often and
separately from Mangler? Else you could make the mangler.src.rpm build
libventrilo3 and libventrilo3-devel packages, so if anything else wants to
build with the lib, it would be available. There could still be a separate
libventrilo3.src.rpm be added to the package collection at a later point
(and depending on how upstream maintains these components).
It is part of Mangler and I can't find anyone else using this library. If it is
not strictly required to have a separate library package, I would keep
libventrilo3 and mangler in the same package, and split it up later if
necessary.
Requires: gtkmm24 speex gsm espeak xosd
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
Removed.
%{_datadir}/applications/mangler.desktop
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-
install_usage
Now running desktop-file-validate as part of %install.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=rMnMhL778ia=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990544] Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers
https://bugzilla.redhat.com/show_bug.cgi?id=990544
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
CC||cicku...@gmail.com
--- Comment #1 from Christopher Meng cicku...@gmail.com ---
1. Can you tell me why removing
rm -f %{buildroot}%{_exec_prefix}/%{_lib}/libventrilo3.so
but not moving them to -devel?
2. Have you tried %configure --disable-static to avoid generating static libs?
3. You should use %{_libdir} instead of %{_exec_prefix}/%{_lib}
4. %{_datarootdir} can be %{_datadir} ;)
5. Package ships 2 license file, but you only include one.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=6ONaHR8X7Ta=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
