[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|jblas-1.2.3-2.fc19 |jblas-1.2.3-2.fc18 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- jblas-1.2.3-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CK8nmEiFuHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||jblas-1.2.3-2.fc19 Resolution|--- |ERRATA Last Closed||2013-08-14 23:03:30 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- jblas-1.2.3-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CWnfP0p675a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- jblas-1.2.3-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3S85YlxfjDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627
Peter Lemenkov lemen...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||lemen...@gmail.com
Assignee|nob...@fedoraproject.org|lemen...@gmail.com
Flags||fedora-review?
--- Comment #5 from Peter Lemenkov lemen...@gmail.com ---
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is not completely silent, but its messages are harmless can be
ignored:
work ~/rpmbuild/SPECS: rpmlint ~/Desktop/jblas-*
jblas.src:52: W: configure-without-libdir-spec
^^^ I advise you to use %configure instead of ./configure
jblas-javadoc.x86_64: W: spelling-error Summary(en_US) Javadocs - Java docs,
Java-docs, Avocados
4 packages and 0 specfiles checked; 0 errors, 2 warnings.
work ~/rpmbuild/SPECS:
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license (New
BSD, no advertising, 3 clause).
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.
work ~/rpmbuild/SOURCES: sha256sum jblas-1.2.3.tar.gz*
3061fcae0c9b2d2e5ecc1e79ca9af7f05502c4f3dd4fd9adc98bd9df1bd720fb
jblas-1.2.3.tar.gz
3061fcae0c9b2d2e5ecc1e79ca9af7f05502c4f3dd4fd9adc98bd9df1bd720fb
jblas-1.2.3.tar.gz.1
work ~/rpmbuild/SOURCES:
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
+ The package stores shared library files in some of the dynamic linker's
default paths, and it calls ldconfig in %post and %postun.
+ The package does NOT bundle copies of system libraries.
0 The package is not designed to be relocatable.
- The package MUST own all directories that it creates. Unowned directory -
/usr/lib64/jblas/ . Please either add this
%dir %{_libdir}/%{name}/
to the %files section, or just use
%{_libdir}/%{name}
instead of more narrowed
%{_libdir}/%{name}/lib%{name}.so
+ The package doesn't list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No static libraries.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
+ All filenames in rpm packages are valid UTF-8.
Please fix the only remaining issue with unowned directory before uploading to
Fedora Git. This package is
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=wElrvUR4AYa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #6 from Peter Lemenkov lemen...@gmail.com --- Unblocking FE-NEEDSPONSOR - I've just sponsored Zbigniew Jędrzejewski-Szmek. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=P7LYNK9aDNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627 --- Comment #7 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- (In reply to Peter Lemenkov from comment #5) Thank you for the review! REVIEW: work ~/rpmbuild/SPECS: rpmlint ~/Desktop/jblas-* jblas.src:52: W: configure-without-libdir-spec ^^^ I advise you to use %configure instead of ./configure I think that %configure will add additional options, which are not supported by this ./configure, which is a custom script here, not a real standard one. I think it should stay the way it is. - The package MUST own all directories that it creates. Unowned directory - /usr/lib64/jblas/ . Please either add this Fixed. APPROVED. Updated spec: http://in.waw.pl/~zbyszek/fedora/jblas.spec Updated srpm: http://in.waw.pl/~zbyszek/fedora/jblas-1.2.3-2.fc19.src.rpm koji f19: http://koji.fedoraproject.org/koji/taskinfo?taskID=5779036 koji f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=5779029 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n95fEdczTda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Peter Lemenkov lemen...@gmail.com --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #7) (In reply to Peter Lemenkov from comment #5) Thank you for the review! REVIEW: work ~/rpmbuild/SPECS: rpmlint ~/Desktop/jblas-* jblas.src:52: W: configure-without-libdir-spec ^^^ I advise you to use %configure instead of ./configure I think that %configure will add additional options, which are not supported by this ./configure, which is a custom script here, not a real standard one. I think it should stay the way it is. - The package MUST own all directories that it creates. Unowned directory - /usr/lib64/jblas/ . Please either add this Fixed. APPROVED. Updated spec: http://in.waw.pl/~zbyszek/fedora/jblas.spec Updated srpm: http://in.waw.pl/~zbyszek/fedora/jblas-1.2.3-2.fc19.src.rpm koji f19: http://koji.fedoraproject.org/koji/taskinfo?taskID=5779036 koji f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=5779029 Ok, good. Proceed with the following: * https://fedoraproject.org/wiki/Package_SCM_admin_requests -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3qOj3TS6Oqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627 --- Comment #9 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- New Package SCM Request === Package Name: jblas Short Description: Java bindings for BLAS Owners: zbyszek Branches: f18 f19 InitialCC: peter java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nAiPviCoRXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rCJBfSgDuUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fEldlYYh5ua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WZo8Igf18Aa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- jblas-1.2.3-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/jblas-1.2.3-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Y7O6KsMHmna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- jblas-1.2.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/jblas-1.2.3-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vZSi66L2Y6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=g7yBTqEa1xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627 --- Comment #4 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- FC 20 koji scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=5693733 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AbHCtbjCR5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627 --- Comment #1 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- Package is rpmlint clean, except for two warning which I think are OK: - javadocs is marked as misspelt, but other javadoc packages use this spelling - configure-without-libdir-spec, but this is not a real configure script, but a custom thing and the proper paths *are* given to it, with differently named parameters. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=99tuFHwDg2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sXGbE04Z8ba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627
Veaceslav Mindru mind...@gmail.com changed:
What|Removed |Added
CC||mind...@gmail.com
--- Comment #2 from Veaceslav Mindru mind...@gmail.com ---
Hello,
comments on SPEC
as far as i can judge this is EPEL6 compliant, and looks semantic clean enough
though i have some doubts if macros is allowed to be used along with static
links here
cp -r javadoc $RPM_BUILD_ROOT%{_javadocdir}/%{name}
I will leave this with others to judge.
VM
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=vMgtMV35aha=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990627] Review Request: jblas - Java bindings for BLAS
https://bugzilla.redhat.com/show_bug.cgi?id=990627
--- Comment #3 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
(In reply to Veaceslav Mindru from comment #2)
Thank you for the quick review.
i have some doubts if macros is allowed to be used along with
static links here
Hm, there are no links, I think.
I took this part verbatim from
http://fedoraproject.org/wiki/Packaging:Java#Specfile_Template, so it's
probably fine.
cp -r javadoc $RPM_BUILD_ROOT%{_javadocdir}/%{name}
I will leave this with others to judge.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=vZJYlsTcPLa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
