[Bug 991400] Review Request: myrulib - E-Book Library Manager
https://bugzilla.redhat.com/show_bug.cgi?id=991400 Vasiliy Glazov changed: What|Removed |Added Resolution|CANTFIX |WONTFIX -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991400] Review Request: myrulib - E-Book Library Manager
https://bugzilla.redhat.com/show_bug.cgi?id=991400 Vasiliy Glazov changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CANTFIX Flags|needinfo?(vasc...@gmail.com | |) | Last Closed||2013-12-11 01:58:34 --- Comment #14 from Vasiliy Glazov --- No. I can't solve all this problems. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991400] Review Request: myrulib - E-Book Library Manager
https://bugzilla.redhat.com/show_bug.cgi?id=991400 Igor Gnatenko changed: What|Removed |Added CC||vasc...@gmail.com Flags||needinfo?(vasc...@gmail.com ||) --- Comment #13 from Igor Gnatenko --- are you sure that you want to maintain this pkg? Seems like this pkg is SHI~. if want, you should do: * Add to F coolreader (crengine subpackage) * Add to F wxBZipStream * Add "BuildRequires: libxml2-devel" to spec * Add "BuildRequires: wxsqlite3-devel = 3.0.5" to spec * %configure options should be --without-icu \ --with-expat \ --with-reader \ --without-bzip2 \ --without-sqlite \ --without-wxsqlite \ --without-strip * Add to %prep section rm -rf 3rdparty/ * Add to %build section autoreconf -vfi * Apply patch --- configure.in.orig2013-09-03 22:30:43.0 +0400 +++ configure.in2013-12-10 22:37:57.274923790 +0400 @@ -197,6 +197,10 @@ USE_WXSQL="builtin" fi +if test "x$USE_WXSQL" != "xbuiltin" ; then +PKG_CHECK_MODULES(WXSQL, wxsqlite-3.0.5 = 3.0.5, , USE_WXSQL="builtin") +fi + AC_MSG_CHECKING([for --with-locale]) AC_ARG_WITH([locale], [AS_HELP_STRING([--with-locale], [Include locale files into executable])], USE_LOCALE="$withval", USE_LOCALE="no") AC_MSG_RESULT([$USE_LOCALE]) @@ -280,7 +284,7 @@ WX_CXXFLAGS="-I\$(srcdir)/3rdparty/wxsqlite3/include $WX_CXXFLAGS" WX_LIBS="-lmrl_wxsqlite3 $WX_LIBS" else - WX_LIBS="-lwxsqlite3-2.8 $WX_LIBS" + WX_LIBS="$WXSQL_LIBS $WX_LIBS" fi dnl == * Write the same patches for other libs (which have pkgfile) and for sure fix crengine in configure.in This is first part. After this we could continue review ;) And I ask you again: are you sure want to maintain this SHI~ SHI~ SHI~ pkg -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991400] Review Request: myrulib - E-Book Library Manager
https://bugzilla.redhat.com/show_bug.cgi?id=991400 Igor Gnatenko changed: What|Removed |Added Status|NEW |ASSIGNED CC||i.gnatenko.br...@gmail.com Assignee|nob...@fedoraproject.org|i.gnatenko.br...@gmail.com Flags||fedora-review? --- Comment #12 from Igor Gnatenko --- Taken -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991400] Review Request: myrulib - E-Book Library Manager
https://bugzilla.redhat.com/show_bug.cgi?id=991400 --- Comment #11 from Christopher Meng --- 0.29.16 is out. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991400] Review Request: myrulib - E-Book Library Manager
https://bugzilla.redhat.com/show_bug.cgi?id=991400 --- Comment #10 from Vasiliy Glazov --- OK, I already done that and contact upstream developer to solve this issue. https://github.com/lintest/myrulib/issues/6 (In russian). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GHhSS9D2Hz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991400] Review Request: myrulib - E-Book Library Manager
https://bugzilla.redhat.com/show_bug.cgi?id=991400 --- Comment #9 from Michael Schwendt --- Hint: it can be helpful to "damage" the bundled sources, so if they are built with accidentally, the build would fail. "Damaging" can be anything, such as deleting a file or inserting something into it that would make the compiler fail. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=86IL0d4x32&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991400] Review Request: myrulib - E-Book Library Manager
https://bugzilla.redhat.com/show_bug.cgi?id=991400 --- Comment #8 from Antonio Trande --- (In reply to Vasiliy Glazov from comment #7) > I add BuildRequires: bzip2-devel, and configure --without-icu > --without-sqlite > In buildlog > http://koji.russianfedora.ru/koji/getfile?taskID=83453&name=build.log > you can see > Use Libxml2 parser library (default)? no > Use Expat XML parser instead of Libxml2? yes > Use FAXPP (Fast XML Pull Parser) library? no > Use builtin BZip2 library?no > Use builtin SQLite3 library? no > Use ICU for unicode collation?no > Use Cool Reader Engine? no > Use system logger: syslog?no > Include locale files into executable? no > Include links to the online collections? yes > Strip the executable file?no > Link wxWidgets as a static library? no > > Bundled Bzip2 and SQLite3 removed from build process. Or I must remove them > from sources? > http://fedoraproject.org/wiki/Packaging:Treatment_Of_Bundled_Libraries :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NPS9D1sX9A&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991400] Review Request: myrulib - E-Book Library Manager
https://bugzilla.redhat.com/show_bug.cgi?id=991400 --- Comment #7 from Vasiliy Glazov --- I add BuildRequires: bzip2-devel, and configure --without-icu --without-sqlite In buildlog http://koji.russianfedora.ru/koji/getfile?taskID=83453&name=build.log you can see Use Libxml2 parser library (default)? no Use Expat XML parser instead of Libxml2? yes Use FAXPP (Fast XML Pull Parser) library? no Use builtin BZip2 library?no Use builtin SQLite3 library? no Use ICU for unicode collation?no Use Cool Reader Engine? no Use system logger: syslog?no Include locale files into executable? no Include links to the online collections? yes Strip the executable file?no Link wxWidgets as a static library? no Bundled Bzip2 and SQLite3 removed from build process. Or I must remove them from sources? And I dont think that suffix .R in preliminary srpm change anything. You can take renamed srpm here https://dl.dropboxusercontent.com/u/1776041/myrulib-0.29.14-4.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=md9KGwEB59&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991400] Review Request: myrulib - E-Book Library Manager
https://bugzilla.redhat.com/show_bug.cgi?id=991400 --- Comment #6 from Antonio Trande --- (In reply to Vasiliy Glazov from comment #5) > Spec URL: https://raw.github.com/RussianFedora/myrulib/master/myrulib.spec > SRPM URL: > http://koji.russianfedora.ru/koji/getfile?taskID=83453&name=myrulib-0.29.14- > 4.fc20.R.src.rpm > > All bundled libraries removed. ... > Since I remove bundled libraries this files not compiled ant it's licenses > not used. Which have been removed ? I don't see any removal command in your .spec file. > Suffix .R present only in my srpm file. If you rebuild it .R will be removed > automattically. Read http://fedoraproject.org/wiki/Package_Review_Process#Contributor: "As a Contributor, you should have already made a package which adheres to the Package Naming Guidelines and Packaging Guidelines." -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8Q0WBXCfTQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991400] Review Request: myrulib - E-Book Library Manager
https://bugzilla.redhat.com/show_bug.cgi?id=991400 --- Comment #5 from Vasiliy Glazov --- Spec URL: https://raw.github.com/RussianFedora/myrulib/master/myrulib.spec SRPM URL: http://koji.russianfedora.ru/koji/getfile?taskID=83453&name=myrulib-0.29.14-4.fc20.R.src.rpm All bundled libraries removed. .desktop file validated. Suffix .R present only in my srpm file. If you rebuild it .R will be removed automattically. Since I remove bundled libraries this files not compiled ant it's licenses not used. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2L2UFjq4rD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991400] Review Request: myrulib - E-Book Library Manager
https://bugzilla.redhat.com/show_bug.cgi?id=991400 Christopher Meng changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #4 from Christopher Meng --- Please remove bundled libraries. Antonio's example indicates that you should use bzip2-devel but not bundled one. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZvcEytnADl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991400] Review Request: myrulib - E-Book Library Manager
https://bugzilla.redhat.com/show_bug.cgi?id=991400
Antonio Trande changed:
What|Removed |Added
CC||anto.tra...@gmail.com
--- Comment #3 from Antonio Trande ---
Hi Vasiliy.
> myrulib-0.29.14-3.fc20.R.src.rpm
*.R.* ? Not in Fedora, please.
> %{_datadir}/applications/%{name}.desktop
.desktop file validate is missing
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
> Multilicensing
Compilation is performed from source files with different licenses:
/3rdparty/bzip2/blocksort.c (BSD)
/3rdparty/bin2c/bin2c.c (GPLv2+)
/3rdparty/bzip2/* --> LICENSE file (GPLv3)
See
http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Mixed_Source_Licensing_Scenario
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=T3nvVRvDYt&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991400] Review Request: myrulib - E-Book Library Manager
https://bugzilla.redhat.com/show_bug.cgi?id=991400 --- Comment #2 from Vasiliy Glazov --- Spec URL: https://raw.github.com/RussianFedora/myrulib/master/myrulib.spec SRPM URL: http://koji.russianfedora.ru/koji/getfile?taskID=83205&name=myrulib-0.29.14-3.fc20.R.src.rpm With --with-strip debuginfo subpackage was empty. I change it to --without-strip. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HyWg533kMK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991400] Review Request: myrulib - E-Book Library Manager
https://bugzilla.redhat.com/show_bug.cgi?id=991400 --- Comment #1 from Michael Schwendt --- > --with-strip Does that do what I think it does? And if so, are you aware of its consequences? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Tz0uYJYCay&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
