[Bug 996813] Review Request: SQLCipher - Encrypted SQLite databases

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=996813

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms
 Resolution|DEFERRED|DUPLICATE



--- Comment #9 from Raphael Groner  ---


*** This bug has been marked as a duplicate of bug 1310294 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 996813] Review Request: SQLCipher - Encrypted SQLite databases

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=996813

Miroslav Suchý msu...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||msu...@redhat.com
 Blocks|177841 (FE-NEEDSPONSOR) |201449 (FE-DEADREVIEW)
 Resolution|--- |DEFERRED
Last Closed||2015-07-21 10:48:07



--- Comment #8 from Miroslav Suchý msu...@redhat.com ---
Closing due long inactivity. Feel free to reopen if you want to continue.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 996813] Review Request: SQLCipher - Encrypted SQLite databases

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=996813

noobie juli...@riseup.net changed:

   What|Removed |Added

 CC||juli...@riseup.net



--- Comment #7 from noobie juli...@riseup.net ---
definitely missing in the repo,no one willing to back it ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 996813] Review Request: SQLCipher - Encrypted SQLite databases

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=996813



--- Comment #6 from Christopher Meng cicku...@gmail.com ---
Any news here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 996813] Review Request: SQLCipher - Encrypted SQLite databases

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=996813



--- Comment #2 from Abel Luck a...@outcomedubious.im ---
Hm, I hadn't thought to. This would be my first time maintaining a package.

Is the package more likely to be accepted if I support EPEL?  I'd need to look
into the workload required to support it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 996813] Review Request: SQLCipher - Encrypted SQLite databases

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=996813

Björn besser82 Esser bjoern.es...@gmail.com changed:

   What|Removed |Added

 CC||bjoern.es...@gmail.com



--- Comment #3 from Björn besser82 Esser bjoern.es...@gmail.com ---
That usually has no affect whether you want to build for EPEL or not.  The
_real_ problem here is:  Your package ships a bundled sqlite-version and that's
something which is strongly discouraged.  See: 
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

You should actually unbundle `sqlite` and build this against the one shipped by
the system's libs.


BTW. Christopher's question was about the presence of `rm -rf %{buildroot}` on
%install and %check and the presence of Group: and BuildRoot: tags...

Those are simply not needed, but for = el5.  You can safely drop `defattr`,
because this was needed on = el4.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 996813] Review Request: SQLCipher - Encrypted SQLite databases

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=996813



--- Comment #4 from Björn besser82 Esser bjoern.es...@gmail.com ---
The next problem related to the bundled `sqlite` is:  They way it get's
packaged will simply conflict with system's installation of sqlite and thus is
another no-go and will cause _serious_ trouble to other software which is build
against system's version of sqlite..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 996813] Review Request: SQLCipher - Encrypted SQLite databases

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=996813



--- Comment #5 from Abel Luck a...@outcomedubious.im ---
Thanks Björn!

1. I believe SQLCipher deserves a No Bundled Libraries exception, so I'm
preparing an exception request. Once that's submitted, I'll link it here.

2. The reason for the EPEL looking code is because I based this package off the
existing sqlite package. Should I remove them if I don't plan on supporting
EPEL?

3. I don't believe SQLCipher will conflict with the system's sqlite. There are
no file path conflicts. Moreover, I have sqlite, sqlite-devel, sqlcipher, and
sqlcipher-devel installed simultaneously on my dev system with no conflicts.

4. A new version of SQLCipher has been released since I created the package,
I'll be updating it next week. Now that I have a space on fedorapeople.org,
I'll upload the new sources there.

You can see this from the rpmls output below.

[user@fedora-pkg rpmbuild]$ rpmls
RPMS/x86_64/sqlcipher-devel-2.2.1-1.fc18.x86_64.rpm 
-rw-r--r--  /usr/include/sqlcipher/sqlite3.h
-rw-r--r--  /usr/include/sqlcipher/sqlite3ext.h
lrwxrwxrwx  /usr/lib64/libsqlcipher.so
-rw-r--r--  /usr/lib64/pkgconfig/sqlcipher.pc
[user@fedora-pkg rpmbuild]$ rpmls RPMS/x86_64/sqlcipher-2.2.1-1.fc18.x86_64.rpm 
-rwxr-xr-x  /usr/bin/sqlcipher
lrwxrwxrwx  /usr/lib64/libsqlcipher.so.0
-rwxr-xr-x  /usr/lib64/libsqlcipher.so.0.8.6
drwxr-xr-x  /usr/share/doc/sqlcipher-2.2.1
-rw-r--r--  /usr/share/doc/sqlcipher-2.2.1/LICENSE
-rw-r--r--  /usr/share/doc/sqlcipher-2.2.1/README
-rw-r--r--  /usr/share/man/man1/sqlcipher.1.gz
[user@fedora-pkg rpmbuild]$ rpmls
RPMS/x86_64/sqlcipher-tcl-2.2.1-1.fc18.x86_64.rpm 
drwxr-xr-x  /usr/lib64/tcl8.5/sqlcipher
-rwxr-xr-x  /usr/lib64/tcl8.5/sqlcipher/libtclsqlite3.so
-rw-r--r--  /usr/lib64/tcl8.5/sqlcipher/pkgIndex.tcl

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 996813] Review Request: SQLCipher - Encrypted SQLite databases

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=996813

Abel Luck a...@outcomedubious.im changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=jUyj2os4VPa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 996813] Review Request: SQLCipher - Encrypted SQLite databases

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=996813

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC||cicku...@gmail.com



--- Comment #1 from Christopher Meng cicku...@gmail.com ---
Are you going to support EPEL?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=VqEiO8jfQ4a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review