[Bug 1563849] New: Review Request: nodejs-conventional-changelog-jshint - A conventional-changelog jshint preset

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563849

Bug ID: 1563849
   Summary: Review Request: nodejs-conventional-changelog-jshint -
A conventional-changelog jshint preset
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Blocks: 956806 (nodejs-reviews)



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-conventional-changelog-jshint/nodejs-conventional-changelog-jshint.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-conventional-changelog-jshint/nodejs-conventional-changelog-jshint-0.3.8-1.fc29.src.rpm
Description: A conventional-changelog jshint preset
Fedora Account System Username: jsmith


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562964] Review Request: python-pycares - Python interface for c-ares

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562964



--- Comment #4 from Matthieu Saulnier  ---
hi! thanks for your work. It seems we are working in the same time on it :)

this is the changelog, including your advises:

- Remove useless code duplication step
- Add missing %%python_provide macro in subpackages
- Cleanup rst doc script in %%install section
- Fix file ownership in doc subpackage

Spec URL: https://fantom.fedorapeople.org/python-pycares.spec
SRPM URL: https://fantom.fedorapeople.org/python-pycares-2.3.0-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563836] Review Request: nodejs-conventional-changelog-eslint - A conventional-changelog eslint preset

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563836

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562964] Review Request: python-pycares - Python interface for c-ares

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562964

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #5 from Robert-André Mauchin  ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "NTP", "ISC", "Unknown or generated",
 "BSD (3 clause)". 52 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/python-pycares/review-
 python-pycares/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: Uses parallel make %{?_smp_mflags} macro.
[-]: Avoid bundling fonts in non-fonts packages.
 Note: 

[Bug 1563854] New: Review Request: nodejs-tempfile - Get a random temporary file path

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563854

Bug ID: 1563854
   Summary: Review Request: nodejs-tempfile - Get a random
temporary file path
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Blocks: 956806 (nodejs-reviews)



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-tempfile/nodejs-tempfile.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-tempfile/nodejs-tempfile-2.0.0-1.fc29.src.rpm
Description: Get a random temporary file path
Fedora Account System Username: jsmith


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1563160] Review Request: perl-Test-Log-Log4perl - Test log4perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1563160

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Test-Log-Log4perl-0.32
   ||-1.fc29
 Resolution|--- |RAWHIDE
Last Closed||2018-04-04 02:27:47



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1463538] Review-request: rubygem-recursive-open-struct: Allows nested hashes to be treated in a recursive fashion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1463538

Juan Badia Payno  changed:

   What|Removed |Added

 Resolution|NOTABUG |CURRENTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1463253] rubygem-lru_redux: An efficient implementation of an lru cache

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1463253

Juan Badia Payno  changed:

   What|Removed |Added

 Resolution|NOTABUG |CURRENTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562519] Review Request: git-crypt - transparent file encryption in git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562519



--- Comment #7 from Fedora Update System  ---
git-crypt-0.6.0-3.fc28 has been submitted as an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-74979395a9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376749] Review Request: golang-github-klauspost-compress - Optimized compression packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376749



--- Comment #7 from Matthias Runge  ---
Since my attention completely shifted away, I realized, that I currently don't
have the time to continue here.

Upstream added another package as dependency for the most recent version. I'm
sorry, I need to drop this. Any of you want to take over?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1562519] Review Request: git-crypt - transparent file encryption in git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1562519

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org