Re: [pacman-dev] [PATCH 3/6] common: Add support for wcwidth and wcswidth for systems without.

2015-03-03 Thread Allan McRae
On 04/03/15 00:44, Will Miles wrote:
> Hi Allan,
> 
> Gnulib has solutions for patches 3, 4, and 5  (wcwidth/wcswidth,
> asprintf/vasprintf, and mkdtemp) - basically everything QNX is
> missing.   A solution to embed gnulib would be very practical.   I tried
> a simple build by following the gnulib instructions, but had some
> trouble getting it to build PIC for including mkdtemp in libalpm;
> unfortunately I got called away to another project before I could
> investigate further.   If you have any specific tips for how best to
> perform the integration, I'd be very interested.
> 

I have only looked at using it once very long ago, so I can not help
much here.

I'm sure I could find someone in the wider Arch community to help us out
if needed.

Cheers,
Allan


Re: [pacman-dev] [PATCH 3/6] common: Add support for wcwidth and wcswidth for systems without.

2015-03-03 Thread Will Miles

Hi Allan,

Gnulib has solutions for patches 3, 4, and 5  (wcwidth/wcswidth, 
asprintf/vasprintf, and mkdtemp) - basically everything QNX is 
missing.   A solution to embed gnulib would be very practical.   I tried 
a simple build by following the gnulib instructions, but had some 
trouble getting it to build PIC for including mkdtemp in libalpm; 
unfortunately I got called away to another project before I could 
investigate further.   If you have any specific tips for how best to 
perform the integration, I'd be very interested.


Thanks,

-Will

On 2015-03-02 11:50 PM, Allan McRae wrote:

 From what I understand, if gnulib does work then we should add it as a
git submodule and adjust our configure to use functions from there when
necessary.

We can look into that further if you gnulib does lots of what you need.

Thanks,
Allan

On 28/02/15 07:20, Will Miles wrote:

Gnulib does indeed have the necessary bits for patches 3, 4, and 5.
Consider them withdrawn, then, and I'll update my QNX build environment
accordingly.

-Will

On 2/27/2015 3:27 PM, Allan McRae wrote:

On 28/02/15 06:24, Allan McRae wrote:

On 28/02/15 05:43, Will Miles wrote:

The specific implementation has been copied from Markus Kuhn at
http://www.cl.cam.ac.uk/~mgk25/ucs/wcwidth.c

Signed-off-by: Will Miles 

I don't intend to accept reimplementations of POSIX functions into
pacman.  I'm not even sure what system we supported that did not have
strndup...   Cygwin maybe?

Answering my own question - OSX.


Check if gnulib provides all the needed functions.  If so, that might be
the root to take.

Allan