Re: [pacman-dev] [PATCH] libmakepkg/executable: don't rely on scoped value of $ret to flag outcomes

[Allan McRae]

On 28/11/18 2:00 pm, Eli Schwartz wrote:
> Elsewhere, we return 1 if a library dropin fails, and when running
> functions in a loop, we use `|| ret=1` to preserve scope. This ensures
> the return value of the function remains useful in isolation. Do the
> same thing here as well.
> 
> Drop trivial function which wraps a dropin that also uses $ret, since
> it's no longer needed.
> 

Thanks - I keep forgetting that the point of libmakepkg is reuseability
in addition to splitting up the massive script...

Allan

Re: [pacman-dev] [PATCH] Enable additional debug flags/logging with debugoptimized builds

[Allan McRae]

On 4/12/18 12:36 am, Dave Reisner wrote:
> This lets developers run a local build with optimizations but also the
> added debug logging that comes with PACMAN_DEBUG being defined.
> ---

So, we only test for "debug" to enable anything.  What options starting
with debug would be used here?

Also, all those warning flags in this test are set with --enable-warning
flags in autotools based builds.  Strangely, all the options from
--enable-debug are not set here...

>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index 8837816f..394bd1f5 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -211,7 +211,7 @@ elif conf.has('HAVE_STRUCT_STATFS_F_FLAGS')
>conf.set('FSSTATSTYPE', 'struct statfs')
>  endif
>  
> -if get_option('buildtype') == 'debug'
> +if get_option('buildtype').startswith('debug')
>extra_cflags = [
>  '-Wcast-align',
>  '-Wclobbered',
> 

[pacman-dev] [PATCH] Enable additional debug flags/logging with debugoptimized builds

[Dave Reisner]

This lets developers run a local build with optimizations but also the
added debug logging that comes with PACMAN_DEBUG being defined.
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 8837816f..394bd1f5 100644
--- a/meson.build
+++ b/meson.build
@@ -211,7 +211,7 @@ elif conf.has('HAVE_STRUCT_STATFS_F_FLAGS')
   conf.set('FSSTATSTYPE', 'struct statfs')
 endif
 
-if get_option('buildtype') == 'debug'
+if get_option('buildtype').startswith('debug')
   extra_cflags = [
 '-Wcast-align',
 '-Wclobbered',
-- 
2.19.2