Re: [pacman-dev] [PATCH] pacman: print colored optdepends install status
On 12 Dec 2018, at 11:31 am +1000, Allan McRae wrote:
> On 10/12/18 3:31 am, Michael Straube wrote:
> > Colorize [installed] and [pending] when printing optional dependencies.
> I'd prefer having less colours in our search operations, rather than
> bringing those colours into other operations.
> Anyone want to give other opinions on this?
Agreed; I tend to prefer black-and-white output. Also,
tools like lesspipe and multitail can colorize any program's stdout
without having to add color support to the original program (or in
this case, further complicate existing color support).
Cheers,
Ivy ("escondida")
signature.asc
Description: PGP signature
Re: [pacman-dev] [PATCH] pacman: print colored optdepends install status
On 10/12/18 3:31 am, Michael Straube wrote: > Colorize [installed] and [pending] when printing optional dependencies. > > FS#34920 > > Signed-off-by: Michael Straube > --- Thanks for this patch. I think there was a reason this bug was sitting untouched since 2013... To me, adding colour here is very distracting during an update: http://allanmcrae.com/tmp/color.png I'd prefer having less colours in our search operations, rather than bringing those colours into other operations. Anyone want to give other opinions on this? Allan
[pacman-dev] [GIT] The official pacman repository branch, release/5.1.x, updated. v5.1.1-9-gcfa1e8b5
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, release/5.1.x has been updated via cfa1e8b5e2b2fdf66fe41c72d04a8bbc23c28027 (commit) from 3a88fcb19199c5b5fa18162f5f9dc8990311dbd2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit cfa1e8b5e2b2fdf66fe41c72d04a8bbc23c28027 Author: Allan McRae Date: Wed Dec 12 11:11:12 2018 +1000 Pull updated translations from Transifex Mostly churn in string headers, but a few new or updated translations. Signed-off-by: Allan McRae --- Summary of changes: lib/libalpm/po/ar.po | 40 ++-- lib/libalpm/po/ast.po | 40 ++-- lib/libalpm/po/bg.po | 40 ++-- lib/libalpm/po/br.po | 88 lib/libalpm/po/ca.po | 72 +++ lib/libalpm/po/cs.po | 40 ++-- lib/libalpm/po/da.po | 40 ++-- lib/libalpm/po/de.po | 40 ++-- lib/libalpm/po/el.po | 40 ++-- lib/libalpm/po/en_GB.po | 40 ++-- lib/libalpm/po/eo.po | 40 ++-- lib/libalpm/po/es.po | 40 ++-- lib/libalpm/po/es_419.po | 40 ++-- lib/libalpm/po/eu.po | 40 ++-- lib/libalpm/po/eu_ES.po | 40 ++-- lib/libalpm/po/fi.po | 40 ++-- lib/libalpm/po/fr.po | 40 ++-- lib/libalpm/po/gl.po | 40 ++-- lib/libalpm/po/hr.po | 40 ++-- lib/libalpm/po/hu.po | 40 ++-- lib/libalpm/po/id.po | 40 ++-- lib/libalpm/po/it.po | 40 ++-- lib/libalpm/po/ja.po | 40 ++-- lib/libalpm/po/kk.po | 40 ++-- lib/libalpm/po/ko.po | 50 ++--- lib/libalpm/po/libalpm.pot| 40 ++-- lib/libalpm/po/lt.po | 40 ++-- lib/libalpm/po/nb.po | 66 +++--- lib/libalpm/po/nl.po | 53 ++--- lib/libalpm/po/pl.po | 40 ++-- lib/libalpm/po/pt.po | 40 ++-- lib/libalpm/po/pt_BR.po | 40 ++-- lib/libalpm/po/ro.po | 40 ++-- lib/libalpm/po/ru.po | 40 ++-- lib/libalpm/po/sk.po | 40 ++-- lib/libalpm/po/sl.po | 44 ++-- lib/libalpm/po/sr.po | 40 ++-- lib/libalpm/po/s...@latin.po| 40 ++-- lib/libalpm/po/sv.po | 40 ++-- lib/libalpm/po/tr.po | 44 ++-- lib/libalpm/po/uk.po | 40 ++-- lib/libalpm/po/zh_CN.po | 44 ++-- lib/libalpm/po/zh_TW.po | 40 ++-- scripts/po/bg.po | 218 ++-- scripts/po/br.po | 212 +-- scripts/po/ca.po | 458 +- scripts/po/cs.po | 212 +-- scripts/po/da.po | 231 ++--- scripts/po/de.po | 212 +-- scripts/po/el.po | 212 +-- scripts/po/en_GB.po | 212 +-- scripts/po/eo.po | 222 ++-- scripts/po/es.po | 218 ++-- scripts/po/es_419.po | 212 +-- scripts/po/eu.po | 212 +-- scripts/po/eu_ES.po | 212 +-- scripts/po/fi.po | 212 +-- scripts/po/fr.po | 219 ++-- scripts/po/gl.po | 212 +-- scripts/po/hu.po | 212 +-- scripts/po/id.po | 212 +-- scripts/po/it.po | 212 +-- scripts/po/ja.po | 218 ++-- scripts/po/ko.po | 222 ++-- scripts/po/lt.po | 225 +++-- scripts/po/nb.po | 321 +++-- scripts/po/nl.po | 223 ++-- scripts/po/pacman-scripts.pot | 212 +-- scripts/po/pl.po | 212 +-- scripts/po/pt.po | 218 ++-- scripts/po/pt_BR.po | 212 +-- scripts/po/ro.po | 212 +-- scripts/po/ru.po | 212 +-- scripts/po/sk.po | 242 +++--- scripts/po/sr.po | 212 +-- scripts/po/s...@latin.po| 212 +-- scripts/po/sv.po | 214 ++-- scripts/po/tr.po | 222 ++-- scripts/po/uk.po | 212 +-- scripts/po/zh_CN.po | 212 +-- scripts/po/zh_TW.po | 212 +--
[pacman-dev] [GIT] The official pacman repository branch, master, updated. v5.1.1-84-gb109d709
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via b109d7096b3f3f3244b7bb3796be658393eff98a (commit) via 77b8ca70322a121a2efb5318042e664246d3ec0e (commit) via d73fed4e134a1912df7bbc6a50c2287023ea1c4a (commit) from b67ec905205d96ca6801626a65149724f47f36f0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit b109d7096b3f3f3244b7bb3796be658393eff98a Author: Eli Schwartz Date: Mon Dec 10 23:47:58 2018 -0500 meson: add trailing slashes to directory components in configuration defines This matches what we currently do in the autotools build configuration, and ensures that the default pacman-conf definitions for unspecified values consistently end with the trailing directory slashes. This has ramifications for thirdparty tools that up to now, have relied on this slash being there. Those tools should be fixed to prevent breaking when custom locations are set, but this is no reason not to fix it on our end as well. An extra trailng slash should never cause harm. Signed-off-by: Eli Schwartz Signed-off-by: Allan McRae commit 77b8ca70322a121a2efb5318042e664246d3ec0e Author: Eli Schwartz Date: Mon Dec 10 01:15:19 2018 -0500 meson: install the directories needed for successful pacman operation This was neglected in the initial meson port. We need these directories to exist in order to bootstrap a new installation. Signed-off-by: Eli Schwartz Signed-off-by: Allan McRae commit d73fed4e134a1912df7bbc6a50c2287023ea1c4a Author: Eli Schwartz Date: Mon Dec 10 01:15:18 2018 -0500 meson: remove useless mkdir -p directories are created by install_dir within the subdir custom_target installation targets. Signed-off-by: Eli Schwartz Signed-off-by: Allan McRae --- Summary of changes: meson.build| 15 --- scripts/libmakepkg/meson.build | 7 --- 2 files changed, 12 insertions(+), 10 deletions(-) hooks/post-receive -- The official pacman repository
Re: [pacman-dev] [PATCH] pacman: better warning message when skipping duplicate targets
Am 11.12.18 um 20:51 schrieb Andrew Gregory:
On 12/11/18 at 06:14pm, Michael Straube wrote:
Am 09.12.18 um 19:47 schrieb Andrew Gregory:
On 12/09/18 at 06:31pm, Michael Straube wrote:
Change the warning message to reflect the reason when skipping duplicate
targets. skipping target -> skipping duplicate target
FS#49377
Signed-off-by: Michael Straube
---
src/pacman/remove.c | 2 +-
src/pacman/sync.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Should we just remove the error altogether and move the message to
DEBUG? The user doesn't need to do anything in response to it and
I can't think of any reason a front-end would want to actually die
from it. It seems to just be useless line noise that requires
front-ends to check for it specifically just to ignore it.
Sounds reasonable. On the other hand I can imagine that some people
would complain that too much from what's going on is hidden from the
user. What do others think?
P.S.: You mean?
pm_printf(ALPM_LOG_DEBUG, _("skipping duplicate target: %s\n"), target);
I realized after sending this that adding a duplicate could actually
be an error if they are two separate packages with the same name. So,
I'm going to say to add a check in add_pkg for whether the duplicate
is actually the same package (simple pointer cmp) and, if they are the
same, log a debug message and return success, if they are different
return the error as we do now. process_pkg in pacman should then
treat that error just like any other instead of printing a warning and
continuing on. alpm_remove_pkg should just log the debug message and
return success.
apg
Ok, I will send a patch the next days.
Re: [pacman-dev] [PATCH] pacman: better warning message when skipping duplicate targets
On 12/11/18 at 06:14pm, Michael Straube wrote:
> Am 09.12.18 um 19:47 schrieb Andrew Gregory:
> > On 12/09/18 at 06:31pm, Michael Straube wrote:
> > > Change the warning message to reflect the reason when skipping duplicate
> > > targets. skipping target -> skipping duplicate target
> > >
> > > FS#49377
> > >
> > > Signed-off-by: Michael Straube
> > > ---
> > > src/pacman/remove.c | 2 +-
> > > src/pacman/sync.c | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > Should we just remove the error altogether and move the message to
> > DEBUG? The user doesn't need to do anything in response to it and
> > I can't think of any reason a front-end would want to actually die
> > from it. It seems to just be useless line noise that requires
> > front-ends to check for it specifically just to ignore it.
> >
>
> Sounds reasonable. On the other hand I can imagine that some people
> would complain that too much from what's going on is hidden from the
> user. What do others think?
>
>
> P.S.: You mean?
> pm_printf(ALPM_LOG_DEBUG, _("skipping duplicate target: %s\n"), target);
I realized after sending this that adding a duplicate could actually
be an error if they are two separate packages with the same name. So,
I'm going to say to add a check in add_pkg for whether the duplicate
is actually the same package (simple pointer cmp) and, if they are the
same, log a debug message and return success, if they are different
return the error as we do now. process_pkg in pacman should then
treat that error just like any other instead of printing a warning and
continuing on. alpm_remove_pkg should just log the debug message and
return success.
apg
Re: [pacman-dev] [PATCH] pacman: better warning message when skipping duplicate targets
Am 09.12.18 um 19:47 schrieb Andrew Gregory:
On 12/09/18 at 06:31pm, Michael Straube wrote:
Change the warning message to reflect the reason when skipping duplicate
targets. skipping target -> skipping duplicate target
FS#49377
Signed-off-by: Michael Straube
---
src/pacman/remove.c | 2 +-
src/pacman/sync.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Should we just remove the error altogether and move the message to
DEBUG? The user doesn't need to do anything in response to it and
I can't think of any reason a front-end would want to actually die
from it. It seems to just be useless line noise that requires
front-ends to check for it specifically just to ignore it.
Sounds reasonable. On the other hand I can imagine that some people
would complain that too much from what's going on is hidden from the
user. What do others think?
P.S.: You mean?
pm_printf(ALPM_LOG_DEBUG, _("skipping duplicate target: %s\n"), target);
