Re: [pacman-dev] [PATCH] fixup run XferCommand via exec

[Andrew Gregory]

On 06/11/19 at 11:06am, Allan McRae wrote:
> On 10/6/19 6:50 am, Andrew Gregory wrote:
> > Does anybody know what usepart was for?  It was unset unless %o was
> > used in XferCommand, but I'm not sure what the use case for an
> > XferCommand without %o would be.
> 
> When %o was added, there were cases in the wild where users had a
> downloader that did not support resuming the download.  No sure this
> would be the case now...

I assume nobody minds if that possibility is removed.

[pacman-dev] [PATCH] Correctly report a download failiure for 404s

[morganamilo]

Currently when caling alpm_trans_commit, if fetching a package restults
in a 404 (or other non 400 response code), the function returns -1 but
errno is never set.

Thish patch sets errno to ALPM_ERR_RETRIEVE.

diff --git a/lib/libalpm/dload.c b/lib/libalpm/dload.c
index 05813c40..e5696bb0 100644
--- a/lib/libalpm/dload.c
+++ b/lib/libalpm/dload.c
@@ -454,6 +454,7 @@ static int curl_download_internal(struct dload_payload 
*payload,
if(payload->respcode >= 400) {
payload->unlink_on_fail = 1;
if(!payload->errors_ok) {
+   handle->pm_errno = ALPM_ERR_RETRIEVE;
/* non-translated message is same as 
libcurl */
snprintf(error_buffer, 
sizeof(error_buffer),
"The requested URL 
returned error: %ld", payload->respcode);
-- 
2.21.0

Re: [pacman-dev] [PATCH 1/2] [WIP] move wordsplit into ini for sharing

[Allan McRae]

On 10/6/19 3:13 am, Andrew Gregory wrote:
> Not technically related to INI parsing, but we use it with INI files.

It seems a strange place to put these functions...  And they should not
have an _alpm prefix if being used outside libalpm.   How about putting
them util-common without the prefix?

Allan