Re: [Paraview] PV 440 crashes when picking rotation center

2015-10-12 Thread Cory Quammen
Richard,

I have created a merge request with a proposed bug fix.

https://gitlab.kitware.com/paraview/paraview/merge_requests/417

commit 434b9af41bcbd5d4497a44425d5d42b64efda6ac
Author: Cory Quammen 
Date:   Mon Oct 12 11:06:20 2015 -0400

Replace Q_ASSERT with a return if NULL

With recent changes to pqFindDataSelectionDisplayFrame, it was
possible for showFrustum() to be called when the current port was
NULL. This could lead to a crash when no object was selected in the
pipeline browser and the "Pick Center" tool was used. Changed this
code to return from this function if the view or port are NULL.

Cory

On Mon, Oct 12, 2015 at 11:38 AM, Richard Grenon 
wrote:

> Hi Cory,
>
> I performed the test with the sphere: same crash when clicking on
> "builtin" in Pipeline Browser before picking Center, no crash when "Sphere"
> object is selected.
>
> Thank you for taking a look at a fix.
>
> Richard
>
> Le 12/10/2015 16:15, Cory Quammen a écrit :
>
>> Hi Richard,
>>
>> I can confirm. In fact, it isn't specific to your state file, but rather
>> can be reproduced with a Sphere Source:
>>
>> - launch ParaView
>> - Sources -> Sphere Source. Apply
>> - Click on "builtin:" in Pipeline Browser
>> - Click the "Pick Center" button
>> - Click on the sphere
>>
>> Crash:
>>
>> ASSERT: "this->View != NULL && this->Port != NULL" in file
>> /home/cory/code/src/ParaView/Qt/Components/pqFindDataSelectionDisplayFrame.cxx,
>> line 323
>> Aborted (core dumped)
>>
>> I'll take a look at a fix.
>>
>> Cory
>>
>> --
>  Richard GRENON
>  ONERA
>  Departement d'Aerodynamique Appliquee - DAAP/ACI
>  8 rue des Vertugadins
>  92190 MEUDON - FRANCE
>  phone : +33 1 46 73 42 17
>  fax   : +33 1 46 73 41 46
>  mailto:richard.gre...@onera.fr
>  http://www.onera.fr
>
>


-- 
Cory Quammen
R&D Engineer
Kitware, Inc.
___
Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the ParaView Wiki at: 
http://paraview.org/Wiki/ParaView

Search the list archives at: http://markmail.org/search/?q=ParaView

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/paraview


Re: [Paraview] PV 440 crashes when picking rotation center

2015-10-12 Thread Richard Grenon

Hi Cory,

I performed the test with the sphere: same crash when clicking on 
"builtin" in Pipeline Browser before picking Center, no crash when 
"Sphere" object is selected.


Thank you for taking a look at a fix.

Richard

Le 12/10/2015 16:15, Cory Quammen a écrit :

Hi Richard,

I can confirm. In fact, it isn't specific to your state file, but 
rather can be reproduced with a Sphere Source:


- launch ParaView
- Sources -> Sphere Source. Apply
- Click on "builtin:" in Pipeline Browser
- Click the "Pick Center" button
- Click on the sphere

Crash:

ASSERT: "this->View != NULL && this->Port != NULL" in file 
/home/cory/code/src/ParaView/Qt/Components/pqFindDataSelectionDisplayFrame.cxx, 
line 323

Aborted (core dumped)

I'll take a look at a fix.

Cory


--
 Richard GRENON
 ONERA
 Departement d'Aerodynamique Appliquee - DAAP/ACI
 8 rue des Vertugadins
 92190 MEUDON - FRANCE
 phone : +33 1 46 73 42 17
 fax   : +33 1 46 73 41 46
 mailto:richard.gre...@onera.fr
 http://www.onera.fr

___
Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the ParaView Wiki at: 
http://paraview.org/Wiki/ParaView

Search the list archives at: http://markmail.org/search/?q=ParaView

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/paraview


Re: [Paraview] PV 440 crashes when picking rotation center

2015-10-12 Thread Cory Quammen
Hi Richard,

I can confirm. In fact, it isn't specific to your state file, but rather
can be reproduced with a Sphere Source:

- launch ParaView
- Sources -> Sphere Source. Apply
- Click on "builtin:" in Pipeline Browser
- Click the "Pick Center" button
- Click on the sphere

Crash:

ASSERT: "this->View != NULL && this->Port != NULL" in file
/home/cory/code/src/ParaView/Qt/Components/pqFindDataSelectionDisplayFrame.cxx,
line 323
Aborted (core dumped)

I'll take a look at a fix.

Cory

On Mon, Oct 12, 2015 at 6:58 AM, Richard Grenon 
wrote:

> Hello,
>
> I found what seems to be a little bug in PV 440: load the sample state
> file that opens the sample Tecplot file, click on the "Pick center" button,
> then click anywhere on the sample shape and PV 440 crashes.
>
> This bug seems to be related to the fact that no object is selected in the
> pipeline when loading a state file: if you select an object in the pipeline
> before picking center, PV 440 does not crash. Test performed on Linux 64
> bits, PV 440 installed from the binaries on the PV download page.
>
> Same test with PV 410: no crash when no object is selected.
>
> Richard
>
> --
>  Richard GRENON
>  ONERA
>  Departement d'Aerodynamique Appliquee - DAAP/ACI
>  8 rue des Vertugadins
>  92190 MEUDON - FRANCE
>  phone : +33 1 46 73 42 17
>  fax   : +33 1 46 73 41 46
>  mailto:richard.gre...@onera.fr
>  http://www.onera.fr
>
>
> ___
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the ParaView Wiki at:
> http://paraview.org/Wiki/ParaView
>
> Search the list archives at: http://markmail.org/search/?q=ParaView
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/paraview
>
>


-- 
Cory Quammen
R&D Engineer
Kitware, Inc.
___
Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the ParaView Wiki at: 
http://paraview.org/Wiki/ParaView

Search the list archives at: http://markmail.org/search/?q=ParaView

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/paraview