Re: [Paraview] xdmf.py install is scanning my /usr recursively and try to bytecompile anything in .py

2010-06-21 Thread François Bissey
 Hi Francois,
 
 I am a little bit confused by your email. Just to be clear, is this the
 change you are proposing?
 
  SET( XdmfGzipSource
gzstream
 @@ -504,7 +504,7 @@ IF(XDMF_WRAP_PYTHON)
 
# Compile Byte Code
INSTALL(CODE EXECUTE_PROCESS(COMMAND ${PYTHON_EXECUTABLE}
 ${Xdmf_SOURCE_DIR}/CMake/CompileXdmfByteCode.py
 -${CMAKE_INSTALL_PREFIX}/${XDMF_WRAP_PYTHON_INSTALL_PY_DIR}))
 +${XDMF_WRAP_PYTHON_INSTALL_DIR}))
 
  ENDIF(XDMF_WRAP_PYTHON)
 
 Let me know and I will gladly commit the fix.
 
Hi Dave,

Sorry for the delay. I now believe there may be a better fix respecting
DESTDIR as the python modules of vtk don't exhibit this problem.
I have to look it up a little bit further.

Francois
___
Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the ParaView Wiki at: 
http://paraview.org/Wiki/ParaView

Follow this link to subscribe/unsubscribe:
http://www.paraview.org/mailman/listinfo/paraview


Re: [Paraview] xdmf.py install is scanning my /usr recursively and try to bytecompile anything in .py

2010-06-16 Thread Dave Partyka
Hi Francois,

I am a little bit confused by your email. Just to be clear, is this the
change you are proposing?

 SET( XdmfGzipSource
   gzstream
@@ -504,7 +504,7 @@ IF(XDMF_WRAP_PYTHON)

   # Compile Byte Code
   INSTALL(CODE EXECUTE_PROCESS(COMMAND ${PYTHON_EXECUTABLE}
${Xdmf_SOURCE_DIR}/CMake/CompileXdmfByteCode.py
-${CMAKE_INSTALL_PREFIX}/${XDMF_WRAP_PYTHON_INSTALL_PY_DIR}))
+${XDMF_WRAP_PYTHON_INSTALL_DIR}))

 ENDIF(XDMF_WRAP_PYTHON)

Let me know and I will gladly commit the fix.

On Tue, Jun 15, 2010 at 6:07 AM, François Bissey f.r.bis...@massey.ac.nzwrote:

 Hi,

 A problem that I encountered while packaging paraview-3.8.0.
 Here is a build log extract:
 -- Installing: /media/anthill/portage/sci-
 visualization/paraview-3.8.0/image/usr/lib/python2.6/site-
 packages/Xdmf/__init__.py
 -- Installing: /media/anthill/portage/sci-
 visualization/paraview-3.8.0/image/usr/lib/python2.6/site-
 packages/Xdmf/Xdmf.py
 Listing /usr/ ...
 Listing /usr/bin ...
 Compiling /usr/bin/add_esri_column.py ...
 Sorry [Errno 13] Permission denied: '/usr/bin/add_esri_column.pyc'
 Compiling /usr/bin/build_pcs.py ...
 Sorry [Errno 13] Permission denied: '/usr/bin/build_pcs.pyc'
 snip
 Listing /usr/i686-pc-linux-gnu ...
 Listing /usr/i686-pc-linux-gnu/bin ...
 Listing /usr/i686-pc-linux-gnu/binutils-bin ...
 Listing /usr/i686-pc-linux-gnu/binutils-bin/2.20.1 ...
 Listing /usr/i686-pc-linux-gnu/gcc-bin ...
 Listing /usr/i686-pc-linux-gnu/gcc-bin/3.3 ...
 Listing /usr/i686-pc-linux-gnu/gcc-bin/4.3.4 ...
 Listing /usr/i686-pc-linux-gnu/gcc-bin/4.4.3 ...
 Listing /usr/i686-pc-linux-gnu/lib ...
 snip
 Listing /usr/src/linux-2.6.32-gentoo-r7/virt/kvm ...
 Listing /usr/tmp-vrooom ...
 -- Installing: /media/anthill/portage/sci-
 visualization/paraview-3.8.0/image/usr/lib/paraview-3.8/libXdmf.so

 So two points: first it doesn't respect DESTDIR - in the end bytecompiling
 is
 the responsibility of the package manager so I disabled that completely.

 Second it all come from this bit in Utilities/Xdmf2/libsrc/CMakeList.txt
 (lines 505-507):
  # Compile Byte Code
  INSTALL(CODE EXECUTE_PROCESS(COMMAND ${PYTHON_EXECUTABLE}
 ${Xdmf_SOURCE_DIR}/CMake/CompileXdmfByteCode.py
${CMAKE_INSTALL_PREFIX}/${XDMF_WRAP_PYTHON_INSTALL_PY_DIR}))

 It turns out that we scan /usr which is CMAKE_INSTALL_PREFIX because
 XDMF_WRAP_PYTHON_INSTALL_PY_DIR is never defined. I suspect the intent
 was to define it earlier and to use it to set XDMF_WRAP_PYTHON_INSTALL_DIR
 as we can see earlier in the same file (lines 472):
  SET(XDMF_WRAP_PYTHON_INSTALL_DIR
 ${CMAKE_INSTALL_PREFIX}${XDMF_WRAP_PYTHON_INSTALL_DIR}/Xdmf)

 Which I think may have been meant:
  SET(XDMF_WRAP_PYTHON_INSTALL_DIR
 ${CMAKE_INSTALL_PREFIX}${XDMF_WRAP_PYTHON_INSTALL_PY_DIR}/Xdmf)

 --
 If we don't care about DESTDIR replacing
 ${CMAKE_INSTALL_PREFIX}/${XDMF_WRAP_PYTHON_INSTALL_PY_DIR}
 in line 507 by:
 ${XDMF_WRAP_PYTHON_INSTALL_DIR}
 will look in the right place.

 Francois
 ___
 Powered by www.kitware.com

 Visit other Kitware open-source projects at
 http://www.kitware.com/opensource/opensource.html

 Please keep messages on-topic and check the ParaView Wiki at:
 http://paraview.org/Wiki/ParaView

 Follow this link to subscribe/unsubscribe:
 http://www.paraview.org/mailman/listinfo/paraview

___
Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the ParaView Wiki at: 
http://paraview.org/Wiki/ParaView

Follow this link to subscribe/unsubscribe:
http://www.paraview.org/mailman/listinfo/paraview


[Paraview] xdmf.py install is scanning my /usr recursively and try to bytecompile anything in .py

2010-06-15 Thread François Bissey
Hi,

A problem that I encountered while packaging paraview-3.8.0.
Here is a build log extract:
-- Installing: /media/anthill/portage/sci-
visualization/paraview-3.8.0/image/usr/lib/python2.6/site-
packages/Xdmf/__init__.py
-- Installing: /media/anthill/portage/sci-
visualization/paraview-3.8.0/image/usr/lib/python2.6/site-
packages/Xdmf/Xdmf.py
Listing /usr/ ...
Listing /usr/bin ...
Compiling /usr/bin/add_esri_column.py ...
Sorry [Errno 13] Permission denied: '/usr/bin/add_esri_column.pyc'
Compiling /usr/bin/build_pcs.py ...
Sorry [Errno 13] Permission denied: '/usr/bin/build_pcs.pyc'
snip
Listing /usr/i686-pc-linux-gnu ...
Listing /usr/i686-pc-linux-gnu/bin ...
Listing /usr/i686-pc-linux-gnu/binutils-bin ...
Listing /usr/i686-pc-linux-gnu/binutils-bin/2.20.1 ...
Listing /usr/i686-pc-linux-gnu/gcc-bin ...
Listing /usr/i686-pc-linux-gnu/gcc-bin/3.3 ...
Listing /usr/i686-pc-linux-gnu/gcc-bin/4.3.4 ...
Listing /usr/i686-pc-linux-gnu/gcc-bin/4.4.3 ...
Listing /usr/i686-pc-linux-gnu/lib ...
snip
Listing /usr/src/linux-2.6.32-gentoo-r7/virt/kvm ...
Listing /usr/tmp-vrooom ...
-- Installing: /media/anthill/portage/sci-
visualization/paraview-3.8.0/image/usr/lib/paraview-3.8/libXdmf.so

So two points: first it doesn't respect DESTDIR - in the end bytecompiling is
the responsibility of the package manager so I disabled that completely.

Second it all come from this bit in Utilities/Xdmf2/libsrc/CMakeList.txt 
(lines 505-507):
  # Compile Byte Code
  INSTALL(CODE EXECUTE_PROCESS(COMMAND ${PYTHON_EXECUTABLE} 
${Xdmf_SOURCE_DIR}/CMake/CompileXdmfByteCode.py 
${CMAKE_INSTALL_PREFIX}/${XDMF_WRAP_PYTHON_INSTALL_PY_DIR}))

It turns out that we scan /usr which is CMAKE_INSTALL_PREFIX because
XDMF_WRAP_PYTHON_INSTALL_PY_DIR is never defined. I suspect the intent
was to define it earlier and to use it to set XDMF_WRAP_PYTHON_INSTALL_DIR
as we can see earlier in the same file (lines 472):
  SET(XDMF_WRAP_PYTHON_INSTALL_DIR 
${CMAKE_INSTALL_PREFIX}${XDMF_WRAP_PYTHON_INSTALL_DIR}/Xdmf)

Which I think may have been meant:
  SET(XDMF_WRAP_PYTHON_INSTALL_DIR 
${CMAKE_INSTALL_PREFIX}${XDMF_WRAP_PYTHON_INSTALL_PY_DIR}/Xdmf)

--
If we don't care about DESTDIR replacing  
${CMAKE_INSTALL_PREFIX}/${XDMF_WRAP_PYTHON_INSTALL_PY_DIR}
in line 507 by:
${XDMF_WRAP_PYTHON_INSTALL_DIR}
will look in the right place.

Francois
___
Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the ParaView Wiki at: 
http://paraview.org/Wiki/ParaView

Follow this link to subscribe/unsubscribe:
http://www.paraview.org/mailman/listinfo/paraview