Re: [Patch-gnuradio] set/get gain for quadrature_demod
On Mon, Jun 20, 2011 at 11:42, Alexandru Csete oz9...@gmail.com wrote: Will it be possible to include this functionality or is there a problem with it? This just got missed in the shuffle; I had intended to merge it (with a couple mods) before tagging 3.4.0. Since it doesn't introduce any incompatibilities into existing user code, it can still be merged into the master branch and eventually become part of the 3.4.1 release. The only issue with the patch is that for property getters we simply use the name of the property, without prepending get_ in front of it. So your get_gain() should be just gain(). I was also going to add that the two new API calls are not documented in the header file, then I realized that there wasn't any documentation there in the first place :) Johnathan ___ Patch-gnuradio mailing list Patch-gnuradio@gnu.org https://lists.gnu.org/mailman/listinfo/patch-gnuradio
Re: [Patch-gnuradio] set/get gain for quadrature_demod
On Mon, Jun 20, 2011 at 11:52, Johnathan Corgan jcor...@corganenterprises.com wrote: The only issue with the patch is that for property getters we simply use the name of the property, without prepending get_ in front of it. So your get_gain() should be just gain(). I see now you just copied what Tom did in gr_frequency_modulator. I'll see what he wants to do. Johnathan ___ Patch-gnuradio mailing list Patch-gnuradio@gnu.org https://lists.gnu.org/mailman/listinfo/patch-gnuradio
Re: [Patch-gnuradio] set/get gain for quadrature_demod
On Mon, Jun 20, 2011 at 11:08 PM, Johnathan Corgan jcor...@corganenterprises.com wrote: On Mon, Jun 20, 2011 at 11:52, Johnathan Corgan jcor...@corganenterprises.com wrote: The only issue with the patch is that for property getters we simply use the name of the property, without prepending get_ in front of it. So your get_gain() should be just gain(). I see now you just copied what Tom did in gr_frequency_modulator. I'll see what he wants to do. Yes, I just copied from Tom's commit, however, I was just looking at the code for the gri_agc2.cc class and that too uses it the way you mention, i.e. without get_ Alex ___ Patch-gnuradio mailing list Patch-gnuradio@gnu.org https://lists.gnu.org/mailman/listinfo/patch-gnuradio
