Re: Make Acked/Reviewd/Tested-by tags visible

[Jeremy Kerr]

Hi Yann,

> We would like to suggest that the web GUI and the pwclient CLI both
> display such tags besides each patch, a bit like (hypotetical output of
> pwclient):
> 
> ID Tags State   Subject
> 123456 ART  New Wonderfull patch to apply quickly

I've been looking to implement this for a while, but didn't have any
good ideas about how to present this in the UI. I love your proposal
here with the flags, it's simple and I think would work well for the
majority of cases.

> Since patchwork already inserts those tags to the commit log (eg.
> pwclient view PATCH-ID), I hope it would be easy enough to also display
> it in the patch list.

It's easy enough to pull these out of the comment at patch-display time,
but a little more tricky with list views (without some horrible SQL
joining). I'll work out a nice way to to this; I think it'll involve
applying these flags when the follow-up comment is parsed.

Other projects have different policies for their tagging (some require 3
acks, for example), which will introduce a little complexity there too,
but that's not insurmountable either.

Cheers,


Jeremy
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork

Make Acked/Reviewd/Tested-by tags visible

[Yann E. MORIN]

Hello All!

In the Buildroot community, we make heavy use of patchwork to track the
patches that we still have pending. The maintainer (Peter, CCed) almost
exclusively use pwclient to get that list of patches to apply.

Since we also use the Linux-like tags Acked-by, Reviewed-by and
Tested-by, this is an indication to Peter that a patch is ready to be
applied.

Unfortunately, it is not easy to know at a glance what patches have such
tags, without checking the mailing list, so for each patch.

We would like to suggest that the web GUI and the pwclient CLI both
display such tags besides each patch, a bit like (hypotetical output of
pwclient):

ID Tags State   Subject
123456 ART  New Wonderfull patch to apply quickly

Where each of 'A', 'R', and 'T' would mean Acked-by, Reviewed-by and
Tested-by, respectively. An uppercase letter would mean two of more of
such tag, while a lower-case letter would mean a single such tag.

This way, it is easy to quickly sort high-profile patches that can be
easily handled by Peter without too much work (patches with tags), and
to the other contributors (some in Cc too) as a list of patches to look
at (patches without a tag).

Since patchwork already inserts those tags to the commit log (eg.
pwclient view PATCH-ID), I hope it would be easy enough to also display
it in the patch list.

Regards,
Yann E. MORIN.

-- 
.-..--..
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN |  ___   |
| +33 223 225 172 `.---:  X  AGAINST  |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL|   v   conspiracy.  |
'--^---^--^'
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork