Re: Make Acked/Reviewd/Tested-by tags visible
Hi all, > We would like to suggest that the web GUI and the pwclient CLI both > display such tags besides each patch, a bit like (hypotetical output of > pwclient): OK, I have some progress on this one; but wanted to make sure what I'm doing is in the direction that'd be generally useful for you. How's this look? http://ozlabs.org/~jk/tmp/patchwork-ART.png - there are title attributes on the column header, so you get a tooltip saying "Acked-by / Reviewed-by / Tested-by" when hovering over it. The actual numbers have specific tooltips too (eg, "2 Acked-by"). Also, are you wanting to filter by the presence of these tags? Just non-zero? How about sorting? Anyone have objections to adding a small column to the default patch lists? Does anyone want to *not* have this information present? Cheers, Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Make Acked/Reviewd/Tested-by tags visible
Dear Jeremy Kerr, On Wed, 07 May 2014 16:42:51 +0800, Jeremy Kerr wrote: > OK, I have some progress on this one; but wanted to make sure what I'm > doing is in the direction that'd be generally useful for you. > > How's this look? > > http://ozlabs.org/~jk/tmp/patchwork-ART.png > > - there are title attributes on the column header, so you get a tooltip > saying "Acked-by / Reviewed-by / Tested-by" when hovering over it. The > actual numbers have specific tooltips too (eg, "2 Acked-by"). This looks good! I actually made an implementation of this when I was in the plane to the US a week ago, but I didn't had the necessary setup to test it. Glad to see you've done it :) > Also, are you wanting to filter by the presence of these tags? Just > non-zero? How about sorting? Sorting would be useful. I guess sorting for each tag is a bit too much, so maybe sorting by the total of A+R+T is sufficient. > Anyone have objections to adding a small column to the default patch > lists? Does anyone want to *not* have this information present? On Buildroot's side, we wanted this feature, so we're not really interested in being able to disable it. But maybe some other projects do not need it, indeed. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Make Acked/Reviewd/Tested-by tags visible
> How's this look? > > http://ozlabs.org/~jk/tmp/patchwork-ART.png Looks great, I like it! > Also, are you wanting to filter by the presence of these tags? Just > non-zero? How about sorting? I would love sorting per flag. However, if filtering non-zero is much less work, I can make a workflow out of that, too. > Anyone have objections to adding a small column to the default patch > lists? Does anyone want to *not* have this information present? Also as a user of lists I don't maintain, I'd like to see this information. It gives some indictations when hunting down patches. Thanks a lot! Wolfram signature.asc Description: Digital signature ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Make Acked/Reviewd/Tested-by tags visible
Hi, On 2014-05-07 16:42:51 +0800, Jeremy Kerr wrote: > > > We would like to suggest that the web GUI and the pwclient CLI both > > display such tags besides each patch, a bit like (hypotetical output of > > pwclient): > > OK, I have some progress on this one; but wanted to make sure what I'm > doing is in the direction that'd be generally useful for you. > > How's this look? > > http://ozlabs.org/~jk/tmp/patchwork-ART.png > > - there are title attributes on the column header, so you get a tooltip > saying "Acked-by / Reviewed-by / Tested-by" when hovering over it. The > actual numbers have specific tooltips too (eg, "2 Acked-by"). > > Also, are you wanting to filter by the presence of these tags? Just > non-zero? How about sorting? > > Anyone have objections to adding a small column to the default patch > lists? Does anyone want to *not* have this information present? We (Libav - https://patches.libav.org) don't use "Acked-by / Reviewed-by / Tested-by" tag lines. I would prefer not having the the column in our default patch list. I don't care about the defaults but simple way to disable it would be nice. Janne ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Make Acked/Reviewd/Tested-by tags visible
Jeremy, All, On 2014-05-07 16:42 +0800, Jeremy Kerr spake thusly: > > We would like to suggest that the web GUI and the pwclient CLI both > > display such tags besides each patch, a bit like (hypotetical output of > > pwclient): > > OK, I have some progress on this one; but wanted to make sure what I'm > doing is in the direction that'd be generally useful for you. > > How's this look? > > http://ozlabs.org/~jk/tmp/patchwork-ART.png Yes, that's good! I believe you will also add this in the pwclient output, right? > - there are title attributes on the column header, so you get a tooltip > saying "Acked-by / Reviewed-by / Tested-by" when hovering over it. The > actual numbers have specific tooltips too (eg, "2 Acked-by"). > > Also, are you wanting to filter by the presence of these tags? Just > non-zero? How about sorting? Filtering would be a plus, sure. I'd like to have those filters: - has a non-zero A/R/T sum -> as a maintainer, I want to handle patches that have already been acked/reviewed/tested - has a zero A/R/T sum -> as a contributor, I want to review patches that have not already been acked/reviewed/tested Maybe something like: pwclient list [-t|--tag N] where N is the A/R/T sum you want to filter on. > Anyone have objections to adding a small column to the default patch > lists? Does anyone want to *not* have this information present? In Buildroot and crosstool-NG, we do use A/R/T. Other projects (eg. VLC) does not use those flags, so it should be possible to enable/disable those flags, and disabled by default (to be backward compatible with existing management scripts.) In pwclient, maybe show the A/R/T flags only if filtering on them was requested. Thanks for putting some efforts in that! :-) Regards, Yann E. MORIN. -- .-..--.. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `.---: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL| v conspiracy. | '--^---^--^' ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Make Acked/Reviewd/Tested-by tags visible
On Wed, May 7, 2014 at 1:42 AM, Jeremy Kerr wrote: > Hi all, > >> We would like to suggest that the web GUI and the pwclient CLI both >> display such tags besides each patch, a bit like (hypotetical output of >> pwclient): > > OK, I have some progress on this one; but wanted to make sure what I'm > doing is in the direction that'd be generally useful for you. > > How's this look? > > http://ozlabs.org/~jk/tmp/patchwork-ART.png Looks great! > > - there are title attributes on the column header, so you get a tooltip > saying "Acked-by / Reviewed-by / Tested-by" when hovering over it. The > actual numbers have specific tooltips too (eg, "2 Acked-by"). > > Also, are you wanting to filter by the presence of these tags? Just > non-zero? How about sorting? It would be beneficial but not crucial. > > Anyone have objections to adding a small column to the default patch > lists? Does anyone want to *not* have this information present? > default would be great! -- Cheers, Jeff ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
