[PATCH] pwclient: Don't display header for people who have no patches

2014-07-10 Thread Michael Ellerman
When searching for patches by a person, currently pwclient prints the
header even for people who have no patches. This makes the output noiser
than it needs to be, eg:

  $ pwclient list -w foo
  Patches submitted by Ley Foon Tan :
  ID  StateName
  --  -
  Patches submitted by  :
  ID  StateName
  --  -
  Patches submitted by James Y Knight :
  ID  StateName
  --  -
  Patches submitted by Steinar H. Gunderson :
  ID  StateName
  --  -
  Patches submitted by Lars-Peter Clausen :
  ID  StateName
  --  -
  Patches submitted by ainiaa2k9VG ainiaa5f8VG :
  ID  StateName
  --  -

This commit changes the logic to only display the header info if there
are patches to display. It also tracks if there were any patches found
at all, if not it prints:

  $ pwclient list -w foo
  Note: No patches found for anyone matching *foo*

Signed-off-by: Michael Ellerman 
---
 apps/patchwork/bin/pwclient | 15 ---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/apps/patchwork/bin/pwclient b/apps/patchwork/bin/pwclient
index dfbea3086275..5aa232378b74 100755
--- a/apps/patchwork/bin/pwclient
+++ b/apps/patchwork/bin/pwclient
@@ -180,15 +180,24 @@ def action_list(rpc, filter, submitter_str, delegate_str):
 sys.stderr.write("Note: Nobody found matching *%s*\n" % \
  submitter_str)
 else:
+found = False
 for id in ids:
+f = filter
+f.add("submitter_id", id)
+patches = rpc.patch_list(f.d)
+if len(patches) == 0:
+continue
+
+found = True
 person = rpc.person_get(id)
 print "Patches submitted by %s <%s>:" % \
 (unicode(person['name']).encode("utf-8"), \
  unicode(person['email']).encode("utf-8"))
-f = filter
-f.add("submitter_id", id)
-patches = rpc.patch_list(f.d)
 list_patches(patches)
+
+if not found:
+sys.stderr.write("Note: No patches found for anyone matching 
*%s*\n" % \
+ submitter_str)
 return
 
 if delegate_str != "":
-- 
1.9.1

___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork


Re: Make Acked/Reviewd/Tested-by tags visible

2014-07-10 Thread Peter Korsgaard
> "Yann" == Yann E MORIN  writes:

 > Jeremy, All,
 > On 2014-06-03 22:15 +0800, Jeremy Kerr spake thusly:
 >> > I've just rolled out the initial code to patchwork.ozlabs.org. The tag
 >> > counts are all at zero to start with; I've triggered a re-parse of all
 >> > of the existing comments, so the counts should reflect reality when that
 >> > process finishes.
 >> 
 >> On second thoughts, I've disabled the display of the counts until the
 >> update is complete, so we don't have false info in the UI in the
 >> meantime. I'll re-enable once that's done.

 > For those not checking their web UI: the A/R/T status is now visible in
 > the web UI!

Great, thanks all!

-- 
Bye, Peter Korsgaard
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork