Re: [PATCH] views: Fix "Add to bundle" dropdown on patch list view
Hi Andrew, > jk: if you could apply this to ozlabs.org would be much appreciated Sure thing, done. Cheers, Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Patchwork v2.0.0 Available
From: Jeremy Kerr Date: Thu, 31 Aug 2017 10:38:40 +0800 > Hi Andrew, > >> Ticket on github, after mpe and paulus complained about it: >> https://github.com/getpatchwork/patchwork/issues/116 >> >> I'll try and take a look at it today - jk, if I get a fix to you do you >> mind applying it on ozlabs.org? > > Can do! Thank you, I got burnt by this quite badly today. ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
[PATCH] views: Fix "Add to bundle" dropdown on patch list view
The "Add to bundle" option in the patch list view requires the user's
list of bundles to be added to the context. Before PatchworkRequestContext
was removed, this was done in a context processor. When that was
refactored out, the bundles list was re-added in the patch detail view,
but not in the patch list view.
Add the bundles list in the patch list view to rectify this.
Reported-by: David Miller
Reported-by: Michael Ellerman
Reported-by: Paul Mackerras
Suggested-by: Michael Ellerman
Cc: stable
Closes #116 ("Add to existing bundle drop down has disappeared from bottom of
patch list page")
Signed-off-by: Andrew Donnellan
---
jk: if you could apply this to ozlabs.org would be much appreciated
---
patchwork/views/patch.py | 4
1 file changed, 4 insertions(+)
diff --git a/patchwork/views/patch.py b/patchwork/views/patch.py
index c447b1c..7e962e7 100644
--- a/patchwork/views/patch.py
+++ b/patchwork/views/patch.py
@@ -42,6 +42,10 @@ def patch_list(request, project_id):
project = get_object_or_404(Project, linkname=project_id)
context = generic_list(request, project, 'patch-list',
view_args={'project_id': project.linkname})
+
+if is_authenticated(request.user):
+context['bundles'] = Bundle.objects.filter(owner=request.user)
+
return render(request, 'patchwork/list.html', context)
--
2.11.0
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
Re: Patchwork v2.0.0 Available
Hi Andrew, > Ticket on github, after mpe and paulus complained about it: > https://github.com/getpatchwork/patchwork/issues/116 > > I'll try and take a look at it today - jk, if I get a fix to you do you > mind applying it on ozlabs.org? Can do! Cheers, Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Patchwork v2.0.0 Available
On 29/08/17 08:03, David Miller wrote: Something else I noticed that feels like a regression to me. In the "bundle" box dialogue, there use to be a set of buttons for adding patches to an existing bundle. But it only has an option to create a new bundle. Although it isn't very often that I had to add patches from the main project queue to an existing bundle, but it does happen, and it's critically necessary when it occurs. But even more importantly, I used the existing bundle list in that dialogue to see if I have already added a set of patches to a bundle or not. So seeing the list of existing bundles there is very important. I would like to see this "add to existing bundle" everywhere the bundle box dialogue exists. Ticket on github, after mpe and paulus complained about it: https://github.com/getpatchwork/patchwork/issues/116 I'll try and take a look at it today - jk, if I get a fix to you do you mind applying it on ozlabs.org? Thank you. ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.ozlabs.org_listinfo_patchwork&d=DwIGaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=-pHOU8dm1U-U1crivyxKr_-xvZrIBB8YUqvA3el0Ee0&m=aHV9QJsmxD7kAqZCdTgsOolAKc8lPk7EsmvpyXbwRHc&s=A51SSqtGLCddDiwJxV4ZX_ZCFLW6o2ZzcI-lGU297us&e= -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
